From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0045.outbound.protection.outlook.com [104.47.2.45]) by dpdk.org (Postfix) with ESMTP id 86C301BA20; Tue, 10 Apr 2018 09:20:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tPyUwLANMOXJqzKzpCQGsMR5fHcwpHYPcEB245+CS1o=; b=HfuaE76+cOrn8wyMyEeDt1bexJkUN23gR53kioCvvPEYbYd+aMUbSAcNWmjMA2jZ6D37SOsSK8wMtN8sc7wyfID7ka8AcHEUulAqOrnROKCJ7P918BNGjEtf3aIfv4c8Rco8GJtlHNOOHptcuIkt7Agf21OUwI3v/E/hY9uPuko= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM4PR0501MB2305.eurprd05.prod.outlook.com (2603:10a6:200:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Tue, 10 Apr 2018 07:20:33 +0000 From: Ophir Munk To: dev@dpdk.org, Matan Azrad Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Tue, 10 Apr 2018 07:20:21 +0000 Message-Id: <1523344821-8890-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR1001CA0026.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::12) To AM4PR0501MB2305.eurprd05.prod.outlook.com (2603:10a6:200:53::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b0cedab7-769b-438a-4d36-08d59eb38d60 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB2305; X-Microsoft-Exchange-Diagnostics: 1; AM4PR0501MB2305; 3:hF2djAG3P3nReS3s5jpYO4Pi6LI/DT6370FPg9wk1zREQrADYBmn+L00eJYWrY3j1sWX1YXV0e0SxOOXrCFJoSsKpFjPQ8S7YvCfsY9tazTBneP5MiI+1U6mliNNCQcLi+fwTGlsDNEpQkOQcPvLB69XcytV7OqQWc5DS3lobohaebXu1xb7MBKBDrhZV6M3ua8KGZVzsIQLy2V2I2TR8Od664tlBy/bGimU88FIypzTyRZ++BYhUcuEtic94vkB; 25:meblwdTOLqWDc5nC2hSGWEgiCH2gyA8fR5o9kjTk+RMqkjfbrqKRx88mW5p6ODpguxqiT2fxmbeuHN6zmKF7GkumTcoCQA8Dgvxi+sBvsIbqWAYP5lqmkw0w2zV575oP6mceVAxytXxVgN2DXZhjcouTKgkCsg4tPp1bLkmAv7dKoXwlZW8xUnLSzWq+ljaYCTPvC/AT/9KtpFgZKwT8TGkZ4GtKzjvzbPUR976D42QsVU3oafFRPBi31Ck+WDhcYkRSBuWPn8KrmfgFFlyVbQOzYoNXjCIa7yesuVLf5E3Oeob1+1xzjfQ4LfxBuBtZReW7Vk0Q313c++xOs5SNrA==; 31:Ebu9gDFHeInf7VoHT1eMaGcN41q8qd7LWRtL9DslLtIlOs6IGQwlMrsRSxwwMS5LHCbW7uHHfXJCuttrMgkxhIU5n5JvpSPa7Jbz4+KeEaOGrDwChidS5B3AUM5Y0pIU0xJbiI14Mgi3Ecj+M6TEUPkAxdeXan3x1a1R2jZrWDDZqVNC+wRWVDwAFFei1eQH/cUh36nz1z+4s/iOp3deUVZRn7E0TSlObtcJT8cZ0gg= X-MS-TrafficTypeDiagnostic: AM4PR0501MB2305: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR0501MB2305; 20:KDUy0zzHaAIZSPFzlT/y9MguiW/gC8SrJvTsSDhmwh4b5kNnRtey1dPvFACiVG4K25t6aNoPunDN4Y40ow//odJ9jSB0ZB52sQidw44b+6ukV2qlx0mINHPuEQs40wifFNND/ftmuEVWus9B7s91XtwIDqsVYQiZ3qikCJK38w6gI7kOGau9Va9fTwmTYQA4hFNWvJ436A8g4CKaeXfDRP4+WnCHYvLfJ5EVERUVb20KD9CnGnY59vls/OWszVaWme6K3uWFYU6oCLbXWdPbiDra3Cd/t6iJkJObIFeytzeq/Ntusu0XXlqvXhNwKag1L/3qpCU4lUs04XrHY5RjqCuzMtYIbBzzYSmsn9xHTjvL9PjOqSlPqASOVeVQMM5Fezrx8ZqW6HhqlwwSzv2EJQN6lT52XdQGLm1lJJyDzltMAkcrNnsSpEkTQacjyA8KPHgUJAJEJFhBXw+PpBYyQhGnxzlUDAyimCwN28SCvB0xtYpT/9i0bdfr9+lhyBH+; 4:lc/3+OT75jIIxrY7lPUiuqJIbnSe9uEgU75Ab5zVHDBzdoh7uhOi+5yODrazJ4BxcGk6b+UW7CubtwCj35RhYhvilCzUQIdCyJkkYbvX5XWMqf9nirccibtejNgAPAUi3TfjBze0/+xYxbLLYNFkd6IYgFK6q7QxQov+ZjDrzVdrKKhuZ0k4Jkl99QTSivVk1QLeG7S7YfDl+M72G0L+0RRI/Vi+S/jjPysBaH7JVscHkFQ4a3FbUv5p4dIvZoKPm7EDGTClKpx0qcsfFMVsig== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0501MB2305; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2305; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(376002)(366004)(346002)(39860400002)(199004)(189003)(106356001)(386003)(26005)(37006003)(47776003)(81156014)(97736004)(54906003)(2906002)(66066001)(478600001)(8676002)(50226002)(48376002)(50466002)(316002)(81166006)(52116002)(51416003)(5660300001)(6116002)(8936002)(36756003)(3846002)(53936002)(16586007)(68736007)(55016002)(7696005)(4326008)(33026002)(25786009)(105586002)(69596002)(6862004)(16526019)(4720700003)(86362001)(486006)(6666003)(186003)(7736002)(6636002)(476003)(305945005)(21086003)(956004)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2305; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR0501MB2305; 23:6Aje5E9irrRe2KEjXdauDKTh+KtgiO2kDB20T+y?= =?us-ascii?Q?3W9qrhEgAQrU1raR/ozrT6BsWPASHEk6bh6WqU7sfpYqaPvXSE80L8EzGAGt?= =?us-ascii?Q?qgy4B11hKUHsZbI2dvZuhI5o10k9FsdaUbuun6fStTttkl9oDE2nIFejWqaH?= =?us-ascii?Q?wMgxTM8mX3tkIBGni2s23LyNe2y8RiKsl2EyRWDEPa+FTcCi8i4jCkAtv6SR?= =?us-ascii?Q?tzAhWmsQ9vmzmkny6uWcUrJFXRshBPyNS/zYvRhPZ1iabLOMRIimRbmMORRr?= =?us-ascii?Q?U/aL4XS8feociROp5h+TQpyN1V7u5fCOt0bZV21KOxWCOX2/1JAmnBciTPk/?= =?us-ascii?Q?WLKUAP8cH13JbQLQgAhc8YT0j4Yce5jCapUqW3cTmUo+iRRVq4tUAD6MOmak?= =?us-ascii?Q?pmzoZDzc30Ua7lz/8YeGfLpyI++uEIDFuG7/3OlnI3UW7ut3W2RDLD0hoUgC?= =?us-ascii?Q?bH/Byj7Blxn4OqostCSOus/Hdn6I10Qfy8iBO2G7MGDKYJGnh/Yukw03fG8P?= =?us-ascii?Q?/nxm7CSPiUoXiIj2gbxp4VP0uqFbQ6lh6UxSIrxYYUnci0cBPHdnDebWL3x9?= =?us-ascii?Q?oX0dCCFzuTXUIKtXDXktS0mUu7lFI9A5hKm1dyStunHWqnwZSR7uemAoB4JR?= =?us-ascii?Q?CTu2rwouEFuhH5BZxgAb56GZ5uTsBwoltshaijDS39kkXo5l+rBacxwIPNeg?= =?us-ascii?Q?+fqBMRYkY4q79Q9qM6uUA9A1saR5moe3qVTiXgYR33g2TZa17NZrwXBmb1QV?= =?us-ascii?Q?X8tMV3PSEZD1jnsiRrrfk0p6nfWRkRlU7QWqLE1r78YZUWIjBZhOAvs4nTa9?= =?us-ascii?Q?N2GL1K5G3i2uJT7T1I0ySvcdYkcE9K9mMkuMS8UcVtC+U4m6iA61Ns8WlHgJ?= =?us-ascii?Q?Suc5ekhDfLzmmcX7qAkJ3WZ4ONakKFgvF4CAviwJflQn2kKfXmCNZIgU+Peo?= =?us-ascii?Q?otFv3Verk4chIKOdMqff4KneyYAirMAL17h8EGTxz2OUdCM0eLzhtgEnOz5W?= =?us-ascii?Q?+btYFLjqTSz3Xam1MHYko59RfShOZ0+IQkyZJw0YLNxtvJBq7iDPoNUAbLKo?= =?us-ascii?Q?LIaKjG7w6miSblTWf4goBE6Fq3/JPuQqCp6I7xD3zeckw/5FV92Kzinhp1fH?= =?us-ascii?Q?SOfrr+lHKT8YqCits3IhtRK70l7AvWT4JOZXniTag0uDikpElHt2febbSIJl?= =?us-ascii?Q?Ab6KtbK6Jy76kyseTvQFX1tSMoeJ2eUpH3uhbserkg1A34J9Fvr7cZkci4XZ?= =?us-ascii?Q?o25eqth6HXA586sQkgb8=3D?= X-Microsoft-Antispam-Message-Info: +rD7lqQjrTLoU+y+qD18f2aa6xrR+wSwIoC0hnpEAqbOx6jqH/v3Mt3W7EY3hyRuoY1Nn7SsWSRAhwNm8LQLhL9nKmrViTZTO01zq2+J4L/iGBmpZinYqVz3bNBbnNZD6Ukm5TO/dV0aQLFM/QusVQYuJq5oA3+tUIPRtBBBcricACRO8ME1WOC/u+2OL+lN X-Microsoft-Exchange-Diagnostics: 1; AM4PR0501MB2305; 6:rJa0Ns0WnWqnIMMaq3007ALQVqFDsIKFbTnvl/OIrr8S8I25qquxoO0nkHhYvRXxxyM7pZSVeyDgLEPTpZfcSFaQNqqUrASRsevda6HwlbvXMW8WycMN/mFm4yB+/qHw3xLNDEbes/yVZGQI268jfEbt6acGWRT3EOxUpI+uIVSBylE9Y202Y+ZKpBr0mGzcNxKxgabvmIVCQsd7b5gmQEiQ32jeq1u6q5G6k9/3Jz70A8E9w0CZlqV9JxFtaZJeZviPBhHAf1ZBcgzi3871kGRS9Y0PmCNgkuyaeqxF6tWFXWH0Bxuw2Jxxr4UIBtk+Cj82ywK+hXjjd63I9QiEYO0U5FPIBJSJuaR9ZAbv/tBVI1PYSWnnMpxS8pUxJDxuDDR6fygfKye9n+qE4O5AeMQA+StvXhE8YJr926jP74MO2xucGdyH6pX1vJZ48+sufSTbc5ygTo344RH/zxG9qg==; 5:EoyeHMKOsMHvhEKefdw9yTtf8RaJUa7umT8jj8hQfDV88vIiBO+jCOUspeo1VFhIKiR5jk3T6qpxb63+6/HvoRQroRnOHFEU9LmwunDfsi0UXPEezmkNiB3X8g0ZFQ3BQHYwDbtnf3B2Wd5cURFvpNNK9QXQuuyly40bQHON0aU=; 24:wh/TS+boVxa3YPIwJtk3j12Xt9B9MA5VtQB6ymfDt3MiqA1W9WS0Qs0V7jN20s5xjPwnOCQ3D9vHiCNexp5Pcx6L9N3JTbftHSf9J05pRZ0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR0501MB2305; 7:pVBS/H5xasXRvVtsS1U8d+ADet9YGX6zZCDT33av0n9mzjpBulByrynUGdPeVPOBUVEuPyB6WBR6sYshgLN3hGvmTIFLLJ/KaMbwKUilzyO77xgJK/3oe3+GrSNLuMsnkW6gjQF6FFlqDHtDDpCejnd83wu6VXY/LAgH6+d2ECgJ7EtQwO5UNsxJ9vvwRXtTlT0I2xmptrmhgidNb5L7+l+nCpFhKdwdCR545NzD/n6AwiX8sUYMruw1mAC2RwYv X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 07:20:33.9746 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0cedab7-769b-438a-4d36-08d59eb38d60 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2305 Subject: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 07:20:36 -0000 Prior to this commit the vdev_netvsc PMD was creating tap and failsafe devices with long names, such as "net_tap_net_vdev_netvsc0" or "net_failsafe_net_vdev_netvsc0". Long names containing more than 32 characters may be rejected by some APIs (e.g. membuf pool creation). This commits fixes this issue by creating tap and failsafe devices with short names such as "tap_net_vsc0" or "net_failsafe_vsc0". Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/vdev_netvsc/vdev_netvsc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index db0080a..bb2f78d 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -614,13 +614,13 @@ vdev_netvsc_netvsc_probe(const struct if_nameindex *iface, name, ctx->id); if (ret == -1 || (size_t)ret >= sizeof(ctx->name)) ++i; - ret = snprintf(ctx->devname, sizeof(ctx->devname), "net_failsafe_%s", - ctx->name); + ret = snprintf(ctx->devname, sizeof(ctx->devname), "net_failsafe_vsc%u", + ctx->id); if (ret == -1 || (size_t)ret >= sizeof(ctx->devname)) ++i; ret = snprintf(ctx->devargs, sizeof(ctx->devargs), - "fd(%d),dev(net_tap_%s,remote=%s)", - ctx->pipe[0], ctx->name, ctx->if_name); + "fd(%d),dev(net_tap_vsc%u,remote=%s)", + ctx->pipe[0], ctx->id, ctx->if_name); if (ret == -1 || (size_t)ret >= sizeof(ctx->devargs)) ++i; if (i) { -- 2.7.4