* [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments
@ 2018-04-11 9:15 Hemant Agrawal
2018-04-16 9:10 ` Akhil Goyal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hemant Agrawal @ 2018-04-11 9:15 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, akhil.goyal, dpdk-up
The code is incorrectly updating the authxform instead of
aead xforms.
Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
examples/l2fwd-crypto/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 4d8341e..38e0c7e 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1474,8 +1474,8 @@ l2fwd_crypto_default_options(struct l2fwd_crypto_options *options)
options->aead_iv_random_size = -1;
options->aead_iv.length = 0;
- options->auth_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
- options->auth_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
+ options->aead_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
+ options->aead_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
options->aad_param = 0;
options->aad_random_size = -1;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments
2018-04-11 9:15 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments Hemant Agrawal
@ 2018-04-16 9:10 ` Akhil Goyal
2018-04-17 14:46 ` De Lara Guarch, Pablo
2018-04-17 15:03 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2018-04-16 9:10 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: pablo.de.lara.guarch, dpdk-up
On 4/11/2018 2:45 PM, Hemant Agrawal wrote:
> The code is incorrectly updating the authxform instead of
> aead xforms.
>
> Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> examples/l2fwd-crypto/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index 4d8341e..38e0c7e 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -1474,8 +1474,8 @@ l2fwd_crypto_default_options(struct l2fwd_crypto_options *options)
> options->aead_iv_random_size = -1;
> options->aead_iv.length = 0;
>
> - options->auth_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
> - options->auth_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
> + options->aead_xform.aead.algo = RTE_CRYPTO_AEAD_AES_GCM;
> + options->aead_xform.aead.op = RTE_CRYPTO_AEAD_OP_ENCRYPT;
>
> options->aad_param = 0;
> options->aad_random_size = -1;
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments
2018-04-11 9:15 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments Hemant Agrawal
2018-04-16 9:10 ` Akhil Goyal
@ 2018-04-17 14:46 ` De Lara Guarch, Pablo
2018-04-17 15:03 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-04-17 14:46 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: akhil.goyal, dpdk-up
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, April 11, 2018 10:16 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> akhil.goyal@nxp.com; dpdk-up@NXP1.onmicrosoft.com
> Subject: [PATCH] examples/l2fwd-crypto: fix the default aead assignments
>
> The code is incorrectly updating the authxform instead of aead xforms.
>
> Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments
2018-04-11 9:15 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments Hemant Agrawal
2018-04-16 9:10 ` Akhil Goyal
2018-04-17 14:46 ` De Lara Guarch, Pablo
@ 2018-04-17 15:03 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-04-17 15:03 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: akhil.goyal, dpdk-up
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, April 11, 2018 10:16 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> akhil.goyal@nxp.com; dpdk-up@NXP1.onmicrosoft.com
> Subject: [PATCH] examples/l2fwd-crypto: fix the default aead assignments
>
> The code is incorrectly updating the authxform instead of aead xforms.
>
> Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-17 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 9:15 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments Hemant Agrawal
2018-04-16 9:10 ` Akhil Goyal
2018-04-17 14:46 ` De Lara Guarch, Pablo
2018-04-17 15:03 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).