From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0059.outbound.protection.outlook.com [104.47.36.59]) by dpdk.org (Postfix) with ESMTP id 22FFCAAB5 for ; Mon, 16 Apr 2018 14:24:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LKkF6fFqJFD+qfZqJkz55RvkpbSUynyzg7cYCCtacvA=; b=mT2Ka2zcDPq9SnUD4zeY+/WZewK4A6s0sgowOJXuUblhlW14e3z2wKMSZpSlPdvavRXSEIi33n9Dv7Q4sPEA0dFcs8WkYE7rzaZsaaO7L5keVYCsM3Cj/PiYjJmN2uug2yb9VXOqZJSNWKklQWHIHkNLG5/twUFNwssnF5b1GG8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BLUPR0701MB1060.namprd07.prod.outlook.com (2a01:111:e400:8b2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.13; Mon, 16 Apr 2018 12:23:56 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Radu Nicolau Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Mon, 16 Apr 2018 17:53:15 +0530 Message-Id: <1523881395-32127-1-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR0101CA0059.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::21) To BLUPR0701MB1060.namprd07.prod.outlook.com (2a01:111:e400:8b2::19) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BLUPR0701MB1060; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 3:W9ifev7Kp0LedHxQ/TOR8G7L7rex9pNSvA03tebvNay5gzAPLViZCawKVgrLYk1xQvu/bZwmlZmILwgaf8JByt/cnEldL2wuH98uVyCihrLyf75WM6aadoplMTzYqaxSTQn3cTdKQx2PVcnYy6AW7+qzUwQTHGwUkGQzkZVBnMG+1vnjHnKB3bMLnGLJMFBnEsCS0qJsH+qTzwvNLLBDi8+Pzl1UaExCAymrCji/T7YvUnblOnQN5chTu49msRXx; 25:TChfnUa2r3JrzCaePRoLy/w2oTzS9AtsljZ6SsT5uiNqcgMH6sxGn58qts3prYMw1sB7lMdSlNpNVV6apt2J7jNZo2ax02vXLgL+H82asiSSgzP+YegdGgs7nvCpdejrW2h3XCoO1L+zd3IQprEWgDlgUU1VZbAes/03RbWKtgNeOV/gIzqUb9xvkgd2mzUxBVEqt14IRkv0bmAWIAmHdwtfv2eFznevM71oMoC16jYTKghI40U/WLQrwXd46WV658sL2XkaQxz1D8vY6VbKn9in4ltiMkCcCK1efiwbTBAOt4Z0b94CZ1eNC0zyZcUM9fB+6cySShr8yhZ2K2L9DrTjUNKqVBpOZ39PLuwTXmI=; 31:FqgvlxVJOdiPBwnJ7KpZxt1tcXv4PNUdD0QblH9dxITUChKBMJJY/0j9aXXaSSliOS0R5UDkLjNOLcGxRtOIC7KLCssqQHDZNaNHSZJ3XCA6oz2+bOzFcAdHVA5XHXyINOaywXRZ2nb/A9bcdLRRgtmRGC7xzlrQW/JKb9q6JIxf1RxFOgZ94iTxefmm+2aKCuCG+Z+fuZ+8ea5r5aveTByNZT1vO+yBztMWdrQh4jg= X-MS-TrafficTypeDiagnostic: BLUPR0701MB1060: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 20:40qzeeeiUdEp+qdkCvxoq+eYdBpS/cX9JB+HLsgb5JbTZhFN0gA71AuIxmsi1KK98YtjE/qslFER8bXVxtJvf2fIZofu+IH5BTGYL5kra+otyNh9gYcmsPRCkYfyXf1j+OLdm9IhE0s4mx4Zt56qXQHBqx0Ilkc6sjqv04q4EvtzNNZ7qAgeKKENxBu9tZJDBEAoSHE1M4d+yTbXRXr/em3ei8BQjRhDTGaqyzSWmIrs7xFGQ3R6eShbilDl6VqARC6qNy5+AMCNd177uy8lJMtVSY2uggynN0j0z7JZ3mqVZCUuvSba452oNTvQmq7WznZwF/gjetRcMR+GOYlrsxDBC2/tpSKwq9YrbszL3WOzirayyfQhGCLr6Au6qcQPdt9J57rtPCMTrGxCAWQlmqacgEJ6s+7AvSAJnzixlC2OIrIm2aUUBwWfFfgFTLZHPx77N/mHYdSluYeQTCh9fHPRnN2V+El+A8HBq//Q+yRBinzwtAd1apU5JA1xghwDaYqq9nfa7qQAbpN/X0tcHIJH1E+w8el7BhN5+UH7wfNTq0Ygy3128+KigJHEMmxctzG1dJpviaOFOOuV/uU1paYBQdIzHstc0h/S/YyrV5w=; 4:W/2tqESVarMdprMBbgHw9KeiGwnENYSDqDsNTYbrGVcwiUGfaf1GsiMpRPLjodCXueJbsSmQDibL1IFMhidvvjgX0DEsEB6761Hai0jslk450xF29Y2t+9WbC/5t5/z4EMDiWor1xoeEa2PiwruyCJVjE0c6gXkja3rat02gCO/eH2RLcxn+A6BBR118GlWV8kOXlXaPT0Rnb8K4fvdOwYHtTjJzPt5hQiUmlMR1pKA0LN31gE4PfLHJE8j4TJEzZWtgUZxGJMtDhPCfKrLUcjbdEN41cEvhIvWIEy/xEyPknh0VdVRg24nNk2KIwLMN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231232)(944501327)(52105095)(3002001)(93006095)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:BLUPR0701MB1060; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1060; X-Forefront-PRVS: 0644578634 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(366004)(376002)(39850400004)(346002)(199004)(189003)(81156014)(81166006)(305945005)(7736002)(5660300001)(8676002)(105586002)(316002)(110136005)(16586007)(8936002)(54906003)(6666003)(50466002)(48376002)(72206003)(4326008)(478600001)(6116002)(2906002)(3846002)(25786009)(47776003)(386003)(6506007)(66066001)(51416003)(55236004)(1857600001)(186003)(16526019)(8656006)(42882007)(6486002)(52116002)(6512007)(486006)(26005)(44832011)(476003)(956004)(2616005)(50226002)(53936002)(68736007)(97736004)(106356001)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1060; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1060; 23:PbmOJ0DdPYROluH5lh641JOG7pI++0apXksAUbM?= =?us-ascii?Q?AVpLyhXkASfl6aulO6Y61JZ7t2i52qnhqWav8uYqC/wrrRj2ooBU40PGnr/A?= =?us-ascii?Q?80Hcv9EKwCzZ4KYdQfhgWEalY9qWxyw71T4RyJd7Enc7ypQraxcKy7N/iYoI?= =?us-ascii?Q?JxJwPaglrVQk7wTeYGmo8kJA/xoZNdJch5qLJiE/iWq25SAjzIAKy2oFa6Me?= =?us-ascii?Q?oIAFfSYuCC7oamg3nPJhMXXdHsmyc0dqXHR8D85pOUFvmM3LLa9Ua1Gqj+TW?= =?us-ascii?Q?cuFKaQtBv8tKoaPWQaseVBadYX2Mo/sgEqoymvl4rsj5tFTCcRM+zNNlaUuQ?= =?us-ascii?Q?AHR2E/9gee7UpGAoktQrw26xcrYtQW/UNAo53naI/KkIn+6lC87Sp65UW0Wo?= =?us-ascii?Q?yusQEVu4hcAfvpyvnCEFMmNRTmkc3x81SnQVycGvLZ2mZpJqOvZGy9OdhHv2?= =?us-ascii?Q?mysofkzP4QodeEixbwBpRayfwzZaNR87xMA79N8fVxH/MnZIFFhKCxidX9O7?= =?us-ascii?Q?3M774H2c4IWdty+cYBZUhvnBcoQcomRtgo4HetQlAatD2A3DRh/jXIK54/Ur?= =?us-ascii?Q?4xk17R0GgNwCX6UsQ9Qo+lZY8MSy65qRfeIk44/qdzXLb/Ow3N8AxCb46N3s?= =?us-ascii?Q?x7qc3t2PUvGiJ3fOJZyW+PF/2KPYvpLdBhIqmZmRAdzs080V4Z3JbnMWIsLf?= =?us-ascii?Q?69yTovziRZl+qP+nWIuWgyNdQ/Dn0zpEDNV/kwiGHhMDCgIES5eZOg+0MxGs?= =?us-ascii?Q?oMAtqKBrFnGpJNhLIkcCnGaUMCq0Qk8Kq5dBv7hEaxUFjbmfsUr3EA9z5r1b?= =?us-ascii?Q?jtz/3/q8xD4Aq7knyriYAbXHRtwU+RuG3F/9biz6fbRMxLes059VGsJ/Icku?= =?us-ascii?Q?rfyGHLZgHoRXMt8p9cemCzDZIe0dZnmr4HRzj3vs73bC0Df5YqQKtZfZ9r98?= =?us-ascii?Q?qI8+cFGTcV8SzNTPgrQVZHcGzrazA8NyrAdNduUUa3jxOydkn+8mv0BzrRrP?= =?us-ascii?Q?w98yPnwYTyjAYlqjwNMwXKw0PF+0ZaBnqQ29WE82iGIIr9IRWcdjKWrxtgGu?= =?us-ascii?Q?RjyBUEMgFYmGmD3JQBNCfP6eJicnbqOnqtN+KDWaZdyp8wrqNiCRwcPBuSvL?= =?us-ascii?Q?x+Z2v+9sFMNv/JkTJnZtAWLttm6Fy2QctlO/6uXd9fa5QdlFGPvEQH2xE/Tt?= =?us-ascii?Q?FT4OGuUOde+R6zVoz/BxpNeNT9ECioyMdnvE1a5yzOeroa6Vcw9IttP4vCd+?= =?us-ascii?Q?vppONScSIDJvrZId8ir8=3D?= X-Microsoft-Antispam-Message-Info: PEY+ctuWiIvgMlUsFEMuPUHcOobq+BDzSW9WeOAZ3Ks9Ep9b3cWn/rKPjGu0YgV2vMPvU9IGyUuArX2gD1edNvBhMLHM7l+RiArO7dLOHCjXO9v7952ISxGZhF285u8Pjtkd4CRv/8epfpQsrq1PD4vdq6B8RsKNnvo2xAjISAglEXHb/p9Cg/J6bzF9gfAS X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 6:GjQtEuLCIWtzC9Ak8ijIe3rPh/44MbGL+hC8UPUmeBbDFy7BQYv/Jx5GvObh05zKrgR/mBMQ2tkYeoacTs606MpHdDpZdhXrK+u0UZ9+cpt3MqfVkfWpwvELP6gHzbz6dNmCH2+kATzUzoIuLSnBKvN3fX/daRjr0tRnk1M5AEmawYiFbbhXA542wi4LxASD214A8Jv5ETlNq+2V+aaMixQd2Jp1WqjM5k56ODzn3i7rSU9SGMRQV3owSqZZ7NRqxUuHUlLIgdb/x/6ZNtLVv/Ja3GudfHj9SB6CDwxW18x9y3BGXP78NroYubGA4fJXTk+R7n9hosa69aCGcCLzXpiRp4SlyOTHOejBVf6zvztzjJFi7APUoctoqwHoochXjlIVik5C6Ps2pTPJVwDUDz6ZGcR5J/AVZ//LORRO9nxAOSnZjjG4nFU+QS/IKhHeHi7nYs7TB02RZE7WxLU8GQ==; 5:yquitLLGwXPmSV/jdOwHBxpJlI1GFDtkAPtZCfQ29VNL5vaXwnlyOR31RX8w+g/JZbgr88ALRosXWblClUekNc8IKd3QbgwcglZi+p17QTEUaZSBBvtgn331ypLSdQmHFMcDklgd+AaKUS1BtUxXSEt4fT8OxKseFYHvtR+mGPM=; 24:m2rpV5luGjf/MxL7NugVer2ku5yCRNgAAu02yN+9pbf2yKCPwQ5rvVeNRtxOqs5Lqgux/I9yCmm6dDyo3UOktk5sn4+QVTI7oqqsRVwdUmM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1060; 7:2NQY6La6CrbD7xaa3VL4EgFbL04yJB3J7MR5OPtIaF31SDyuFBMczpGlClxr3nXyzs1Q2Gpw3Jh9xN3/x2HyOFw6qjsKHA6aD+/ZAH0VaUdRZ3aUn4nBjp91QAICA2s47X5SpRY5YwaXZ7hfqRxHvNl++ZpaX9Pn8UqJWAC6RJOhOgk4w6+FWe3fh91hkdqkGOMXgBU2iJ1PTBK5ZlUWfLMRPQPlrtkWG1qCDhYqOKVQs7HU2MVBHyT354S5A/Qd X-MS-Office365-Filtering-Correlation-Id: 3ec534a0-0ff8-4fce-f198-08d5a394ee74 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2018 12:23:56.6578 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ec534a0-0ff8-4fce-f198-08d5a394ee74 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1060 Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 12:24:01 -0000 The usage print was not updated when jumbo frames & crypto_dev mask support was added. Fixing that. Also, the optional arguments were not properly highlighted in the usage header. This is also fixed. General cleanup of the usage print was also done to make it look more cleaner and similar to what is existing in other applications like l3fwd. Fixes: bbabfe6e4ee4 ("examples/ipsec_secgw: support jumbo frames") Fixes: 2c68fe791538 ("examples/ipsec-secgw: add cryptodev mask option") Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 18330fe..1494b02 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -945,20 +945,28 @@ init_lcore_rx_queues(void) static void print_usage(const char *prgname) { - printf("%s [EAL options] -- -p PORTMASK -P -u PORTMASK" - " --"CMD_LINE_OPT_CONFIG" (port,queue,lcore)[,(port,queue,lcore]" - " --single-sa SAIDX -f CONFIG_FILE\n" - " -p PORTMASK: hexadecimal bitmask of ports to configure\n" - " -P : enable promiscuous mode\n" - " -u PORTMASK: hexadecimal bitmask of unprotected ports\n" - " -j FRAMESIZE: jumbo frame maximum size\n" - " --"CMD_LINE_OPT_CONFIG": (port,queue,lcore): " - "rx queues configuration\n" - " --single-sa SAIDX: use single SA index for outbound, " - "bypassing the SP\n" - " --cryptodev_mask MASK: hexadecimal bitmask of the " - "crypto devices to configure\n" - " -f CONFIG_FILE: Configuration file path\n", + fprintf(stderr, "%s [EAL options] --" + " -p PORTMASK" + " [-P]" + " [-u PORTMASK]" + " [-j FRAMESIZE]" + " -f CONFIG_FILE" + " --config (port,queue,lcore)[,(port,queue,lcore)]" + " [--single-sa SAIDX]" + " [--cryptodev_mask MASK]" + "\n\n" + " -p PORTMASK: Hexadecimal bitmask of ports to configure\n" + " -P : Enable promiscuous mode\n" + " -u PORTMASK: Hexadecimal bitmask of unprotected ports\n" + " -j FRAMESIZE: Enable jumbo frame with 'FRAMESIZE' as maximum\n" + " packet size\n" + " -f CONFIG_FILE: Configuration file\n" + " --config (port,queue,lcore): Rx queue configuration\n" + " --single-sa SAIDX: Use single SA index for outbound traffic,\n" + " bypassing the SP\n" + " --cryptodev_mask MASK: Hexadecimal bitmask of the crypto\n" + " devices to configure\n" + "\n", prgname); } -- 2.7.4