DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rosen Xu <rosen.xu@intel.com>
To: dev@dpdk.org
Cc: beilei.xing@intel.com, helin.zhang@intel.com,
	qi.z.zhang@intel.com, jingjing.wu@intel.com
Subject: [dpdk-dev] [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable
Date: Wed, 18 Apr 2018 16:11:41 +0800	[thread overview]
Message-ID: <1524039101-158658-1-git-send-email-rosen.xu@intel.com> (raw)
In-Reply-To: <1521090873-50595-1-git-send-email-rosen.xu@intel.com>

v4 updates:
===========
 - Add some comments for this patch

v3 updates:
===========
 - Move modification from device close to device disable
 - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous,
   so unicast/multicast promiscuous disable should set before reset.

v2 updates:
===========
 - Add more comments

In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
doesn't disable promiscuous mode, this will cause vlan filter set by
Kernel Driver will not take effect.

This patch will fix it, add promiscuous disable at device disable.

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 031c706..91fbf6c 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2288,6 +2288,14 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 
 	i40evf_dev_stop(dev);
 	i40e_dev_free_queues(dev);
+	/*
+	 * disable promiscuous mode before reset vf
+	 * it is a workaround solution when work with kernel driver
+	 * and it is not the normal way
+	 */
+	i40evf_dev_promiscuous_disable(dev);
+	i40evf_dev_allmulticast_disable(dev);
+
 	i40evf_reset_vf(hw);
 	i40e_shutdown_adminq(hw);
 	/* disable uio intr before callback unregister */
-- 
1.8.3.1

  parent reply	other threads:[~2018-04-18  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15  5:14 [dpdk-dev] [PATCH] Add i40e Promiscuous disable in i40evf_dev_stop Rosen Xu
2018-04-17  3:02 ` [dpdk-dev] [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable Rosen Xu
2018-04-17 13:31   ` Zhang, Qi Z
2018-04-18  8:11 ` Rosen Xu [this message]
2018-04-18 12:01   ` [dpdk-dev] [PATCH v4] " Zhang, Qi Z
2018-04-28 11:38 ` [dpdk-dev] [PATCH v5] net/i40e: fix disabling promiscuous mode Rosen Xu
2018-05-08  1:47   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524039101-158658-1-git-send-email-rosen.xu@intel.com \
    --to=rosen.xu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).