DPDK patches and discussions
 help / color / mirror / Atom feed
From: Juhamatti Kuusisaari <Juhamatti.Kuusisaari@coriant.com>
To: <thomas@monjalon.net>
Cc: <dev@dpdk.org>, Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
Subject: [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check
Date: Thu, 19 Apr 2018 15:00:02 +0300	[thread overview]
Message-ID: <1524139203-92094-1-git-send-email-juhamatti.kuusisaari@coriant.com> (raw)

Handle properly a case where DPDK_PATCH_PATH is set
to point to a directory.

Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 7676a6b..2bb5458 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -75,7 +75,7 @@ while getopts hn:qv ARG ; do
 done
 shift $(($OPTIND - 1))
 
-if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
+if [ ! -f "$DPDK_CHECKPATCH_PATH" ] || [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
 	print_usage >&2
 	echo
 	echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
-- 
2.8.1

             reply	other threads:[~2018-04-19 12:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 12:00 Juhamatti Kuusisaari [this message]
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
2018-04-19 13:24   ` Ferruh Yigit
2018-04-20  4:10     ` Kuusisaari, Juhamatti
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-05-22 21:34   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524139203-92094-1-git-send-email-juhamatti.kuusisaari@coriant.com \
    --to=juhamatti.kuusisaari@coriant.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).