From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255]) by dpdk.org (Postfix) with ESMTP id CA0E26CD3 for ; Wed, 25 Apr 2018 15:45:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mta.qwilt.com (Postfix) with ESMTP id 089BF80C24C; Wed, 25 Apr 2018 13:45:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at qwilt.com Received: from mta.qwilt.com ([127.0.0.1]) by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oeCz72Us7SZN; Wed, 25 Apr 2018 13:45:51 +0000 (UTC) Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il [80.179.204.39]) by mta.qwilt.com (Postfix) with ESMTPSA id A9D5C8070A1; Wed, 25 Apr 2018 13:45:48 +0000 (UTC) From: Arnon Warshavsky To: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, arnon@qwilt.com Date: Wed, 25 Apr 2018 16:45:34 +0300 Message-Id: <1524663944-30376-1-git-send-email-arnon@qwilt.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1524608213-2080-1-git-send-email-arnon@qwilt.com> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> Subject: [dpdk-dev] [PATCH v8 00/10] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 13:45:53 -0000 The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls under lib and drivers, and replaces them with a log message and an error return code according to context, that can be propagated up the call stack. - Focus was given to the dpdk initialization path - Some of the panic calls within drivers were left in place where the call is from within an interrupt or calls that are on the data path,where there is no simple applicative route to propagate the error to temination. These should be handled by the driver maintainers.. - local void functions with no api were changed to retrun a value where needed - No change took place in example and test files - No change took place for debug assertions calling panic - A new function was added to devtools/checkpatches.sh in order to prevent new additions of calls to rte_panic under lib and drivers. Keep calm and don't panic --- v2: - reformat error messages so that literal string are in the same line - fix typo in commit message - add new return code to doxigen of rte_memzone_free() v3: - submit all 13 patches changed and unchanged in the same patchset v4: - remove 2 patches that are no more relevant - fix split literal string in error message - change return value -1 to enum - split value and success code in a static function v5: - reword commit messages - revert thread related instances back to panicing - handle file descriptors with state to reset after eal init failure in case re initialization takes place v6: - Use pmd log macro rather than rte_log v7: - use bond specific , dpaa2 specific and eventdev specific log macros v8: - Seperate the 2 drivers salad back to distinct bond and dpaa patches - Add missing file descriptor closing when returnning an error - Remove half baked thread patch to be handled in the next version - Remove duplicate function call after rebase Arnon Warshavsky (10): crypto/dpaa: replace rte_panic instances in crypto/dpaa driver bond: replace rte_panic instances in bonding driver e1000: replace rte_panic instances in e1000 driver ixgbe: replace rte_panic instances in ixgbe driver eal: replace rte_panic instances in eventdev kni: replace rte_panic instances in kni eal: replace rte_panic instances in hugepage_info eal: replace rte_panic instances in ethdev eal: replace rte_panic instances in init sequence devtools: prevent new instances of rte_panic and rte_exit devtools/checkpatches.sh | 95 +++++++++++++++++++- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++- drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++--- drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +- drivers/net/bonding/rte_eth_bond_api.c | 22 +++-- drivers/net/bonding/rte_eth_bond_pmd.c | 9 +- drivers/net/bonding/rte_eth_bond_private.h | 2 +- drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/e1000/igb_pf.c | 15 ++-- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 15 ++-- lib/librte_eal/bsdapp/eal/eal.c | 69 +++++++++++---- lib/librte_eal/linuxapp/eal/eal.c | 101 +++++++++++++++------- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +++++--- lib/librte_ether/rte_ethdev.c | 42 ++++++--- lib/librte_ether/rte_ethdev.h | 4 +- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +- lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +- lib/librte_kni/rte_kni.c | 18 ++-- lib/librte_kni/rte_kni_fifo.h | 11 ++- 23 files changed, 383 insertions(+), 136 deletions(-) -- 1.8.3.1