From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255]) by dpdk.org (Postfix) with ESMTP id 754137CFB for ; Wed, 25 Apr 2018 15:46:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mta.qwilt.com (Postfix) with ESMTP id 897CB80B53F; Wed, 25 Apr 2018 13:46:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at qwilt.com Received: from mta.qwilt.com ([127.0.0.1]) by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gVq4xBfifT2V; Wed, 25 Apr 2018 13:46:13 +0000 (UTC) Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il [80.179.204.39]) by mta.qwilt.com (Postfix) with ESMTPSA id AC8FC8070A1; Wed, 25 Apr 2018 13:46:10 +0000 (UTC) From: Arnon Warshavsky To: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, arnon@qwilt.com Date: Wed, 25 Apr 2018 16:45:42 +0300 Message-Id: <1524663944-30376-9-git-send-email-arnon@qwilt.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1524663944-30376-1-git-send-email-arnon@qwilt.com> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524663944-30376-1-git-send-email-arnon@qwilt.com> Subject: [dpdk-dev] [PATCH v8 08/10] eal: replace rte_panic instances in ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 13:46:15 -0000 Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_ether/rte_ethdev.c | 42 ++++++++++++++++++++++++++++++------------ lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index f0f53d4..940de15 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -194,7 +194,7 @@ enum { return port_id; } -static void +static int rte_eth_dev_shared_data_prepare(void) { const unsigned flags = 0; @@ -210,8 +210,12 @@ enum { rte_socket_id(), flags); } else mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA); - if (mz == NULL) - rte_panic("Cannot allocate ethdev shared data\n"); + if (mz == NULL) { + rte_spinlock_unlock(&rte_eth_shared_data_lock); + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate ethdev shared data\n", + __func__); + return -1; + } rte_eth_dev_shared_data = mz->addr; if (rte_eal_process_type() == RTE_PROC_PRIMARY) { @@ -224,6 +228,8 @@ enum { } rte_spinlock_unlock(&rte_eth_shared_data_lock); + + return 0; } struct rte_eth_dev * @@ -274,7 +280,8 @@ struct rte_eth_dev * uint16_t port_id; struct rte_eth_dev *eth_dev = NULL; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return NULL; /* Synchronize port creation between primary and secondary threads. */ rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -317,7 +324,8 @@ struct rte_eth_dev * uint16_t i; struct rte_eth_dev *eth_dev = NULL; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return NULL; /* Synchronize port attachment to primary port creation and release. */ rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -345,7 +353,8 @@ struct rte_eth_dev * if (eth_dev == NULL) return -EINVAL; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return -1; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -399,7 +408,8 @@ struct rte_eth_dev * int __rte_experimental rte_eth_dev_owner_new(uint64_t *owner_id) { - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return -1; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -450,7 +460,8 @@ struct rte_eth_dev * { int ret; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return -1; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -467,7 +478,8 @@ struct rte_eth_dev * {.id = RTE_ETH_DEV_NO_OWNER, .name = ""}; int ret; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return -1; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -477,12 +489,15 @@ struct rte_eth_dev * return ret; } -void __rte_experimental +int __rte_experimental rte_eth_dev_owner_delete(const uint64_t owner_id) { uint16_t port_id; + int error; - rte_eth_dev_shared_data_prepare(); + error = rte_eth_dev_shared_data_prepare(); + if (error != 0) + return error; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); @@ -495,6 +510,8 @@ struct rte_eth_dev * } rte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock); + + return 0; } int __rte_experimental @@ -502,7 +519,8 @@ struct rte_eth_dev * { int ret = 0; - rte_eth_dev_shared_data_prepare(); + if (rte_eth_dev_shared_data_prepare() != 0) + return -1; rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock); diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index b9eb8ae..46e5947 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1354,8 +1354,10 @@ int __rte_experimental rte_eth_dev_owner_unset(const uint16_t port_id, * * @param owner_id * The owner identifier. + * @return + * 0 on success, negative errno value on error. */ -void __rte_experimental rte_eth_dev_owner_delete(const uint64_t owner_id); +int __rte_experimental rte_eth_dev_owner_delete(const uint64_t owner_id); /** * @warning -- 1.8.3.1