From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) by dpdk.org (Postfix) with ESMTP id 96CEF187; Mon, 30 Apr 2018 14:25:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=d/Luacd0cMT8325wi0R1Pb2C2IMwLsQqVcAer+fT9iE=; b=hTEeGLbiEWUY+7ALXq59mbzjijD/TiI6l/mNYOSfGnik6nLVJpWzY+TD7EGWIA+uWkuMliZmo5aNpWECqncZPQ+BYDeHD40bDvwfbD8ErQYA5+xzKBUymeEeqHXJ+aJJuZVqu4LPMgYK2PJazN+usWXy4b+fgQqhpKbtvIaPa6Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.20; Mon, 30 Apr 2018 12:25:14 +0000 From: Ophir Munk To: Adrien Mazarguil , dev@dpdk.org Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Mon, 30 Apr 2018 12:25:01 +0000 Message-Id: <1525091101-10782-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: PR0P264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::29) To DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2309; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 3:7W2GZ3I/4E7KkyXYIz8WSQZdD8kUZcKRgSEIQcsaJSafk9+lVwl5t/BPPPlfUCrZYjc2JBTtyPOIFuuMcbug3/AFBizSPRNIPhIVdNy5G43MmvNK1SgziRwpHDZCc9PnpB+Sh5ex3DXjKcHNwr8Wsrz/dC/RZmkPp9Sp/avsOpNeGtzYKvdA1Q2dF+w6Jxx1YQE5X26ZVtNhDP3rheyOpicnazOMZDSJIELjYrKeEAsrFg5Aqq+KHmHkzAigE9Ue; 25:ia2DOVPCK72Xu9dH6wtUpTwwhJdJeQD1H9MBqc4+MIApV1T8/8pZn9yuz+U04iXXz1pUR6FRULRa+qL7g2A9521ullBQHVe3ETBOT3yrj53O+1SpI2k7P6XoIdBELpmwx8twqLjEyALmr9H31DIO9XsTWr5BqD5wNmBeIqiOZxmz9eW3FESQMrneHyXgaXmAA1jUll7HaxXMifvW1ArMJfq43Q8mCCR6i8L8/6GvtzKY25QnIkIjHR2p5ilmqumiUWCxG78K4SOFB6FFKNjggS1hroAPYMBaA1iuYrxVDxC6vsjz9uiqsY68Q1Q/hyMvvLSA6E9Sdhkbs3VP2C0l9g==; 31:zWNT+9Rr8PK0oTYsUGis670CGgRSGdxo0i7B3n2lzl2mq49u+/9xUgeyageXn+r7HHdYJ12H2xtb2WvGLJ8lovZZwMHLyoUnvRSY+5mD0335AFXCVt3EM0Nx5ZQDFHg95/UZe50aLSCGuc4yT+imYBHRQj0e63pzaIbrAV3ScfoWV/FjJS1JRKGK99X0qWROSMH6C2KkZD0R8PoY229o46KfR+u+kA5Pasheea+mr34= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2309: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 20:ITqXCFSoPsZyDuinwGx31BdHRTbXVpIXwjI98EI82csJOBkFe+oG1ydpnpmz24Pz90yLLsMje9IqjOUohuoIhJxwOWXefoCiKSQl8E4bokmXK/ZrdoMajVInDTUHJ/ycBh14mkB/RHFJpRPiCCX4qvasa+bZWow9JUH7FG+iakKroN1/7xBOY3WMG977cnUZ6El7wP1Z6k02W9G71ix2QL3PpT9PEvVqNSrrur3Q0mHdql/awfkZUSCQvcj5uz8+OFVxRJBFyTIdzbbv2uMwMTe2NYXTMqQ7wbcoauHNXPfo80v3F1YmK7205zgHGU7+Y7zp+jzSHnfALMXAAC0rLGXKGrJhdNVszX9DK7MYLnPNI4p4gg0e50CTUoim+LbEceIB8MGcyFvBOoYBhGDt9oSWOTaiod1to+5f1m2DyCkMX3D/SCpP0BtJPJa0p3xPZ9XYNyuvceuqIGI+jTqcBa6C0k4cxzuaHskeAG0iCeKZyeOp/lBIHL09mEj4NGF1; 4:LDq8+c7p6hfbCnkmiytjfBAGsdVDLJXxEINxznodHnEU1ci2aSmxon8qd64yQ1xLLK4jJEdtIKdJmiSTyXt3wuCuDjIt6EnZNcQ+1v18IOozgs33r0VC6WjKHjBa7dyHaa6tEUDdw1JdS4Jz+Z5F/YjzZbpK+UFeNp/HknYFvL0EAQb1ZcgvqLiHpoasCPTq7Ig/xUAIsZw+wm9T4OcbkImWFISZXz4nRD13QkcbhM5WXHGGhHUO+ot4tAwWT4ptYVXD22E2ae9fw247gT/7pA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0501MB2309; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2309; X-Forefront-PRVS: 0658BAF71F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(376002)(366004)(396003)(39860400002)(39380400002)(346002)(199004)(189003)(55016002)(6116002)(476003)(25786009)(97736004)(478600001)(7736002)(54906003)(105586002)(5660300001)(106356001)(316002)(16586007)(47776003)(2616005)(69596002)(33026002)(486006)(2906002)(956004)(6666003)(51416003)(7696005)(52116002)(81156014)(66066001)(8936002)(81166006)(4326008)(50466002)(50226002)(4720700003)(386003)(53936002)(86362001)(68736007)(21086003)(186003)(16526019)(36756003)(3846002)(305945005)(48376002)(8676002)(26005)(168613001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2309; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2309; 23:a85chbqO/0CbI/tgY1rw/E9tHqAwD5SJCYZwG7Q?= =?us-ascii?Q?SgLawsoHczLk4ipFazbYdfUskY/PGNd8M/3h/qNwTmvQ1HuapXWlbcwG6MEk?= =?us-ascii?Q?+4Aubl7NgJq0AyYNvEEe5Vt1DTkUZOf0Yxt1+9cpc/upSNFUmN1qkAuFYkUL?= =?us-ascii?Q?5dLqBIDnlc2PQYeBoRCBMJhVB7y+d0835tAugU82bu3mlEmJTMQINCXEG2aM?= =?us-ascii?Q?5UwgHF9zxJubj+FHkNO/1EspCK039/uH9m2+zdMgSALkBaMPLnF0C83cOSqY?= =?us-ascii?Q?i+WE9C+WTgUyFD2/Gba7dwc0G9SHZok7FnrIuDJvXJ5Wlmu+YwST8Yme9ZC2?= =?us-ascii?Q?JTFaUcZoCrjn1Nt7XHvCzEQm89pnXHoRYKs3aQOGJ0+IDZRfIpkMAI0aFiPv?= =?us-ascii?Q?dQ1cJxFRskjDi5Z1kIxSHTSGHQRlfDW3DGfj1t0vXo6yxAgY0vmZ7u23wCPl?= =?us-ascii?Q?ZOPIKhD7RRyPff3ZIlirVtNtp6GJ76bbTOr+wRHox0tCIPifow4+7b4b8iBc?= =?us-ascii?Q?/qZaKVoEnWcfyy4/TDYAAi5CKKTic51/FkKAYQHfCmbOSMXEENTYVbzGiGuV?= =?us-ascii?Q?xwpddZu7XgvFO7WVZJ+f6c0gWjnXtsB3TWgw+krXMpAknO98eXIzTyaB2JUe?= =?us-ascii?Q?2EcRqbyw8CR+xSMvcJRtrjDGhDLgmFMEfyJgXDEphisGuXuS4d2j1IleQRaV?= =?us-ascii?Q?Gn5jHWk+ZLK61MV5RPJZ27XRVty2KLmOkV7I+xxyATvlomhMGsYPkRcuVdh5?= =?us-ascii?Q?9q5resg+7kbi+0Q1KrTbOb/oPiJ6ZEo2DZMfG2FOXasqeBdEBqQ9Lzp2yUPt?= =?us-ascii?Q?4zpbZYv1cLQy57wHW/BxGuIEUUrCBcg0hVDnwHhKR1M/AgK6/27bNuZfkyvd?= =?us-ascii?Q?E6umRSuD4Id3w58IzigUPEOxBdSDwx84j4bO9ahF8riomm2wEC+/dhI/Ohoq?= =?us-ascii?Q?ZnOMn/fY+MORrSip/3pTBEn/kERsNM5Bqx1pLwUnebxa5jJuMwvE88t2fo1J?= =?us-ascii?Q?BMLXW8J9n+Ea8gcLFx+DnxpB4M/xx2SOKZHn7WxKhXTbPsdgCEaMdF1uQWUo?= =?us-ascii?Q?VLvnx9qDzg1Zil31tkgwphMqpiI5yHApW4uBm/d4bnRGyNv+P/MygjNuqywv?= =?us-ascii?Q?Oc4AOZOYtw59Z5QJkRCeOXo/YtOaT6/aOFMmP/KoHeZvmaGCjx5PrW+lxtO/?= =?us-ascii?Q?0VF2hNJzaVhMJImEESc0Z9RCY4Okg3XTJFvyGLG6KzaCQaBnOe0FII1pRaIb?= =?us-ascii?Q?xNlJsq3k55XXwyb61neA2TGCe2v/IaIYCIeKOzpxXtcIjDfl7RGvfY5dVWIW?= =?us-ascii?Q?XQE9Sfcn0vHYc+0pg3d5axTM=3D?= X-Microsoft-Antispam-Message-Info: GpQKWKwRgXtaAprrtQ4Eo5J0jG1jVxnZ9I7tK8Bqc+j2ehJ3E6fZrlazH3RkKIlQIoxsCZhTfq37larTe0v2nGep6yw1hSyCdafS1otTAtu9iEXIkA/vu21IypxVDYXgcgeQ/WFnK1gkD836Cg3Fumgch7g50k9Py3gv8oonFN2i4fDsKzU6q2qmzZRm7/Tb X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 6:QUFfpwBs2JF0PpzeCAWrTf2Rnlc4TUQx7vqlWkcMimmxPOy8Dx4cDl6yNAz9qpQN3FovBxAgyTP98klD22lDmXEw/guK+Q0PoaCBRTt2Ou90KQ3NoswzSewerpwyWmcaOfmnYwtKJYJFmkbM9AxA6BZUNvG7m7/Azwr9jBX1Rw/aV3za/MyaRjeUpAI5nPRRTN186a4Bcrnsu1hwGwjkw9ci9WMbCVSVAMZwRRrZ1+RwZTiwLsCR8Hjq6wFzsy5emUCfcfiP2LkGnHacnGilfZds3MHeCHhuXoaNG5AMSDT/csjqBgZ1bskgilKjNzumhBu5xadwjdDSJRAPMUayXajCNtcnUh0qVMtfjie+Rvn5MakqUosU+Gmgr7bED+rsWqwT637Xqt+mykZ6seUi+qrvIyARgQPVfeaZPTDHCWwzt5QigWnWD4ZXYT1fZcRtTa8SEz4lMXM1AcRojKG19w==; 5:rsBNdwtHkU9yZZ/nTik7RZxdHw1ekPE2bQ1WnJMyIvKv6A2qrjGeOkvFaIauFlGxcnV5yaSRRl90idaOutLMOwsP0wnoh9xVbSI01mBg+WOod+6nW9J5krRf3rXV3vwna0AHXEGl9mCgLTwksOzFFVrSZizf/41pc6yzRsbo9Hs=; 24:2MO7wKo3qSMyofO/28rIApufHCyHpTlB7e901bb2nba5L+w/4MCdfOnCGbAvAEQVhE7RudnSueG4msZz3N07seabUlMt20ElZBs243G5cKY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 7:bFDXMF3JE+7iFMmbzsssMHxxU2cZPPLDScmwSys25lUBil0AlMN/noDH5rH7mCotiY1dd6f654w01sIw/7YEh9mibPRRBLqrIkwXdBHluFFBDE/Od5XbJN0z/ZeVoy2qwBKZO8BxqnxVyamkSX6lNRAwp/boVmURA3neW1sFJ5ON9gXP/yTCFFRdI5hprPcbBMEPJLHtkKsAbCCdmRF8hMZS4+KKzyDQAKiloHWCZ65l0h6/gq6aypQb3KKwiREX X-MS-Office365-Filtering-Correlation-Id: adbf40cc-74d8-4404-f6cf-08d5ae956daa X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2018 12:25:14.6074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: adbf40cc-74d8-4404-f6cf-08d5ae956daa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2309 Subject: [dpdk-dev] [PATCH v1] net/mlx4: fix CRC stripping capability report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 12:25:17 -0000 There are two capabilities related to CRC stripping: 1. mlx4 HW capability to perform CRC stripping on a recieved packet. This capability is built in mlx4 HW. It should be returned by the API call mlx4_get_rx_queue_offloads(). 2. mlx4 driver capability to enable/disable HW CRC stripping. This capability is dependent on the driver version. Before this commit the seccond capability was falsely returned by the mentioned API. This commit fixes it by returning the first capability. Fixes: de1df14e6e6ec ("net/mlx4: support CRC strip toggling") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_rxq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c index b430678..88e5912 100644 --- a/drivers/net/mlx4/mlx4_rxq.c +++ b/drivers/net/mlx4/mlx4_rxq.c @@ -658,10 +658,9 @@ mlx4_rxq_detach(struct rxq *rxq) uint64_t mlx4_get_rx_queue_offloads(struct priv *priv) { - uint64_t offloads = DEV_RX_OFFLOAD_SCATTER; + uint64_t offloads = DEV_RX_OFFLOAD_SCATTER | + DEV_RX_OFFLOAD_CRC_STRIP; - if (priv->hw_fcs_strip) - offloads |= DEV_RX_OFFLOAD_CRC_STRIP; if (priv->hw_csum) offloads |= DEV_RX_OFFLOAD_CHECKSUM; return offloads; -- 2.7.4