From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63]) by dpdk.org (Postfix) with ESMTP id 24A382C72 for ; Mon, 7 May 2018 14:19:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u5dYaxd6gbkvBNIZMNoJWVKUTmycFe8lEORCZhqxzpw=; b=tahi4/tdykMStKoS5O4+lx10fnFiPtf6zf7sqHeHojDwH5jwfTwJO40M75vXhphowwoLv3Q+VVhz2hY+XNLYmLWiKMNIhIXDdYQ8/l1Zzx7huP/j4omGWU5GZqBZNFjB/Gtm9GFt9PZT6+yl2rsg8gb4qLluiSZjin0+idEVnZY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM3PR05MB1249.eurprd05.prod.outlook.com (2a01:111:e400:586e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.16; Mon, 7 May 2018 12:19:08 +0000 From: Raslan Darawsheh To: shahafs@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, ophirmu@mellanox.com, rasland@mellanox.com Date: Mon, 7 May 2018 15:18:54 +0300 Message-Id: <1525695534-15072-2-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525695534-15072-1-git-send-email-rasland@mellanox.com> References: <1525695534-15072-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR07CA0021.eurprd07.prod.outlook.com (2603:10a6:7:67::31) To AM3PR05MB1249.eurprd05.prod.outlook.com (2a01:111:e400:586e::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM3PR05MB1249; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1249; 3:nKdfJNz+6z152pzoscn5XqUqWTFiCifkVbxot8QVfJTVV4Bcz3geu5lnzQKBg3w/xQ/+bNDUH2N5+Ti+rHX6n0TerSaOQ4HPvDx2wsXzz9QiGUwctpjVKzf7wGq/rNYtAf34J8OcPbSZvmm9l+ZA+Zbze3vve7h2d4b3iqZ8dqnD4B429R7XA3lrg6OT5+0M+fOZDHLk8rY9vBANGr/gednLqOIBXp5krXAe/9Nqm7ckNLVZ5BopsK14J70mI2IU; 25:vkgdrNwkMZl0+LnGdJkgZWg4kiT27v+EjAroBtH9rqMXpuB2Pr3pREt9osA7jaDojMc7QhEW+EtthLI1qCbMDQOQ5UlUkCpZYj+iDaDP28BCCDQ7VIDd9A/0wakfaBYCxWzYFaYbtIUHK1pHdQ11+KS0LLv+yGXPNHYyevvQwFDplhRgAE5auXrF93m7mG9O5UPTt2/1RjsvdnAudo19LzF8YmfI1XaheXAAdEleQXaNZjNArmaTsVsfixbKNGwC4Y5VvgtnPosi7whAp6Z1buhJj4jY6LZQCXmrLR50hTea+P+/tH9SSGewrHwP8cFq4RvN1ii4ezyzF/yz3DtDQw==; 31:HVtDN5xGrTwpSlUu0rZ8yTPIaBPKRzMYvXvrwZahJcNMlTMBDRRd2UPy2IiI4QjjZVZ/AmgHc2WM9SJAI5j9z4e8Yd8uW+98Z122gEOa/LOIUHbIDkiXvqKRemXAND3My7+7iz3KpBFmfdk27uULJkflMCQWfsGAaqNEqMvnD47+oYLPesGaKZZWLlOi/Q8TD1Y/tSykyCgcyWjevwnwYcv3pVMfw4k4kZ6aLwBa/xg= X-MS-TrafficTypeDiagnostic: AM3PR05MB1249: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1249; 20:rxjTWuo2HmbHs8W4Eq1/iRB2ZPFIkCd1nIl+C8kfdWHJx1eia4MGlSg6lUw2ayqWyC8KMHDG3s+x4gNvJnJqHLbKlYQPUlSDVTISLwxaf1GfNwf3cWblXb1hexm4fWQaw7A038xHuNSfDkv/cnCfZ48RDLxCJ8ty2qVOGDTHfBcfbYIZEsk2pMDeCHC8NMLoneSmg3KEeyWKKt1wOc7plMqus4VR93g2QkFfzi4GH3KC++UzKOHZ4jxIc2jlx3A+Etvk22QjpLAK2hZmwolsB5ttKrw4PTxJtc2pwLTS9vpVLluVgGnW5UUtxHthGzGIbPNc4J1eeDjKHG9kFMRZlgBvV5bHd3g5yJzroWVHnLXeRcVzspPv0ULI1SNsXiujVMi7s97PX27K3Gqg5y60eROBYbLk9pPERBkf4rLIAj+FUNoJcwO35e6fZvt3iTHBndhuWdkiWhmsBohDpWQmomqGu2sQwjSKPArHNGXyQXkNaMP0fetdYrHsjtF9pAnd; 4:JmC6XXIfdrf12n78oWdtT2URFtIqkeYyOjoiEapLA4aYilSKfuBiQLvD5krzzIME8qoXNEi/X7hCF81QJIZDvqIzOuS3Yq50mz1qVAFuNO5Bcdbt74U06hyQgF5FH8B/LWHxdhaF63TfphL31zyseVP/rh7hu8OEOC5ItR+1d0tAWnwb4WWW4O7k26x5X+xNg5McgR2/GDpT6y210vdgFfOuDuUzDaceEYQv4KVn7OuMLIc1IwtHGt8fwamtJWWLJa4vNxfIr/vrzXM/5zZkhA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:AM3PR05MB1249; BCL:0; PCL:0; RULEID:; SRVR:AM3PR05MB1249; X-Forefront-PRVS: 066517B35B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(39380400002)(396003)(366004)(189003)(199004)(53936002)(48376002)(2351001)(2361001)(2906002)(105586002)(16526019)(68736007)(33026002)(4326008)(69596002)(21086003)(26005)(50466002)(76176011)(86362001)(305945005)(5660300001)(7736002)(106356001)(16586007)(956004)(51416003)(478600001)(446003)(386003)(47776003)(59450400001)(8936002)(3846002)(25786009)(66066001)(316002)(50226002)(11346002)(2616005)(36756003)(476003)(7696005)(52116002)(107886003)(34206002)(81166006)(81156014)(55016002)(6116002)(97736004)(8676002)(37006003)(486006)(6666003)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB1249; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR05MB1249; 23:QP3jxhSSOcAj5kcB4nbXoSFPANIW5+IzRPwy+aGfW?= =?us-ascii?Q?Zc3x6yrXD4c4JNGppCn/1VU6tzT5zBrc66Cmkl+0nDoWESQTNp4K0pUg2Lo1?= =?us-ascii?Q?J66Or4YZEvX9limfz+v4tzbhhzWc4669QewyyY0mpGAttgkfTnFHjIDoAIBe?= =?us-ascii?Q?HvFelgWHZ9hO8MU+wfl+4Nrz0ZEFCYAQU6HuIub+OQy0N7aSDVyj5JZeOmGt?= =?us-ascii?Q?15Vm58aCRYDmc/MP9uxFfyxj9/36P8ioAwHW23QzMViGOx9me6v6UGmIa7nE?= =?us-ascii?Q?r5brUEQNR5ZVJ7sDK8I8eK2jj4S5h8ROP88rbwLhGKPzHLKmSpbUwGv3NYCG?= =?us-ascii?Q?H1f2xEYfoDDPfMask1U0dHA75M/5rHun8BnosPJpy0DIPYqPc49Q/ho6VFTa?= =?us-ascii?Q?VcYnVkliB+bUU0oFCNmB238lxLjRjXDh/+lOYLvbLYeCAS88+kTveBwODkky?= =?us-ascii?Q?lspueuODB16QDJ7aC9N6X06l8NR73jT5ShHf8g2zkTY2B37njK4FUglaWpZ+?= =?us-ascii?Q?i/q79OGsMm8DIVY0didv+tVQAUu9B3cN2pxJzof8Uvb8ZwjlPBsaVZJp089v?= =?us-ascii?Q?hncyaw75NbE8WxvPxEh9exeI6g7wAV1Hqn/9XDn5bphtiH5CnA21jn0jxQ6B?= =?us-ascii?Q?/f3L0edvQ1VRuIzGBjT5SG/8h/fM2PsZUexpF3Vq1V/3ofzDBO37Bvxcrq+j?= =?us-ascii?Q?Xl/oTTQSzv0QUwVfTUV8y+XI9Y8MxBswfUHAVIMF7TfTl0Jstje8X3AzgeWQ?= =?us-ascii?Q?aAg4FtO+yaxTbe4XQVwwiheGpseAL+mwm8L2daThu77bXrwKyhxgyYOb2cFM?= =?us-ascii?Q?BRxGuVHcC2AfBUGBH8GGbg4KMn7adj+9Npt3IPS4IZQA6wJ8mzKASkaUt3ZD?= =?us-ascii?Q?mhD23OvJa/SpaQya+5wtBcDnqfIhk8rkg4id1AI++Q2z/dqDh0pXYdHwxwjn?= =?us-ascii?Q?OuCFst51QBLxukKGUpLImEEeBNNyyN44Ue+RSsqQhzM6Quyyop2OVlN3Zsla?= =?us-ascii?Q?Z8Fv5vi9/WwCfhRvA5sbpq5n4v1t2vNQu55TntvheXRCEfGzXXgxru2/g8qv?= =?us-ascii?Q?KjqJhfzpSAnj3NSF/MzvE6nQVLVTNr2T0hfH011U0Hui/VsQbPonOkXxCf8H?= =?us-ascii?Q?+6RaatJN8SYjjwgx3mVBYHapcKk36c9STEaq48BPGjKmKcp1Mcu4E44e9i+2?= =?us-ascii?Q?yqXUksLycBYzchY1/IpJYU+upPZVNdj6WBG0VmsmZQ+gZVaCK6ojid1G1bwm?= =?us-ascii?Q?86bYdevcDB70E68gReRjqSi945VNkgo6x3kCqJMnSzHnyL9hvMMPi/CWqfUo?= =?us-ascii?Q?HGZS9lfgoJOa5lTYTEDm6MI4O4ccbMQiEpZk290v5cW?= X-Microsoft-Antispam-Message-Info: ginq5eMkF7zkrmVz/7N2qt/D3ljLTkX2RotJFaDxD8B7IYVQWyjvMQ+/x/wBniCCJDI3PQ+D0ZmgCixADdMePFcA+MgHxW7Bsp2SXWPW8K/puVjH9dX6bc1KwqgcY2HqLFnP1O2MGb8wz9tjqQyd4rsFwLASaghlVbDsqaXEwkn+2kHZfaV3ez3/gy0rJFb/ X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1249; 6:5wUUnRKRl1FuBsoC/rbFXVkxc94fRjETjLCdE50gg3TII2Px+B6MwmwYFbyRHTNmVDt/ni7ZfAlGxmvJJcZct7eWrZQCDXF4AERdv1YTZe8sJqVQ/EbPwKV9cp6PHyEzZFFEXDUAk5mKLWs0VEBDT3QSSFZdQr4NYpJyQI/AYvmSCAgzUjBIJOH22pne+V7RBoNw+26ueOigiWgfoW4LRjjl5FjueLnncQHWtggvxyLH5GaTbGdCBFplNWxw/OdP8ztwsheQPQ9xkdrudwl+OO4cIgTYAeDjQv+5oOxRM961wTw+vrTd0/AHs0Ys55MzM7jKYvHWv9tecR5m2bFZ/x1loV8XAf/xqtx7vzLfigItFYRo6ljBFWpIqW+8LlWmDuMpYonc4WWLyHuLdOEU/n3as+abbbGhMAP5t3mUNnsGwGo7puZdf436fHIwqti/70k5hQLT/8y2skZgA/NlGA==; 5:K0WBYt8jMce1d7SKKSzX79bvP0112SwU0RIU9rqh6QGo1+5w/wA59S6+RHJkn0WMc4DESPqNZ4BC+Ljjiqx/gw0EJkMbpQBFh1VFbo4UQrkuY1czVToO23vQBi/f0LvCHJWpn6f/wClcp+9pI4tB/mYyDV8h1PDy7j6IAqLNoPo=; 24:VOhmDEWqNbVWGmneyzT5hjE/7QlPHRzCV4vue32jQ3F3rAQdddl/TNvHeJ6HoRifoj1QmWR/LV+WPnyGdBi1y0vD62c4a4/CAQV7UcJu6hE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1249; 7:ZaBkAu1Dndvl68+S3/ebuUNXQjvZ2v4t5mvTyZNntLMj2yFwTLIMAAkyB64DztDQ2Zk5Q4N5zV2dT8DL43rxgp4mvukFK1lDMXRymbP6gMs1I/fP3RPD+rWujODUnezml8qgCZEa2hQT9M+pPFFYQlZhg/32/KzIxsmw+SLL4o6dVxaOruhhDIImM+OCP8en/fOYynIvohZn4c6/Id+xOZYm5MSlv/00yir4spOVNyZl5eo690rOjezKKhVK0IBd X-MS-Office365-Filtering-Correlation-Id: ffda2f3e-fe83-4be7-4f5c-08d5b414bc93 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2018 12:19:08.7880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffda2f3e-fe83-4be7-4f5c-08d5b414bc93 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB1249 Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: add free for eth dev port in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 12:19:11 -0000 in case of errors need to free the eth_dev port that was allocated during the port setup. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d34076b..63c94ad 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1064,6 +1064,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, claim_zero(mlx5_glue->dealloc_pd(pd)); if (ctx) claim_zero(mlx5_glue->close_device(ctx)); + if (eth_dev) + rte_eth_dev_release_port(eth_dev); break; } /* -- 2.7.4