DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs
@ 2018-05-08  4:29 Andy Green
  2018-05-08  4:29 ` [dpdk-dev] [PATCH 01/18] lib: ret_table: workaround hash function cast error Andy Green
                   ` (17 more replies)
  0 siblings, 18 replies; 32+ messages in thread
From: Andy Green @ 2018-05-08  4:29 UTC (permalink / raw)
  To: dev

The following series gets current master able to build
on Fedora 28 + x86_64 using gcc 8.0.1.  There were a
number of build-breaking problems, mostly around correct
string processing but all of them reflecting some issue
in the code.

Of the two major issues, one around struct alignment in
dpaa I think is properly fixed by the patch 3/18 here,
but for the apparently broken hash function cast in 1/18
I just stopped it breaking the build; unless I miss the
trick it seems it needs fixing properly after some
further discussion.

Because of the kind of widespread string processing /
off-by-one / buffer overflow issue fixed here, I think it'd
be a really good idea to run this stuff through Coverity.

They will give you a free account for OSS projects here

https://scan.coverity.com/

---

Andy Green (18):
      lib: ret_table: workaround hash function cast error
      drivers: bus: pci: fix strncpy dangerous code
      drivers: bus: dpaa: fix inconsistent struct alignment
      drivers: net: axgbe: fix broken eeprom string comp
      drivers: net: nfp: nfpcore: fix strncpy misuse
      drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use
      drivers: net: nfp: don't memcpy out of source range
      drivers: net: nfp: fix buffer overflow in fw_name
      drivers: net: qede: fix strncpy constant and NUL
      drivers: net: qede: fix broken strncpy
      drivers:net:sfc: fix strncpy length
      drivers: net: sfc: fix another strncpy size and NUL
      drivers: net: vdev: readlink inputs cannot be aliased
      drivers: net: vdev: fix 3 x strncpy misuse
      test-pmd: can't find include
      app: fix sprintf overrun bug
      app: test-bbdev: strcpy ok for allocated string
      app: test-bbdev: strcpy ok for allocated string 2


 app/proc-info/main.c                       |    9 +++++++--
 app/test-bbdev/test_bbdev_vector.c         |    5 +++--
 app/test-pmd/Makefile                      |    1 +
 drivers/bus/dpaa/base/qbman/qman.c         |   14 +++++++-------
 drivers/bus/dpaa/include/fsl_qman.h        |   24 +++++++++++++-----------
 drivers/bus/pci/linux/pci.c                |    3 ++-
 drivers/net/axgbe/axgbe_phy_impl.c         |    4 ++--
 drivers/net/nfp/nfp_net.c                  |    4 ++--
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    3 ++-
 drivers/net/nfp/nfpcore/nfp_resource.c     |    6 +++---
 drivers/net/qede/base/ecore_int.c          |   10 ++++++----
 drivers/net/qede/qede_main.c               |    3 ++-
 drivers/net/sfc/sfc_ethdev.c               |    9 ++++++---
 drivers/net/vdev_netvsc/vdev_netvsc.c      |   16 ++++++++++------
 lib/librte_table/rte_table_hash_cuckoo.c   |    2 +-
 15 files changed, 67 insertions(+), 46 deletions(-)

--

^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2018-05-08 23:33 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08  4:29 [dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs Andy Green
2018-05-08  4:29 ` [dpdk-dev] [PATCH 01/18] lib: ret_table: workaround hash function cast error Andy Green
2018-05-08  4:29 ` [dpdk-dev] [PATCH 02/18] drivers: bus: pci: fix strncpy dangerous code Andy Green
2018-05-08  8:57   ` Bruce Richardson
2018-05-08  4:29 ` [dpdk-dev] [PATCH 03/18] drivers: bus: dpaa: fix inconsistent struct alignment Andy Green
2018-05-08  4:29 ` [dpdk-dev] [PATCH 04/18] drivers: net: axgbe: fix broken eeprom string comp Andy Green
2018-05-08  4:29 ` [dpdk-dev] [PATCH 05/18] drivers: net: nfp: nfpcore: fix strncpy misuse Andy Green
2018-05-08  8:58   ` Bruce Richardson
2018-05-08  9:00     ` Andy Green
2018-05-08  9:03       ` Bruce Richardson
2018-05-08  4:29 ` [dpdk-dev] [PATCH 06/18] drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 07/18] drivers: net: nfp: don't memcpy out of source range Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 08/18] drivers: net: nfp: fix buffer overflow in fw_name Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL Andy Green
2018-05-08 17:59   ` Shaikh, Shahed
2018-05-08 19:53     ` Bruce Richardson
2018-05-08 20:02       ` Shaikh, Shahed
2018-05-08 22:07         ` Andy Green
2018-05-08 23:33           ` Shaikh, Shahed
2018-05-08  4:30 ` [dpdk-dev] [PATCH 10/18] drivers: net: qede: fix broken strncpy Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 11/18] drivers:net:sfc: fix strncpy length Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL Andy Green
2018-05-08  7:36   ` Andrew Rybchenko
2018-05-08  8:18     ` Andy Green
2018-05-08  9:02       ` Bruce Richardson
2018-05-08  9:08       ` Andrew Rybchenko
2018-05-08  4:30 ` [dpdk-dev] [PATCH 13/18] drivers: net: vdev: readlink inputs cannot be aliased Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 14/18] drivers: net: vdev: fix 3 x strncpy misuse Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 15/18] test-pmd: can't find include Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 16/18] app: fix sprintf overrun bug Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 17/18] app: test-bbdev: strcpy ok for allocated string Andy Green
2018-05-08  4:30 ` [dpdk-dev] [PATCH 18/18] app: test-bbdev: strcpy ok for allocated string 2 Andy Green

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git