DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling
@ 2018-05-08  9:11 Raslan Darawsheh
  2018-05-08  9:11 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error Raslan Darawsheh
  2018-05-08 19:08 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling Yongseok Koh
  0 siblings, 2 replies; 6+ messages in thread
From: Raslan Darawsheh @ 2018-05-08  9:11 UTC (permalink / raw)
  To: shahafs; +Cc: dev, thomas, ophirmu, rasland, yskoh, stable

When attr_ctx is NULL it will attempt to free the list of devices twice.
Avoid double freeing the list by directly going to error handling.

Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters")
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

---
v2 changes:
 Better handle for switch statement.
 Reword the commit log.

v3 changes:
 Reword the commit log title.
 add more figures to the Fixes commit
---
---
 drivers/net/mlx5/mlx5.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 5190b9f..3831e3d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -690,18 +690,18 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 		break;
 	}
 	if (attr_ctx == NULL) {
-		mlx5_glue->free_device_list(list);
 		switch (err) {
 		case 0:
 			DRV_LOG(ERR,
 				"cannot access device, is mlx5_ib loaded?");
 			err = ENODEV;
-			goto error;
+			break;
 		case EINVAL:
 			DRV_LOG(ERR,
 				"cannot use device, are drivers up to date?");
-			goto error;
+			break;
 		}
+		goto error;
 	}
 	ibv_dev = list[i];
 	DRV_LOG(DEBUG, "device opened");
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-09  9:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08  9:11 [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling Raslan Darawsheh
2018-05-08  9:11 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error Raslan Darawsheh
2018-05-08 19:19   ` Yongseok Koh
2018-05-09  9:50     ` Shahaf Shuler
2018-05-08 19:08 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling Yongseok Koh
2018-05-09  9:51   ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).