From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A20201B1D6; Wed, 9 May 2018 14:32:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 05:32:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,381,1520924400"; d="scan'208";a="49477366" Received: from dpdk6.bj.intel.com ([172.16.182.201]) by orsmga003.jf.intel.com with ESMTP; 09 May 2018 05:32:43 -0700 From: Wei Dai To: thomas@monjalon.net, ferruh.yigit@intel.com Cc: dev@dpdk.org, Wei Dai , stable@dpdk.org Date: Wed, 9 May 2018 20:32:06 +0800 Message-Id: <1525869126-51223-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1517484102-43836-1-git-send-email-wei.dai@intel.com> References: <1517484102-43836-1-git-send-email-wei.dai@intel.com> Subject: [dpdk-dev] [PATCH v2] ethdev: fix comments for offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:32:47 -0000 Indeed, rx_offload_capa or tx_offload_capa in struct rte_eth_dev_info includes not only per port offloading features but also per queue ones. This patch make its meaning much clearer. Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") Fixes: cba7f53b717d ("ethdev: introduce Tx queue offloads API") Cc: stable@dpdk.org Signed-off-by: Wei Dai --- v2: fix coding style issues --- lib/librte_ethdev/rte_ethdev.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4ba..98e3114 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -1067,9 +1067,13 @@ struct rte_eth_dev_info { uint16_t max_vfs; /**< Maximum number of VFs. */ uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */ uint64_t rx_offload_capa; - /**< Device per port RX offload capabilities. */ + /**< Rx offload capabilities including all per port ones + * and all per queue ones. + */ uint64_t tx_offload_capa; - /**< Device per port TX offload capabilities. */ + /**< Tx offload capabilities including all per port ones + * and all per queue ones. + */ uint64_t rx_queue_offload_capa; /**< Device per queue RX offload capabilities. */ uint64_t tx_queue_offload_capa; -- 2.7.5