From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0075.outbound.protection.outlook.com [104.47.0.75]) by dpdk.org (Postfix) with ESMTP id C62401B627 for ; Wed, 9 May 2018 15:46:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=l6X26dFQtggaa9QJr/zNjQ5zNSUDrj1f7MVe/tQ3Oxo=; b=IITOc5puXxkFV+rqc4RlCgdHbFFOlw/KzDGgJedLVZEPtYdCTog4qVs0032WTWdB76/M3MQoYBTfPPPPRsvQ8eM96y+fRDKmcS8by85yk9DpMJMdGXprERSKxwmZ27J3kBI1jjcinV0C0OLt4pPNh69wjNFoFnp61sNwctMMeoY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 13:46:52 +0000 From: Ophir Munk To: dev@dpdk.org, Gaetan Rivet Cc: Thomas Monjalon , Olga Shern , Ophir Munk , Shahaf Shuler Date: Wed, 9 May 2018 13:46:41 +0000 Message-Id: <1525873601-24453-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1525802561-9011-1-git-send-email-ophirmu@mellanox.com> References: <1525802561-9011-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0701CA0055.eurprd07.prod.outlook.com (2603:10a6:800:5f::17) To HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2314; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 3:lyXpspC+odPaRFAUQvjsn30t2R8aVnWp6bvfYBqWLpz4Nwe89xDGzMuTStZ4BKZAtpQbuc8ypquWcOf6RToOsT468bB2Saiehf7Phe5Cz7JzHsgO6fusHnu4qFlenHTf4Jny9yC4E1Bq/U1eqvEWPLYNXwMPv6hnixycuVHNfJuRFm7zUNqsjCkajuBDKx9z61AHVY4mQLaLH7FfKcNPyE68h5ZG6cZfFTUzXsYRlJPq9M2M+qid5iHuFIiMfyuB; 25:08nhULL+JX2ickkRiS9UkQd+0pt+jNEg7f1SXO9EQvoO/d8kZm+822KYC0EjfOkkLc2ygTe1Jjuew9lplsXFRjMidjrAV6LtjzVgIiIbA5rRKkc9DjO3MwW9IU/T8c0d6jUbnybzUBrOfNiGTTGiNJ5dKae9rDHO+G6GWL/MGU0ksw3QuFTidC/X60psWMKSZ0bgLG2/xv4KGIGCkgxKNKjQozz/UE5VctMrdhPYSd2h+02P9/s+vQOiPEcv1zNzIpDk4ctPs6RIA06eGjsme9WIZ2NvmJPBKgmcP1AjDhvZ6ADiF3yjX+azfE4ewXUXeR4rUmGR3rR3G1M4/h3RLQ==; 31:tr4dZWuNYiElioge60qAvXKnHb3CNqs+rFvMPJrGt+/LE3aAFqidlg9qik9GJgNlMCY2wjWumkoLkXgu6FhDL4Yp1wG+Jlz2Bi0Yf8Lwl6aPv7WEL75W+shIJlu+cmMEYZv0sME1pLY5ztl3eYGrpxaORd4vRcN3VnjqZsFjn0tPP43UP9yCOdEMrEpe+yP79gVrtRXgZ4shQy6veLdeuEQkpRJPUxfBL8//wvgqK3w= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2314: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 20:YLnQBeABVPM4H5DTbGPm0IXHv0TEA8xWrU+FqJMgXfEUPCMYJr7sCienX01Q28LLZpPF9d0nxH7FKKVyvnPb2xRItN6H8WH32SYzJiVvsAGtrQ8BOxkqCuuHnwVdFOUN/GlRegam1/+5nXMGu0KXv+p1mTReQuXbtjSTv8V3rz4ts9pE3ZrXEqrgW0Bs8Bi5X86AOWOvJJZ85Qd57H6hmZ40oFEZ2A4B6udDap3xmrI2WTXDznkg593//OyOl/3ggpHJg9LkixxtcoCxiQi0SW/GUKeON7mUQ1M3PftC3OfPBs33xxBkQNFBuvi9pB/kiWUCV7wmcoqpBpZrHuVxt3UnIwQej+0e+5JCmP31CT6SbnDZTBRizH1VuwM+UR7A17fjMBsSncum4gWvr2AtmpcpCV4NWiwn+Soye9p6kmwLvZIway9NzgDPhLF3x6MJNgIi1aGBQs7bO4Crn4tPBrQFVKEnsSoPpppt1XZXAVD5ILWycNoLDYWY4fhrnqWy; 4:1awud5cO+pKj6pgoKjiOB7X03LcRo7af1Z/+I/Kno0SY17RtyxyV0Iq3StXj12sVFnf2fQuQVdMYfjWuhYTlWDA+/spWAzs8qDtkCtN2VZYHL2wEGcuD81DWVaMGkzOeV0hMz12LsZFkYiBDyUfPCRHN1OisBNhrUKB9pYB+BE7IJDkd960VwHxZ42wTTJizyIBtqCYan8l1x820furjYvnGf8otyjAcS52Ykh8B7iZErZwjRXHC7fULOkrClp8FD3NviTLPuZbXs5ZUBKzCkQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0501MB2314; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2314; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(376002)(366004)(39860400002)(189003)(199004)(52116002)(5660300001)(446003)(50466002)(48376002)(11346002)(7736002)(106356001)(956004)(476003)(66066001)(97736004)(59450400001)(2616005)(47776003)(36756003)(69596002)(486006)(16526019)(478600001)(305945005)(105586002)(26005)(76176011)(51416003)(186003)(386003)(7696005)(3846002)(33026002)(6116002)(25786009)(6666003)(8676002)(50226002)(8936002)(54906003)(4720700003)(2906002)(81156014)(55016002)(53936002)(81166006)(316002)(16586007)(4326008)(68736007)(21086003)(107886003)(6916009)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2314; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:3; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2314; 23:6Z7IRHpHO1W2q65dCE2dR5qru7E+JYGVsKJh9z1?= =?us-ascii?Q?nLLuKhFvcOKSgmCU5d72hmsnYSJIuDzlGZ2joRMOXF1hvMbGob/S6urMd1Qw?= =?us-ascii?Q?mLTwKbcuIzEh6i6UGxudIRrsK/cSD97rtdqLWXJeIXX1yZBhnM0dT9z16tG9?= =?us-ascii?Q?1z2fuB2gt5ZHwySc/ga53ItfKbXqhwvYKKd45YY9B4IViH0GApZC98p4H/ql?= =?us-ascii?Q?evRlmV6x22XAx/Emy2mwzS/iMbBUaaj7APf5TkcGC/mqavYzLXUVBjR79CmT?= =?us-ascii?Q?bXWuTKN0h5yByxnEU6UW409EXo8ZCSX2xry0uWr4xrKf5aP3tvQttfiQ2JYD?= =?us-ascii?Q?7pXczgBdeMGaL3mB9c4zj/qqMhxdZqoQyV4KIXzgCrvX12B2MwQU1NL2ZVQm?= =?us-ascii?Q?50m4RznQFDImBTCYekINl0VTRwNJitd4+cGA9TT+rn7+z2shV2T2MPPuydkI?= =?us-ascii?Q?nQaPUjL9h8vwBWTZO+Eg0LG+AlwsbB6tOjF1xU9nfPLFwuTrSYBp6rPGDDTr?= =?us-ascii?Q?R54PeFjY+dFvsewo6CFi38l1l9i5uZzY9m0XXrVawYfzoVr+IaSh5eZbrMgD?= =?us-ascii?Q?dAxn54Lr+0aiqNtQss0ggI9MXNDzPDE7z7LYMXCHk3ofVCRqPnw7XEVB7+IU?= =?us-ascii?Q?96O03RU/di64q6uSZF3OtSMznh0zJvsqy3xhuHO+Ep45rMNQs3kdmJMJcbQB?= =?us-ascii?Q?jgsnIuwd0eXdoA38EoOeU7fRcq7KjUsN1GpAPslv55JjnHKEaaXPq1l67pop?= =?us-ascii?Q?nLWbaYBOu00j4kL3gtqqW4/3qYVc506UJdzQ/FdXi21b0QF7fvqfyB4+gpmN?= =?us-ascii?Q?tlAtpS8+anZY5sXfTjYpBxE2rA8CClY1tAFAalA6/PmYSP4trIFpyP3FCZ2v?= =?us-ascii?Q?7AKNOQOZ/4NoDdeiniBkU8wKgwbk0SfUIi0XWoA/A7X2bPGilLsoDMMw+g3J?= =?us-ascii?Q?UPmUqL7WJr/ash/WXd3XTS87yD/jXYBs4QkCGysLgUPKqlAHQVWVBQiUTZIm?= =?us-ascii?Q?nD2mwKe5MPJCH7wF8MvBnETQpQRyYhMlg9iBquCEBXHg+ssQlKOnFZ3YFezi?= =?us-ascii?Q?+2tPrWSYyWQ/Uvyq2+7cA2fxagfZMcnNwb/URDI9YMFxwe+xAqvdOQS3ZXo+?= =?us-ascii?Q?qP4yfKvBR+T/ECXNWmwkoYLMXYGS3PvM1IeOA6wiPzZrDnC2kkfElfd2ESpQ?= =?us-ascii?Q?WtuIsvmjYICYOoO0pa8YRsZ4AdE4wHv61WzEatmLGawlGQvxXfAzII16qV8S?= =?us-ascii?Q?hpYm8XTnkUDR30jO59wMoOStYwESsl0hjPl6Of6GdlehWvXWGs7K9JrR6wW9?= =?us-ascii?Q?dw7KdaVEY8uDzzoJMX/LLnU0=3D?= X-Microsoft-Antispam-Message-Info: wEggeW9WtmP8mEsVnqe1/x8AIuVFkFbAz6njZv1Rkl7Ko3CrLPaB+Z6HvL7ktUKloBuzTnj9Rem68dzT5IuPycZHqScr0oMokMCkGAai5rBPETTOnNylK7Hg2arJODfPtdYhl8NUTKSfEl0+F+YofsRCKlqXlMLkUSEeuSgd3uukVvsrB77rfZCM8bh8j+K/ X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 6:s3ayNTcrH+qk4I+aqmVRNtOLPUm3BvdW+JeRg5P2HRhCVK9wKTe8/qmfz61wigWEy9XKiai4W9/ZOJ9MOg0aLfRATRkehQOF/tuvU3vJGcbeeyV8LnGkKJ75POaBvmDVBouNM4vNnALe4K2hLMGlxOHHO3XdQbF1c/+nMAxnRpa2gFb2GC7lySaGwicuxvnkWCt9kghSQAzFToSdun2CnwMYnT5ytrKHIbNn4oWLf1b54L8vUubAe69nKoVR6EiHfxkg388pkWaYaoKBT4LcNmdGUIBXyfmdPYQ6+0Taanhjz1ehnXI6+1UsyKfOaAWCxUv7SbZh6lnxpAeQmOKc5m7WH0RFcWmDBLKxt8rpCoT2OBInrF/TArr3x84pqgKjyyY+nqFmiaeq6oY0BqQns0p4+nS51j0ND/QVaZ6c6G7RRkIKeYZp+Cy6NzhYhdCQOkUxR5TyR+cRSzC6hH/Sog==; 5:Cb5x4g8c0RX8NdP4QTDnbdAnW6RH+sspEGIPx1+zTseBR+OP2/EWlogWlAfq6v3FwkMSkhIqmbUzvOqgxZcivzN6s65HmLVkiYBwzMs7+hhrtKGiuLSpv66fBPXJXU08Rq7kmrel5z1fTWDFCPY6HlFAzmk9MgJ2ws1D3Iyj4YE=; 24:ZhMfc9ygnoN87wFnD75pJZ9jIh4s8U9Z5MX4gXC+KqM78O9rSKE8DKhHJMVVzw4r6Kq8lUobQqR/XN5M+Hn24lpp8iCgouThX+epik6yA48= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 7:gNubuRPXMdRirvcP6LPtRbE44Bk21xN/iYoqzaKJRNdFxNzrUAcR4Z4IGMjDyCTsogRISq5KWw+b/w1iHdYcwIlVddBSE3nXuFNnRjQIR4kAfjGvBNHnZKpBn88CCVKwrygh8KSrkxmoB1VAY100NTXVAtu9wamC/0pBekHfcfsJLw6VLEyFMK/7wCz96bklUNdspJ43HpLTrHsfaryiGIpdTZIQ5PPC4HSaTzb/fpWm5QSGkbMrJ1trM+IAvlZk X-MS-Office365-Filtering-Correlation-Id: 16622455-d199-4cc1-c1a8-08d5b5b352fd X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 13:46:52.6897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16622455-d199-4cc1-c1a8-08d5b5b352fd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2314 Subject: [dpdk-dev] [PATCH v2] net/failsafe: advertise supported RSS functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 13:46:57 -0000 Advertise failsafe supported RSS functions as part of dev_infos_get callback. Set failsafe default RSS hash functions to be: ETH_RSS_IP, ETH_RSS_UDP, and ETH_RSS_TCP. The result of failsafe RSS hash functions is the logical AND of the RSS hash functions among all failsafe sub_devices and failsafe own defaults. Previous to this commit RSS support was reported as none. Since the introduction of [1] it is required that all RSS configurations be verified. [1] commit 8863a1fbfc66 ("ethdev: add supported hash function check") Signed-off-by: Ophir Munk --- v1: Initial release v2: Changes based on review comments (mainly commit message update) drivers/net/failsafe/failsafe_ops.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 6d44884..6f85a63 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -83,7 +83,10 @@ static struct rte_eth_dev_info default_infos = { DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_TCP_TSO, - .flow_type_rss_offloads = 0x0, + .flow_type_rss_offloads = + ETH_RSS_IP | + ETH_RSS_UDP | + ETH_RSS_TCP, }; static int @@ -805,26 +808,29 @@ fs_dev_infos_get(struct rte_eth_dev *dev, } else { uint64_t rx_offload_capa; uint64_t rxq_offload_capa; + uint64_t rss_hf_offload_capa; rx_offload_capa = default_infos.rx_offload_capa; rxq_offload_capa = default_infos.rx_queue_offload_capa; + rss_hf_offload_capa = default_infos.flow_type_rss_offloads; FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); rx_offload_capa &= PRIV(dev)->infos.rx_offload_capa; rxq_offload_capa &= PRIV(dev)->infos.rx_queue_offload_capa; + rss_hf_offload_capa &= + PRIV(dev)->infos.flow_type_rss_offloads; } sdev = TX_SUBDEV(dev); rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); PRIV(dev)->infos.rx_offload_capa = rx_offload_capa; PRIV(dev)->infos.rx_queue_offload_capa = rxq_offload_capa; + PRIV(dev)->infos.flow_type_rss_offloads = rss_hf_offload_capa; PRIV(dev)->infos.tx_offload_capa &= default_infos.tx_offload_capa; PRIV(dev)->infos.tx_queue_offload_capa &= default_infos.tx_queue_offload_capa; - PRIV(dev)->infos.flow_type_rss_offloads &= - default_infos.flow_type_rss_offloads; } rte_memcpy(infos, &PRIV(dev)->infos, sizeof(*infos)); } -- 2.7.4