* [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping
@ 2018-05-03 3:08 Jingjing Wu
2018-05-03 3:08 ` Jingjing Wu
0 siblings, 1 reply; 6+ messages in thread
From: Jingjing Wu @ 2018-05-03 3:08 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev, stable
Vector used for rx mapping is different if WB_ON_ITR
is supported. The mapping table need to be updated.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Cc: stable@dpdk.org
---
drivers/net/avf/avf_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a1ae3a2..db0eda4 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
AVF_WRITE_FLUSH(hw);
/* map all queues to the same interrupt */
for (i = 0; i < dev->data->nb_rx_queues; i++)
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
} else {
if (!rte_intr_allow_others(intr_handle)) {
vf->nb_msix = 1;
vf->msix_base = AVF_MISC_VEC_ID;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
}
PMD_DRV_LOG(DEBUG,
--
2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping
2018-05-03 3:08 [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping Jingjing Wu
@ 2018-05-03 3:08 ` Jingjing Wu
2018-05-09 5:24 ` Lu, Wenzhuo
2018-05-11 15:09 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
0 siblings, 2 replies; 6+ messages in thread
From: Jingjing Wu @ 2018-05-03 3:08 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev, stable
Vector used for rx mapping is different if WB_ON_ITR
is supported. The mapping table need to be updated.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Cc: stable@dpdk.org
---
drivers/net/avf/avf_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a1ae3a2..db0eda4 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
AVF_WRITE_FLUSH(hw);
/* map all queues to the same interrupt */
for (i = 0; i < dev->data->nb_rx_queues; i++)
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
} else {
if (!rte_intr_allow_others(intr_handle)) {
vf->nb_msix = 1;
vf->msix_base = AVF_MISC_VEC_ID;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
}
PMD_DRV_LOG(DEBUG,
--
2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping
2018-05-03 3:08 ` Jingjing Wu
@ 2018-05-09 5:24 ` Lu, Wenzhuo
2018-05-11 15:09 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
1 sibling, 0 replies; 6+ messages in thread
From: Lu, Wenzhuo @ 2018-05-09 5:24 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: dev, stable
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, May 3, 2018 11:09 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/avf: fix Rx interrupt mapping
>
> Vector used for rx mapping is different if WB_ON_ITR is supported. The
> mapping table need to be updated.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Cc: stable@dpdk.org
> ---
> drivers/net/avf/avf_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index
> a1ae3a2..db0eda4 100644
> --- a/drivers/net/avf/avf_ethdev.c
> +++ b/drivers/net/avf/avf_ethdev.c
> @@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
> AVF_WRITE_FLUSH(hw);
> /* map all queues to the same interrupt */
> for (i = 0; i < dev->data->nb_rx_queues; i++)
> - vf->rxq_map[0] |= 1 << i;
> + vf->rxq_map[vf->msix_base] |= 1 << i;
> } else {
> if (!rte_intr_allow_others(intr_handle)) {
> vf->nb_msix = 1;
> vf->msix_base = AVF_MISC_VEC_ID;
> for (i = 0; i < dev->data->nb_rx_queues; i++) {
> - vf->rxq_map[0] |= 1 << i;
> + vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
Looks better using " vf->msix_base" here too.
> intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
> }
> PMD_DRV_LOG(DEBUG,
Better updating the debug log either.
> --
> 2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] net/avf: fix Rx interrupt mapping
2018-05-03 3:08 ` Jingjing Wu
2018-05-09 5:24 ` Lu, Wenzhuo
@ 2018-05-11 15:09 ` Jingjing Wu
2018-05-11 15:09 ` Jingjing Wu
1 sibling, 1 reply; 6+ messages in thread
From: Jingjing Wu @ 2018-05-11 15:09 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev, stable
Vector used for rx mapping is different if WB_ON_ITR
is supported. The mapping table need to be updated.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Cc: stable@dpdk.org
---
v2 change:
- replace vector 0 constant by msix_base
drivers/net/avf/avf_ethdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a1ae3a2..0ef1f17 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -339,17 +339,18 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
AVF_WRITE_FLUSH(hw);
/* map all queues to the same interrupt */
for (i = 0; i < dev->data->nb_rx_queues; i++)
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
} else {
if (!rte_intr_allow_others(intr_handle)) {
vf->nb_msix = 1;
vf->msix_base = AVF_MISC_VEC_ID;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
}
PMD_DRV_LOG(DEBUG,
- "vector 0 are mapping to all Rx queues");
+ "vector %u are mapping to all Rx queues",
+ vf->msix_base);
} else {
/* If Rx interrupt is reuquired, and we can use
* multi interrupts, then the vec is from 1
--
2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] net/avf: fix Rx interrupt mapping
2018-05-11 15:09 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
@ 2018-05-11 15:09 ` Jingjing Wu
2018-05-14 12:34 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Jingjing Wu @ 2018-05-11 15:09 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev, stable
Vector used for rx mapping is different if WB_ON_ITR
is supported. The mapping table need to be updated.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Cc: stable@dpdk.org
---
v2 change:
- replace vector 0 constant by msix_base
drivers/net/avf/avf_ethdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a1ae3a2..0ef1f17 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -339,17 +339,18 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
AVF_WRITE_FLUSH(hw);
/* map all queues to the same interrupt */
for (i = 0; i < dev->data->nb_rx_queues; i++)
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
} else {
if (!rte_intr_allow_others(intr_handle)) {
vf->nb_msix = 1;
vf->msix_base = AVF_MISC_VEC_ID;
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- vf->rxq_map[0] |= 1 << i;
+ vf->rxq_map[vf->msix_base] |= 1 << i;
intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
}
PMD_DRV_LOG(DEBUG,
- "vector 0 are mapping to all Rx queues");
+ "vector %u are mapping to all Rx queues",
+ vf->msix_base);
} else {
/* If Rx interrupt is reuquired, and we can use
* multi interrupts, then the vec is from 1
--
2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/avf: fix Rx interrupt mapping
2018-05-11 15:09 ` Jingjing Wu
@ 2018-05-14 12:34 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-05-14 12:34 UTC (permalink / raw)
To: Jingjing Wu, wenzhuo.lu; +Cc: dev, stable
On 5/11/2018 4:09 PM, Jingjing Wu wrote:
> Vector used for rx mapping is different if WB_ON_ITR
> is supported. The mapping table need to be updated.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-14 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 3:08 [dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping Jingjing Wu
2018-05-03 3:08 ` Jingjing Wu
2018-05-09 5:24 ` Lu, Wenzhuo
2018-05-11 15:09 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
2018-05-11 15:09 ` Jingjing Wu
2018-05-14 12:34 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).