[dpdk-dev] [PATCH] net/tap: add default name to tun

[dpdk-dev] [PATCH] net/tap: add default name to tun

[Vipin Varghese]

The change adds default name to reflect TUN PMD instance. if option
name is not passed, the default dtun is taken.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 172a7ba..fa59a76 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
 	params = rte_vdev_device_args(dev);
 	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
 
+	snprintf(tun_name, sizeof(tun_name), "%s%d",
+		 DEFAULT_TUN_NAME, tun_unit++);
+
 	if (params && (params[0] != '\0')) {
 		TAP_LOG(DEBUG, "parameters (%s)", params);
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/tap: add default name to tun

[Stephen Hemminger]

On Fri, 11 May 2018 14:11:59 +0530
Vipin Varghese <vipin.varghese@intel.com> wrote:

> The change adds default name to reflect TUN PMD instance. if option
> name is not passed, the default dtun is taken.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 172a7ba..fa59a76 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
>  	params = rte_vdev_device_args(dev);
>  	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
>  
> +	snprintf(tun_name, sizeof(tun_name), "%s%d",
> +		 DEFAULT_TUN_NAME, tun_unit++);

Use unsigned to avoid integer wraparound?

[dpdk-dev] [PATCH v2] net/tap: add default name to tun

[Vipin Varghese]

The change adds default name to reflect TUN PMD instance. if option
name is not passed, the default dtun is taken.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---

Changes in V2:
unsigned instead of signed for dev_index - Stephen Hemminger
---
 drivers/net/tap/rte_eth_tap.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 172a7ba..48c61b3 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -65,7 +65,7 @@ static const char *valid_arguments[] = {
 };
 
 static int tap_unit;
-static int tun_unit;
+static unsigned int tun_unit;
 
 static int tap_type;
 static char tuntap_name[8];
@@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
 	params = rte_vdev_device_args(dev);
 	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
 
+	snprintf(tun_name, sizeof(tun_name), "%s%u",
+		 DEFAULT_TUN_NAME, tun_unit++);
+
 	if (params && (params[0] != '\0')) {
 		TAP_LOG(DEBUG, "parameters (%s)", params);
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/tap: add default name to tun

[Varghese, Vipin]

Thanks Stephen, for pointing this out. I have shared a V2 for the same.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, May 11, 2018 8:55 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Wang, Zhihong
> <zhihong.wang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/tap: add default name to tun
> 
> On Fri, 11 May 2018 14:11:59 +0530
> Vipin Varghese <vipin.varghese@intel.com> wrote:
> 
> > The change adds default name to reflect TUN PMD instance. if option
> > name is not passed, the default dtun is taken.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> >  drivers/net/tap/rte_eth_tap.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/tap/rte_eth_tap.c
> > b/drivers/net/tap/rte_eth_tap.c index 172a7ba..fa59a76 100644
> > --- a/drivers/net/tap/rte_eth_tap.c
> > +++ b/drivers/net/tap/rte_eth_tap.c
> > @@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
> >  	params = rte_vdev_device_args(dev);
> >  	memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
> >
> > +	snprintf(tun_name, sizeof(tun_name), "%s%d",
> > +		 DEFAULT_TUN_NAME, tun_unit++);
> 
> Use unsigned to avoid integer wraparound?

Re: [dpdk-dev] [PATCH v2] net/tap: add default name to tun

[Ferruh Yigit]

On 5/12/2018 7:21 AM, Vipin Varghese wrote:
> The change adds default name to reflect TUN PMD instance. if option
> name is not passed, the default dtun is taken.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v2] net/tap: add default name to tun

[Ferruh Yigit]

On 5/14/2018 5:01 PM, Ferruh Yigit wrote:
> On 5/12/2018 7:21 AM, Vipin Varghese wrote:
>> The change adds default name to reflect TUN PMD instance. if option
>> name is not passed, the default dtun is taken.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.