DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] rte_eal_version_map: export rte-strlcpy
Date: Sun, 13 May 2018 09:35:17 +0800	[thread overview]
Message-ID: <152617531727.68145.12744668569801299577.stgit@localhost.localdomain> (raw)

Building dpdk as a shared library on systems without their own
native strlcpy (eg, glibc) fails, because we do not allow the
explicit export of the helper rte_strlcpy().

It used to be an inline, but it's now a function.  Building
static, there's no problem but configured to build shared, the
users of rte_strlcpy() cannot bind to the definition in
librte_eal even though they give the library on their linker
line, because it's not listed to be exported.

This must also be applied if
 lib/librte_eal: import libbsd strlcpy
is applied to allow shared build.

BTW this is a clear instance where nothing else will do but
use the api name on the commit title...

Signed-off-by: Andy Green <andy@warmcat.com>
---
 lib/librte_eal/rte_eal_version.map |    1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 859723974..9d5b67903 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -241,6 +241,7 @@ DPDK_18.05 {
 	rte_service_set_runstate_mapped_check;
 	rte_service_set_stats_enable;
 	rte_service_start_with_defaults;
+	rte_strlcpy;
 
 } DPDK_18.02;
 

                 reply	other threads:[~2018-05-13  1:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152617531727.68145.12744668569801299577.stgit@localhost.localdomain \
    --to=andy@warmcat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).