From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 182012C8 for ; Mon, 14 May 2018 09:36:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id D42C8940058; Mon, 14 May 2018 07:36:49 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 14 May 2018 00:36:47 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Mon, 14 May 2018 00:36:46 -0700 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w4E7ajV8012989; Mon, 14 May 2018 08:36:45 +0100 Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w4E7aj7p030550; Mon, 14 May 2018 08:36:45 +0100 From: Andrew Rybchenko To: CC: Ferruh Yigit , Thomas Monjalon , Shahaf Shuler , Wei Dai Date: Mon, 14 May 2018 08:36:15 +0100 Message-ID: <1526283378-30507-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1526055955-14027-1-git-send-email-arybchenko@solarflare.com> References: <1526055955-14027-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-MDID: 1526283410-FSaoAuyRNSsP Subject: [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested offload is not supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 07:36:51 -0000 The series has fixes for problems discussed in [1]. Basically it does not allow unsupported offloads to pass. If fixes regressions for PMDs which carefully check offloads before, but these checks are removed now in favor of checks in ethdev. It may break applications which request some offload which is not supported by underlying PMD, but does not actually used. Depending on discussion results it should be either dropped or applied. [1] http://dpdk.org/ml/archives/dev/2018-May/101261.html v1 -> v2: - use IGNORE flag to separate old and new offload API cases on Tx queue setup and avoid expected errors if old API is used as suggested by Shahaf - remove convertion of rxmode bits on Rx queue setup since exactly these bits are removed Andrew Rybchenko (3): ethdev: fail configure if requested offload is not supported ethdev: fail if Tx queue offload is not supported ethdev: fail if Rx queue offload is not supported lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++--------------- 1 file changed, 35 insertions(+), 27 deletions(-) -- 2.17.0