From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0066.outbound.protection.outlook.com [104.47.1.66]) by dpdk.org (Postfix) with ESMTP id 5C0AC1CC9C; Tue, 15 May 2018 00:12:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ka6383YqGwxGFDmCArNpnDi8D8/IZwlkf2N37DRYZkg=; b=Mvk2u1EQsS5SiUtRU4LbdD4nLkekE0hmuHxUUmmpeoTxMy0IVQO4hJsDdeTHy6qU0e3ITuPAIBd3MbYn6tGHG0cC/pIUcc1jSjEziFtXTUjs48GSDZwq9SyOn+Cw0kgtYEnw+KfcBXf6fmnuh1budmjJ2BPBDY1DEtEVTCNge50= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0501MB2319.eurprd05.prod.outlook.com (2603:10a6:800:2c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 22:12:07 +0000 From: Ophir Munk To: dev@dpdk.org, Pascal Mazon , Keith Wiles Cc: Thomas Monjalon , Olga Shern , Ophir Munk , Shahaf Shuler , stable@dpdk.org Date: Mon, 14 May 2018 22:11:55 +0000 Message-Id: <1526335915-27693-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1525682200-21821-1-git-send-email-ophirmu@mellanox.com> References: <1525682200-21821-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0178.eurprd08.prod.outlook.com (2603:10a6:800:d1::32) To VI1PR0501MB2319.eurprd05.prod.outlook.com (2603:10a6:800:2c::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2319; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2319; 3:Kvq2vzuYpLQ3qTOMp7ELpGbFnZUGyMTZN5RNMu8b4rt/+o0eRKTOmnsMs9swj39Mf4xbJ28HObcFQRdd7iQuRY7ZF723Xjnt6TDuTSbA5a06HvHNeR+5VOhBID3/C81b9tI0mrZ1ow1NFwF60S84gAVfxZpsARo8nAQFIfVtXqCZ1C2/TH/bNaVdIR/WSaKqtQqVAlEHOliD/WgUr55VKOpfPPVEMfnjYWsuZZspAqwVyQ8andWcEEI8YFd0yvNt; 25:jThQSftEqJPpuLDCbnFyDtXQu75weDMQil39E7o1RC1AQV7D6cpJBUy1ilR6KRJ7wVdD2zLevwWw5xV549UEiMToKaFRZMrUZHomLgh59D9JrL+EHQbkgwS35ehW9BwPOZpGVirD/7IJThRldta+8Sgji7lxBpVDMDeDSHvK2aOJ4wd6KdBETDmk7gyrBXEDh36Vx0Tok0svqYUoxCC9B0ct7O8XBfAyKPl+o9cwJqa6CVVw+VMWN/+39MEvXj/XMk5CcSwWdiUvjtPyG/VjGv9ob6XW07yOHVUrPX21D6qNT7dtcFAGy4baPzhIxolpFT0P/eXghBMAzLqFy/+DoA==; 31:qo7EY2uBcX8LdASNQmtLpLmfC8ftJQ+jHYW4BZhwRTi6n2fxDrkMvWnMj4uqtMSOrq9u1FuuGjmb5sWOD/in+PdqrbFGXrKNVKnFUQ0DBm22VsQmsYzWy6mFt781iWHDs5vyohXafnq1DbIxs91Xr6IMs/gbeFMnmBgfq3kHkSKHICl4a3NoWpL9MrdNQVmaArS8ExP6I9o+J42gRUIxE0BMGntkEH4DvpOm/jV1rOw= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2319: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2319; 20:D12hW3k9fp8S2zFfsEDyzkW/AU+MEChN7Yln0Mt3cWb1yrQeF13HAbsANXSYlts04WCVvwMtYABA4VLr0QOrISL5Q017vVfRp4JaCa/I/Vs48xd2BltL6gor4iOtzK9bQCnxY8arwX3vIpwKTHbNkyw0bIv8mMR1dJI2qi8rvG3H/GyEAMJSYKxzZqDhiJAzFw+3Y/u/uqxg0PkER3lLEYSAur7jZpxuxTA3wVQ7XpOyFtV0ZHuKgVFGY33sT8c5T5aaJ5Pp/hZ4+RLUA/xUlUCIvORyAFyTF4yYDjmYd6VgRcsZGE1cE7qMzXHJR8e3zD4FXA/1XC4cq3GWTFSgNtJ8w09wnE8ORrUZF9fldhS4ZdD0noWnHqNd80rxGup4nef4cmaKxJGep5gEt22Ts9Ub1Mo50mCk5jDcxeMU/4qme2btHrMn5pVeqCct2bgOkzk1EVImYHFBZGJsdjd1lMehWmrjHzzAMLF8E8ispt3Prt96LcbDw/knOPbLOnl4; 4:4H5f06jT4+hwxbHAVYjsuiSsEHjFbkfgtbcskHpFrbsjJad5GALtUEkJLMkpM5mizEuYD2KAkWMQYfzOCB+mWIEJvIrCatwcCjKZPWAP2ddU9K2+e0YbafsFgsogR7tkFbHvwPFqPuvibWxC7DU+j64O70DmJJ+BFF93PD6AkUJm8SPqbKgz+1l+nseuNQq9Uv52RqK1hBE5B2NhfcWfc0bWJ9GRWM1glze30ZlrNbP43/+V9B6rmb99JHy7tmdjytazU8UEbO/4iAl9xIWGvQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB2319; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2319; X-Forefront-PRVS: 067270ECAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(39380400002)(39860400002)(376002)(199004)(189003)(25786009)(305945005)(486006)(97736004)(66066001)(36756003)(4326008)(33026002)(47776003)(53936002)(476003)(478600001)(2906002)(316002)(446003)(2616005)(956004)(11346002)(16586007)(55016002)(110136005)(54906003)(68736007)(21086003)(86362001)(8936002)(8676002)(26005)(81156014)(106356001)(81166006)(50466002)(6116002)(3846002)(69596002)(48376002)(51416003)(76176011)(5660300001)(7736002)(386003)(50226002)(52116002)(4720700003)(6666003)(105586002)(7696005)(186003)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2319; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2319; 23:wNtbWZTfRvyTIR7vuFGwN0c3EgmX+pH5NefnmYJ?= =?us-ascii?Q?SOwl+aKNw0k4GZNV58DBxZO8tEsbH4G9FVpn4SoK7PXM0EHV3BnXzm8gCyom?= =?us-ascii?Q?3sqKpIwmaymgw5MIRyf8NIGRiOxMe6/cAZRxrPkoopoCgtZXBhZPHrKtqeQB?= =?us-ascii?Q?KoB9fC1DMp9i7dYr7DE4E2/m+vvCkVqKqUb859BKl2ky0vQcuFccnUghDYx2?= =?us-ascii?Q?C0HGgC+lQ25dIPElloJ0T1s1Oi0ZFm5xcojEDwxP7785gcMDal8VxYoK2lxy?= =?us-ascii?Q?BvJptqHrV3mnCKG3ZU1047tH/jsWBpNCBtl0mD2uiq+D8lbtac2fym11Qgq2?= =?us-ascii?Q?DzOQYMwFpI5y4ajWSlHm1Xx42RUBzXXPrcxzpYNbB3XGLeD+eP9h6Ww6AHDY?= =?us-ascii?Q?vel7zYW5pPYucCV0qVncI9GJtpY1lIpCt/a3ZUKBwYx30cOvL3Jxg/0swSOl?= =?us-ascii?Q?ioEKl6cU4HGBBb6jhK5fE6mKFtM54BLIE6Nn1ZaYELIPm41Oi7H3monlbGdI?= =?us-ascii?Q?OoIrMom3Cn6GuWkAP6kHAd2lSIzGHAcXv1DrBcY9wj9XC7a/YiErqf4gpT2d?= =?us-ascii?Q?wNRFHwV6rJMA/u2aktZc4Us851mQSsD5lZm7V0dpkbuiLSrz4JUwJ7FgQ6gQ?= =?us-ascii?Q?rx+UBeu5DsjttDFvMnKFzEbWZsAAjHTdvI0OowmR/TRe8ruDR8BlGvULcGAC?= =?us-ascii?Q?FBYEZbAev5g33gSNTSobXa8Q9oVE2kqeg5SPRRB3OyN9rSLsTSd/731ropuT?= =?us-ascii?Q?cz4AJPtaKpDgew6uwDL0KlDO7Z58HknSaaIbkbKGZu/XQW3UgBnzne9/+2f2?= =?us-ascii?Q?oILrzvyDbf533M+H/06Zav9m/Mlg3UVLTPRzfsF/C5OvTb74LMGvKWPXxGot?= =?us-ascii?Q?o/dx9vYs3s1r8FvRGrHUmwQsd8Rkdple3osEuQVDebJtqyeddpdMHzFk+4at?= =?us-ascii?Q?25NvULJWZHSRq0yqQ5kK4Z9jozUc5ZH5bU+FJEIHc6J1sUkW6GBV7xLQmniK?= =?us-ascii?Q?FOQYXgAcrKD9BsR+KgHZMmR0xVo0HUADsr4RGkK/dOUrmOtflw+fykwAEtiZ?= =?us-ascii?Q?+j98wD25PORU1pstfe0t00/5emqvb01uDTmXlygAXUBShUUWtH2f03VJpQBQ?= =?us-ascii?Q?VWlszZrzSgejmcYbrUrvQTM0d80SLKfmaj9SqzeqGdtm5TQVPsQwRw+Q3JOZ?= =?us-ascii?Q?y6WeWbYIqwpW3EZKipmaCOrltrqfXKVucPEdjxk/tJzaQ0/WdZFrHSU/jaoz?= =?us-ascii?Q?puhGyyLGrzc4dsntqkLTDzvZXVTyL4TUZyZSwHslf?= X-Microsoft-Antispam-Message-Info: EPLvCX0dmdWG3mF+yy0/Dlvhk9SqdkcXx9wevORz6XW9cnZ8ONoUcMTKLsqb/cA/VwY90VS1VjcJgid8lVPeQTAAQNEMwn7w1X1QsGFIcmChxXQB3sOpqyMUZEk5A5BWMhaEm237sblV+VzzKKwt74bh3S6hAgAg2Ua7BFITF4ZuUCScLPC+adSuhAUmdNUs X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2319; 6:Bw3hL7yfEPDLUdoFuN1bh8Cv6yrgAzJRoBIOlen5xUlfKsAEmFhor+vbzLtMjsjZKbztjUARN+p0gAMo88oHRcbPtuRQMvh6+ISGoZeFt2WBt59+h2rz9XqlAKv1ytDAdE7K+u8ahWFd1StI2928YeEU76lLrco20UhT6mY+leFCmJeRieZEcYUZU642COLKRezq3dy5ux5usq/mUvwMVr7xEtRXwXD4RKN6Pu9RzmAmKl2mxJ1xDmMb4g+AmOSCmqAtSe65hwmC3R4hDDnSbeu2TIdEtX3k23NzK+oyQfzjg74+fbwtDIMPQevoqY6g/1vdBDfMmH6wx+XiEE15xV9wkagUYVchAp61SMEOuPmsmz5PhnzyAkk0eL42+g+r2cYLHDIBCUvlv9GVp5oSEt7bYAbRfExeNZdJdQA7sveYkQhBNoYWBcLWVwkxIQptjaJgDA22ydcZHPhYPFMBCg==; 5:5Osnat2RJun8gPK5ukifRGLzd7TP83J1EZP2K9ZBDkmWBoqzFX1tr9h6uayiJXGJZe6YP4tBHW12qLRosPlBmGRKBNihy9NejDqJ9eiDianLRU3aaE+f4VSF5VX7kHs9HRtDGBQ6/62vmXAIijshe8WVjlbzu0KYjU2gMsrbouU=; 24:7dSV1uvVDtGELu+SLsK0FymBssVCMcgsgKJrEAXlSBi8aTWj9SusrOCkC1aIJXlvarTBDaOh2UwrnRc3K/UZZ++YUoSQLRqlxKiGhHmCaQ0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2319; 7:rlHOnvhWoN8wPpqkYkVW1+G2dQNHjf9XMZlFHoiDBWfUluMmRIRpliPkwWWMazYLBkf/gWpy30k0R3KHGjGXlflqCmzzjmJ/Mjr12Gj9FWm25Kv8a0naEdxV3dCjP0fje0EOItPym97S/zOPwTGOgsMy+vAZK1TZ/npZzyXH73A+5d+HIKxlQ5OdV15KlcnuUC7f6qnR9Ug5nHAfIPEE95oCHFfYieNXqdadXper0DU/GseHIjaJOxP/XQUaOYL5 X-MS-Office365-Filtering-Correlation-Id: 46b81055-6d5d-4af3-d5d7-08d5b9e7bc2a X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2018 22:12:07.6736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46b81055-6d5d-4af3-d5d7-08d5b9e7bc2a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2319 Subject: [dpdk-dev] [PATCH v2] net/tap: fix isolation mode toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 22:12:11 -0000 Running testpmd command "flow isolae 0" (i.e. disabling flow isolation) followed by command "flow isolate 1" (i.e. enabling flow isolation) may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: when disabling flow isolation we keep the local rule to redirect packets on TX (TAP_REMOTE_TX index) while we add it again when enabling flow isolation. As a result this rule is added two times in a row which results in "File exists" error. The fix is to identify the "File exists" error and silently ignore it. Another issue occurs when enabling isolation mode several times in a raw in which case the same tc rules are added consecutively and rte_flow structs are added to a linked list before removing the previous rte_flow structs. The fix is to act upon isolation mode command only when there is a change from "0" to "1" (or vice versa). Fixes: f503d2694825 ("net/tap: support flow API isolated mode") Cc: stable@dpdk.org Reviewed-by: Raslan Darawsheh Signed-off-by: Ophir Munk --- v1: initial release v2: 1. Updates based on Keith Wiles review 2. Do not empty list of implicit TC rules (role back to legacy implementation) to ensure TC implicit rules cleanup during implicit rules flushing drivers/net/tap/tap_flow.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index aab9eef..6b60e6d 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1568,10 +1568,14 @@ tap_flow_isolate(struct rte_eth_dev *dev, { struct pmd_internals *pmd = dev->data->dev_private; + /* normalize 'set' variable to contain 0 or 1 values */ if (set) - pmd->flow_isolate = 1; - else - pmd->flow_isolate = 0; + set = 1; + /* if already in the right isolation mode - nothing to do */ + if ((set ^ pmd->flow_isolate) == 0) + return 0; + /* mark the isolation mode for tap_flow_implicit_create() */ + pmd->flow_isolate = set; /* * If netdevice is there, setup appropriate flow rules immediately. * Otherwise it will be set when bringing up the netdevice (tun_alloc). @@ -1579,20 +1583,20 @@ tap_flow_isolate(struct rte_eth_dev *dev, if (!pmd->rxq[0].fd) return 0; if (set) { - struct rte_flow *flow; + struct rte_flow *remote_flow; while (1) { - flow = LIST_FIRST(&pmd->implicit_flows); - if (!flow) + remote_flow = LIST_FIRST(&pmd->implicit_flows); + if (!remote_flow) break; /* * Remove all implicit rules on the remote. * Keep the local rule to redirect packets on TX. * Keep also the last implicit local rule: ISOLATE. */ - if (flow->msg.t.tcm_ifindex == pmd->if_index) + if (remote_flow->msg.t.tcm_ifindex == pmd->if_index) break; - if (tap_flow_destroy_pmd(pmd, flow, NULL) < 0) + if (tap_flow_destroy_pmd(pmd, remote_flow, NULL) < 0) goto error; } /* Switch the TC rule according to pmd->flow_isolate */ @@ -1739,8 +1743,8 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, } err = tap_nl_recv_ack(pmd->nlsk_fd); if (err < 0) { - /* Silently ignore re-entering remote promiscuous rule */ - if (errno == EEXIST && idx == TAP_REMOTE_PROMISC) + /* Silently ignore re-entering existing rule */ + if (errno == EEXIST) goto success; TAP_LOG(ERR, "Kernel refused TC filter rule creation (%d): %s", -- 2.7.4