DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xu, Rosen" <rosen.xu@intel.com>
To: dev@dpdk.org, thomas@monjalon.net
Cc: rosen.xu@intel.com, roy.fan.zhang@intel.com,
	declan.doherty@intel.com, bruce.richardson@intel.com,
	shreyansh.jain@nxp.com, ferruh.yigit@intel.com,
	konstantin.ananyev@intel.com, tianfei.zhang@intel.com,
	song.liu@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr
Date: Wed, 16 May 2018 16:49:04 +0800	[thread overview]
Message-ID: <1526460544-148713-1-git-send-email-rosen.xu@intel.com> (raw)

From: "Zhang, Tianfei" <tianfei.zhang@intel.com>

fix a return error value by DPDK Coverity static code analysis

Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
Coverity issue: 279448
Cc: stable@dpdk.org

Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>
---
 drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
index 49d8cc5..ec0beeb 100644
--- a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
+++ b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
@@ -139,7 +139,7 @@ static int fme_pr_write(struct ifpga_fme_hw *fme_dev,
 			pr_credit--;
 		} else {
 			WARN_ON(1);
-			return -EINVAL;
+			ret = -EINVAL;
 			goto done;
 		}
 	}
-- 
1.8.3.1

             reply	other threads:[~2018-05-16  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16  8:49 Xu, Rosen [this message]
2018-05-21 14:13 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526460544-148713-1-git-send-email-rosen.xu@intel.com \
    --to=rosen.xu@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=hao.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=song.liu@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).