* [dpdk-dev] [PATCH] net/sfc: fix errno value if flow API RSS action parse fails
@ 2018-05-16 14:21 Andrew Rybchenko
2018-05-17 17:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2018-05-16 14:21 UTC (permalink / raw)
To: dev; +Cc: Roman Zhukov, stable
From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
The value of rte_errno must be positive in case of an error.
Fixes: d77d07391d4d ("net/sfc: support flow API RSS action")
Cc: stable@dpdk.org
Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index e6b2ecff4..b15c937b9 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1572,7 +1572,7 @@ sfc_flow_parse_actions(struct sfc_adapter *sa,
rc = sfc_flow_parse_rss(sa, actions->conf, flow);
if (rc != 0) {
- rte_flow_error_set(error, rc,
+ rte_flow_error_set(error, -rc,
RTE_FLOW_ERROR_TYPE_ACTION, actions,
"Bad RSS action");
return -rte_errno;
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix errno value if flow API RSS action parse fails
2018-05-16 14:21 [dpdk-dev] [PATCH] net/sfc: fix errno value if flow API RSS action parse fails Andrew Rybchenko
@ 2018-05-17 17:45 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-17 17:45 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Roman Zhukov, stable
On 5/16/2018 3:21 PM, Andrew Rybchenko wrote:
> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>
> The value of rte_errno must be positive in case of an error.
>
> Fixes: d77d07391d4d ("net/sfc: support flow API RSS action")
> Cc: stable@dpdk.org
>
> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-17 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 14:21 [dpdk-dev] [PATCH] net/sfc: fix errno value if flow API RSS action parse fails Andrew Rybchenko
2018-05-17 17:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).