* [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
@ 2018-05-17 11:24 Xiaoyun Li
2018-05-17 14:54 ` Zhang, Helin
2018-05-18 4:29 ` Wu, Jingjing
0 siblings, 2 replies; 4+ messages in thread
From: Xiaoyun Li @ 2018-05-17 11:24 UTC (permalink / raw)
To: jingjing.wu, wenzhuo.lu; +Cc: dev, Xiaoyun Li, stable
When resetting ports, traffic will be blocked. There is a mistake when
getting hw info at avf_dev_stop. This causes the device stop without
stopping queues. This patch fixes this issue.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 0ef1f17..ad83a57 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -475,7 +475,7 @@ avf_dev_stop(struct rte_eth_dev *dev)
{
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
- struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev);
+ struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
int ret, i;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
2018-05-17 11:24 [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue Xiaoyun Li
@ 2018-05-17 14:54 ` Zhang, Helin
2018-05-17 14:56 ` Zhang, Helin
2018-05-18 4:29 ` Wu, Jingjing
1 sibling, 1 reply; 4+ messages in thread
From: Zhang, Helin @ 2018-05-17 14:54 UTC (permalink / raw)
To: Li, Xiaoyun, Wu, Jingjing, Lu, Wenzhuo; +Cc: dev, Li, Xiaoyun, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li
> Sent: Thursday, May 17, 2018 7:24 PM
> To: Wu, Jingjing; Lu, Wenzhuo
> Cc: dev@dpdk.org; Li, Xiaoyun; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
>
> When resetting ports, traffic will be blocked. There is a mistake when getting
> hw info at avf_dev_stop. This causes the device stop without stopping queues.
> This patch fixes this issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
2018-05-17 14:54 ` Zhang, Helin
@ 2018-05-17 14:56 ` Zhang, Helin
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2018-05-17 14:56 UTC (permalink / raw)
To: Zhang, Helin, Li, Xiaoyun, Wu, Jingjing, Lu, Wenzhuo
Cc: dev, Li, Xiaoyun, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Thursday, May 17, 2018 10:54 PM
> To: Li, Xiaoyun; Wu, Jingjing; Lu, Wenzhuo
> Cc: dev@dpdk.org; Li, Xiaoyun; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li
> > Sent: Thursday, May 17, 2018 7:24 PM
> > To: Wu, Jingjing; Lu, Wenzhuo
> > Cc: dev@dpdk.org; Li, Xiaoyun; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
> >
> > When resetting ports, traffic will be blocked. There is a mistake when
> > getting hw info at avf_dev_stop. This causes the device stop without
> stopping queues.
> > This patch fixes this issue.
> >
> > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue
2018-05-17 11:24 [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue Xiaoyun Li
2018-05-17 14:54 ` Zhang, Helin
@ 2018-05-18 4:29 ` Wu, Jingjing
1 sibling, 0 replies; 4+ messages in thread
From: Wu, Jingjing @ 2018-05-18 4:29 UTC (permalink / raw)
To: Li, Xiaoyun, Lu, Wenzhuo; +Cc: dev, stable
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, May 17, 2018 7:24 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/avf: fix AVF traffic blocked issue
>
> When resetting ports, traffic will be blocked. There is a mistake when
> getting hw info at avf_dev_stop. This causes the device stop without
> stopping queues. This patch fixes this issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> drivers/net/avf/avf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
> index 0ef1f17..ad83a57 100644
> --- a/drivers/net/avf/avf_ethdev.c
> +++ b/drivers/net/avf/avf_ethdev.c
> @@ -475,7 +475,7 @@ avf_dev_stop(struct rte_eth_dev *dev)
> {
> struct avf_adapter *adapter =
> AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> - struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev);
> + struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> struct rte_intr_handle *intr_handle = dev->intr_handle;
> int ret, i;
> --
> 2.7.4
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Thanks, Xiaoyun!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-18 4:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 11:24 [dpdk-dev] [PATCH] net/avf: fix AVF traffic blocked issue Xiaoyun Li
2018-05-17 14:54 ` Zhang, Helin
2018-05-17 14:56 ` Zhang, Helin
2018-05-18 4:29 ` Wu, Jingjing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).