From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 51C008E59 for ; Fri, 18 May 2018 04:02:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 19:02:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,413,1520924400"; d="scan'208";a="55405919" Received: from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain) ([10.67.110.10]) by fmsmga004.fm.intel.com with ESMTP; 17 May 2018 19:02:30 -0700 From: Jeff Guo To: qi.z.zhang@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, jia.guo@intel.com Date: Fri, 18 May 2018 10:05:18 +0800 Message-Id: <1526609118-119241-1-git-send-email-jia.guo@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526452123-116723-1-git-send-email-jia.guo@intel.com> References: <1526452123-116723-1-git-send-email-jia.guo@intel.com> Subject: [dpdk-dev] [PATCH] net/i40e: fix link up failure issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 02:02:32 -0000 In case of the known issue, that DPDK PHY config can't synchronous with kernel driver and firmware, this will result of the nic can't link up after rebind to the kernel driver. This patch propose to work around it by don't config PHY and don't set link down when stop device. Fixes: 6e145fcc754b ("i40e: support autoneg or force link speed") Signed-off-by: Jeff Guo --- v2->v1: delete irrelevent part of code --- drivers/net/i40e/i40e_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 014bfce..27a5722 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2306,9 +2306,6 @@ i40e_dev_stop(struct rte_eth_dev *dev) /* Clear all queues and release memory */ i40e_dev_clear_queues(dev); - /* Set link down */ - i40e_dev_set_link_down(dev); - if (!rte_intr_allow_others(intr_handle)) /* resume to the default handler */ rte_intr_callback_register(intr_handle, -- 2.7.4