From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 1B3BBD072; Fri, 18 May 2018 15:22:24 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id v60-v6so9189323wrc.7; Fri, 18 May 2018 06:22:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=wQMB5rv+5CaWtrP7h1t/nMHB8P3d7/R7Ogyu70bbdGw=; b=PH7Tv3TG7d4JayZiZ2JmhKpkZNysjSZcGsYsDl/mRTzAIBHw6wSlAqW35CRHQMGg65 8q+5pbzryXwZYoorZLKdi0k2ajR15lq4lpM0u0UR/GaNde+DRCFejY0KWfj/c2o0dyL2 bqfZrgn6gGKQoNMs1RYFrpoKSuZQmOFf5EkeQGNSkKegwzWnr7hmbhsLpcG88ELLi1uH roB8LSnFthy/mMFXKNTy0xqdEtrP6VqAPgcBjTxO4m3bAkWC1AwmNhtRVkWmti90ySQd tITxxiq3K5hCEf0Rx0MDxTZS357Kv52O5PRIZWaLsYtJevANtSn5+r9360loyD9Mc6TA tKZA== X-Gm-Message-State: ALKqPweWcMeq8FlK40WEQ0wG6SME+JMLNYGqDVQOk66jFfbt+SE9kCP3 Y+ss0CEbUehmbdvJOfWWnTXbcCN677o= X-Google-Smtp-Source: AB8JxZprrF/pSjR9/t39SiMk/Xro7lV4ZkrBEuM0rauZfkGPUN/BNnLhJgHRCQHnGJF8ijnhob3k5Q== X-Received: by 2002:adf:85f4:: with SMTP id 49-v6mr7602267wru.33.1526649743776; Fri, 18 May 2018 06:22:23 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id a129-v6sm6930655wme.34.2018.05.18.06.22.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 May 2018 06:22:22 -0700 (PDT) Message-ID: <1526649742.23337.142.camel@debian.org> From: Luca Boccassi To: Aaron Conole , stable@dpdk.org Cc: Alejandro Lucero , Eelco Chaudron , Yuanhan Liu , dev@dpdk.org Date: Fri, 18 May 2018 14:22:22 +0100 In-Reply-To: <20180514144658.9671-1-aconole@redhat.com> References: <20180514144658.9671-1-aconole@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 13:22:24 -0000 On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote: > For the stable versions of DPDK, the NFP driver's NSP user space > driver was modified to account for non-root usage.=C2=A0=C2=A0When that > happened, commit 515933ad8385 ("nfp: allow for non-root user") > inadvertently removed the unlink() call. >=20 > Fixes: 515933ad8385 ("nfp: allow for non-root user") > Cc: Alejandro Lucero > Cc: Luca Boccassi > Cc: Eelco Chaudron > Cc: Yuanhan Liu > Signed-off-by: Aaron Conole > --- > =C2=A0drivers/net/nfp/nfp_nfpu.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c > index ae2e07220..c003640c7 100644 > --- a/drivers/net/nfp/nfp_nfpu.c > +++ b/drivers/net/nfp/nfp_nfpu.c > @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) > =C2=A0 close(desc->lock); > =C2=A0 > =C2=A0 nspu_get_lockfile_path(lockname, sizeof(lockname), desc); > + unlink(lockname); > =C2=A0 return 0; > =C2=A0} Applied and pushed to stable/18.02 Next time, please send patches that are only for stable to stable@dpdk. org and do not include dev@dpdk.org Also use --subject-prefix=3D'PATCH ' so that we can understand for which branches a patch is --=20 Kind regards, Luca Boccassi