From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0081.outbound.protection.outlook.com [104.47.40.81]) by dpdk.org (Postfix) with ESMTP id A43D38DA4 for ; Sun, 20 May 2018 02:16:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o3BAfy+yns+/zGtK3YxuXOn+RL4CXRMaPV13Tq3cFAk=; b=FlWJBU78fKmqTiyxQSLArYN8X80GZ07HrW3Pa3W2d6jYx6Z0RSxoO0RK1ydxuEaddX/huJHRjkstvtxZDBZNrYPkpt4pamFDW3yYuNIjtYy1atse4ebyF90tqBN7FoaIx6yu8Nti0NDbuffPrTUk2LhzbIvTB5vQMO8s9GKxGbM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by CY4PR0701MB3668.namprd07.prod.outlook.com (2603:10b6:910:93::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.16; Sun, 20 May 2018 00:16:22 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Sat, 19 May 2018 17:15:45 -0700 Message-Id: <1526775346-10643-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1526775346-10643-1-git-send-email-rasesh.mody@cavium.com> References: <1526775346-10643-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: CO2PR04CA0149.namprd04.prod.outlook.com (2603:10b6:104::27) To CY4PR0701MB3668.namprd07.prod.outlook.com (2603:10b6:910:93::19) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3668; X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 3:ooRfZiEyuoORNirERNEKe0idglH2J8xlaPNQdO0SILkNgc1HnnsXg5wlAzXiCs/2UTq0DeRwgXWBngVZUlnhjW+otG8ZhH1vTAXQR9asIK8CB4TlAkwLn1DsRUCpfzjMqNI+6bxNRSCjlgq/6edErJFba7iT5XIUOgP9fJg22ZQd+fddA71sSIbc2nOB+wRaLjg5NdybPLVSCXK14LRxb+OvhBm2vy/Y3zi1H89T+2ars2AvKMIEf1bx3RlBmLSt; 25:GKEjv1J27/0bLwWjcyCwfwZ0cSd0HoGnZOfrzT7xymzM6M4evjRcyn+Sdp/Vsus4NENWQiBsz77VJN/brxB1wwv4quaShM1AbawCYGdzcj1GqSWnYgUC8cLk+itIcpCxZgkOiPv63e22O9nxj2/j+hmxODy5Ijphn6yYbRBGs2XaWS12wtu4J1ndGFX3ypoqxa6BlE4g0PP/XD8dp3p9mT8rIjGSwIVr7iAKGp/7hRUw4pu1VB0jNtZEqbrY3yUNZe6RMY9Z/A4IgRlTTPH2vPV1U/Ycuf2xffSt2fEzhrpTRitqnTWhwVs+34mYCQJ1oQCFC1HFLnh0ygroPoFK2g==; 31:2+k6/fjxC6ACb6HF9zWOaZAN7jUPs51a+HUqqDEbZRpAMMFTC8UWYTt9DBdRkcg/Q1Wl1Sf6R0bohjYOE7LsnsaeJ092afCEq3qrWmDHI8IcEfIscmNeKIVMzF1pppznQiaHVVqSAKxfPigE1zrW94s/3Ze6tawyUuVsXLbq6F94kMdhLv0BaBUo5ZSr7ewmNUbr1Bibm8xnCpUucHIH5n+Ln3/PyeXAIxi7u/k5S3I= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3668: X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 20:ioEy1IUcytgy2biUJR2MKM9jKrjgfHgPW4BTKPufeV8LCl/h7JGGaa4t/nKyluiwIz4E0mBIh0wb6vNlk3s8NiUt/MAdKdX4ccH03nETns1ZswrBKrPoTzeSLCDYoOswDbVRoaTUK+HghBBtaEl/3U+8+GIDsjhkqbSoih97XUYXpjQeJ/9XSmUe4gNsWpKjFkJzCq4Y3rTAfP+mco20blbCDC1hMMRMOkI5twDII7y4f7Jk0EQh2CtvFj6StQFEaKU/LkfqWXoKc2QgWQ6XxF6r60/l+pI+FnoD5ylue/Eo4taJs8YWn0mWu/Vgw7XuUP26x6cLR6zf6KGZV999zs/DQseLUnyo2NGda/IvNhre1s6fTEKAKtlZSiRUZrIuHLPDPQpeftd/2SxE6FwtdJj3bE7lHN8NmJVjqXluZipoL9/4ZTMs7qBr4vHWcY4ehwpIoq/571OJFEXg8TjHdenXK0eAkTSdL3TDT6/QLjCj6b6/dD5DBteHSoNJUPzY; 4:2uW8o3ZuDVOW7YQGA6J+kJQ5OwH0Ed0e+kDJVM2NhxCtpU99bR1nqiULKtV1iMqdjKp7LCohCvzjkv2pRYswJOTxwW1y8F0Lw0EHfj29KXtUBKYjbMOD9+o69gIuskUKMQ+mbgRUuDKAsN99VVctNGOzophuYTZ5FEbBCDwNqKv89y3rRIj9+HNK6KY3CGP12xvdFaEomIFqZo50PtGQ3oszvTqe/ne5Ve1H5fsTPi6lbBHHggY4eBd10FzOgKd4FyTLxK5eOsCHSajFC7yFuw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3668; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3668; X-Forefront-PRVS: 06780E24F8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39850400004)(39380400002)(199004)(189003)(4326008)(16526019)(186003)(575784001)(6666003)(386003)(51416003)(7696005)(8936002)(26005)(6116002)(53936002)(316002)(7736002)(69596002)(5660300001)(25786009)(44832011)(16586007)(36756003)(59450400001)(107886003)(81166006)(81156014)(52116002)(68736007)(8676002)(6916009)(76176011)(4720700003)(2906002)(50226002)(86362001)(2351001)(47776003)(2361001)(105586002)(478600001)(48376002)(66066001)(97736004)(3846002)(486006)(50466002)(446003)(476003)(2616005)(11346002)(305945005)(956004)(21086003)(106356001)(55016002)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3668; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR0701MB3668; 23:eIYYRVwhxRLycsjhoey3NDmGRmKsu6mCxDc/IVa?= =?us-ascii?Q?c/0kaoo8k5KWRgr/dD4gjBPH67y/J/xFxEf/DXbw5xQft8nQeR3NdqEpUqLS?= =?us-ascii?Q?JjNPezSG6bL4/pOOpBWDOK64r2EUnZ1UIU2zmZbdSsPz38VI/K2RGA6Iwi93?= =?us-ascii?Q?ey8lZg5mntJPMtGpOb6Va326EVaT4HQknnnaBzolkOtKfD+pDCZKVERBuhZH?= =?us-ascii?Q?HfEaHtdQ+wx1N7J4ELxedpriEaoGR3hIyeZitt/oO161CfpHwb5c6h3NAb+M?= =?us-ascii?Q?wPOC6stMDQ7f6TWjnTbJ3gFfhZUIBc+4+xVqoMLZu5+aDvMoCF/Px5zYSJ73?= =?us-ascii?Q?fbSW9NZHa7rL6qxvMdODpTmELr//e8ZenAUETLKa0mgNjE29kVdIbLqx8DrH?= =?us-ascii?Q?0hAWfJNfVi3nUOLMXlmmIMLBED/vrjugK5Xm71Ino/BIQuaLzxBKDPBRmgsy?= =?us-ascii?Q?yM8zdRsf1R5LtgPAWCTaqC3nuGKUzjdqkMXUoNwLPdYQx3pfYobzZjenLaq1?= =?us-ascii?Q?BODQWKp4MGU1OdOtoZNYkfbK26wtG6M09b7fNgM5v7Qf+EGg0bjL3K1M4GKg?= =?us-ascii?Q?89fHizUs80onjqG2LGEdQ9fKjgsWcWbDFQxLuOVS+4QdmnHnxF6yp3D46AC3?= =?us-ascii?Q?Db2x5Y5STOwlB4FQnvbl2+7tUroWPe/bgQM/tbYYHmou/39wboV0BFl6I7M7?= =?us-ascii?Q?k9p/8kBlzegnf2Xe4ixsshnhJYE7W+LySUzd5LQg8oLHZLR8p16Ddb9DITZd?= =?us-ascii?Q?IQ3yWUgQY7k8VKt37NrDtKwRu+JV0EbqvC0s3fmWQIozG5qXWEKs3/ccb7OJ?= =?us-ascii?Q?iR6Kea948NjzsLlvmQb1gPXnMn5t9M5lmuC6hcjdX/fGE9HlUc776MRucgHi?= =?us-ascii?Q?h9Xf9b29idvRxIYVdNWs5vepQQlVG6tTrOd2LPhM2niOptQF+Fbahw8QpauJ?= =?us-ascii?Q?3VhjJ4oVV25fWPJPScc3Bi98ZLqdGaTlWzl0E6hIYMdKOJaBvQOSKlkUV8dR?= =?us-ascii?Q?41ZX6kfF8kbhpU8rT9tV6XTLClv1Y8fdLK0lXUX9AaFt6ismE5dYlzDzDLy1?= =?us-ascii?Q?wD3RXyZu+dd6ludQGqROZLBbLmqqv56E3MuhlDiAJiMdozI6tXZnLriXu1xK?= =?us-ascii?Q?BBPosfhaY9mPrGqWexvl7mTZ+lL7Vn7drVcCEsP8sV9LNlW2ZwW1u0RIprjL?= =?us-ascii?Q?8Km99WUOrRjSSZV+sp4b8w67S65ya1VGc1ezplHh3dnbMF1B70ilKIaBiwil?= =?us-ascii?Q?5Is7qSQUPSTjbTPVv/aA87b+x30NVGVXT39/cXbUlMorssHaJT10HLO5fFWm?= =?us-ascii?Q?MQdQyTX+eCveXbjwPnaR/yU+R/17KkeMCTGDjBPjEAShRU9w9Nss7O0ikoqa?= =?us-ascii?Q?x8s4VKGr8n60Imgx4Oq2JxQgNKSY=3D?= X-Microsoft-Antispam-Message-Info: y4uBbrn0iyiYKX/vTfoFs2zmb8UfIJaZ9PXonyxzUc72zATVVrO59oBIa0Sye3K1AIti84oQWyVAOBWh/FvlGE2Wj88MssmQtd5wb2Ajc9sCz4ToL8EgIFnyGcIiQ5cPLgLpIE7hz3FaAOUniR8aKVn2UBDWfcTwWUVOm07eOpYiOrhOC6BiMF78azDAAlJf X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 6:D7LcBytnZ1Oo546vCaWH+K/OApQlMcCPvEqyJ8/NJS9TBwQR/RMRuJJonUtGZcpi4pfEAmPBNcPqmN61JsA+NwvOS3hgWygd0K+a7FBrNqtuM/VtnIONGVpkl/4fgilgNAjfs19wus+yWnLDQtjrt2/7OnF0e3N7qnXsjSEk3L6qvcnxB6pdCsPz2meU5Ipff+C/5EGcRprLNbGP7rAI7PdJbYiuvUKFGgkRPmMwvDYQKBkHsJeu/KPiSCLo1HERAfBg+T9h6tpHgiNaDzZhGFEITrjIAPggWFjWZ5A+g4jOQMzYH9Tc4gjYkm3yNkPt7D9SlXSR7uU0UprvRAld53XOm2L+FhPkcwm4v1FtXQUMXYvjck7KfJR7mR4pp2Dj5XzGxCQ/FjAwPHM5PFUc/C7YLhLjLWLLYhm/4OIvog3hWj34MIrYdRssD23HtiQx48x1+FZGEcg9GqUdJvXrcA==; 5:YgG72fGpdkRTEDoSQmGqHDHSu1hGBxks2IxAE/hsFRz84SaNApUTfgt2tikyg9vy2JgiV/7b1oDDS+qC213UuIrqr9GBsI3KVBCzgwFd80d3qpo5yydZ8MkuuqNDvwhTfoKnZt4fFvp8zpe5+3GHuaepzrUkL8+LKUAzs6ujT7Y=; 24:SopMLucp/Ys2slRTTXbaIXWMpkvVlSchQvOAIbs2T2pMSXNal/4Xh2NWoIeW5mG8t7ip5NKZ7DhGyhqrVPLGA5sacHhcExIhu/TYfcTvCy4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 7:yxoFEIuj2phhM32jzMWDE2XCmrRIqa55IqtWIk5EvJUcrdF5NYx4Jjk8YgpkY6oA8Tut+jLE/wOsBNWrh49OjgnZnCNC1xFaNgC/QZ83NAG+Bdo1gMLRDKzZ9tZ0bCv1MfyKFM7v6I1xHLPj0u4lK1QTePygd/uy3fGkicRZv+SWIkBxmYd502SWQViVLme3BO68vCLfrN+zvHUYQi7zOF7KeK/TwRrTCpKvvwZb7xpgu9ky8rPPJNhNaPJBPFrH X-MS-Office365-Filtering-Correlation-Id: 54544a4b-4708-4182-03ed-08d5bde6eb70 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2018 00:16:22.9470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54544a4b-4708-4182-03ed-08d5bde6eb70 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3668 Subject: [dpdk-dev] [PATCH 3/4] net/qede/base: reduce verbosity in HW init log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 00:16:25 -0000 Reduce the verbosity in ecore_pglueb_rbc_attn_handler() while logging errmsg during HW init. This could happen due to ungraceful exit of previous driver instance. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 2 +- drivers/net/qede/base/ecore_int.c | 15 ++++++++++----- drivers/net/qede/base/ecore_int.h | 3 ++- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index b1e67e2..be81b0b 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2514,7 +2514,7 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, } /* Log and clean previous pglue_b errors if such exist */ - ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_main_ptt); + ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_main_ptt, true); ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt); /* Enable the PF's internal FID_enable in the PXP */ diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index d9e22b5..7784cbf 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/drivers/net/qede/base/ecore_int.c @@ -287,9 +287,11 @@ static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn) #define ECORE_PGLUE_ATTENTION_ILT_VALID (1 << 23) enum _ecore_status_t ecore_pglueb_rbc_attn_handler(struct ecore_hwfn *p_hwfn, - struct ecore_ptt *p_ptt) + struct ecore_ptt *p_ptt, + bool is_hw_init) { u32 tmp; + char str[512] = {0}; tmp = ecore_rd(p_hwfn, p_ptt, PGLUE_B_REG_TX_ERR_WR_DETAILS2); if (tmp & ECORE_PGLUE_ATTENTION_VALID) { @@ -301,9 +303,8 @@ enum _ecore_status_t ecore_pglueb_rbc_attn_handler(struct ecore_hwfn *p_hwfn, PGLUE_B_REG_TX_ERR_WR_ADD_63_32); details = ecore_rd(p_hwfn, p_ptt, PGLUE_B_REG_TX_ERR_WR_DETAILS); - - DP_NOTICE(p_hwfn, false, - "Illegal write by chip to [%08x:%08x] blocked. Details: %08x [PFID %02x, VFID %02x, VF_VALID %02x] Details2 %08x [Was_error %02x BME deassert %02x FID_enable deassert %02x]\n", + OSAL_SNPRINTF(str, 512, + "Illegal write by chip to [%08x:%08x] blocked. Details: %08x [PFID %02x, VFID %02x, VF_VALID %02x] Details2 %08x [Was_error %02x BME deassert %02x FID_enable deassert %02x]\n", addr_hi, addr_lo, details, (u8)((details & ECORE_PGLUE_ATTENTION_DETAILS_PFID_MASK) >> @@ -320,6 +321,10 @@ enum _ecore_status_t ecore_pglueb_rbc_attn_handler(struct ecore_hwfn *p_hwfn, 1 : 0), (u8)((tmp & ECORE_PGLUE_ATTENTION_DETAILS2_FID_EN) ? 1 : 0)); + if (is_hw_init) + DP_VERBOSE(p_hwfn, ECORE_MSG_INTR, "%s", str); + else + DP_NOTICE(p_hwfn, false, "%s", str); } tmp = ecore_rd(p_hwfn, p_ptt, PGLUE_B_REG_TX_ERR_RD_DETAILS2); @@ -395,7 +400,7 @@ enum _ecore_status_t ecore_pglueb_rbc_attn_handler(struct ecore_hwfn *p_hwfn, static enum _ecore_status_t ecore_pglueb_rbc_attn_cb(struct ecore_hwfn *p_hwfn) { - return ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_dpc_ptt); + return ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_dpc_ptt, false); } static enum _ecore_status_t ecore_fw_assertion(struct ecore_hwfn *p_hwfn) diff --git a/drivers/net/qede/base/ecore_int.h b/drivers/net/qede/base/ecore_int.h index 563051c..7c1ee2e 100644 --- a/drivers/net/qede/base/ecore_int.h +++ b/drivers/net/qede/base/ecore_int.h @@ -256,6 +256,7 @@ enum _ecore_status_t ecore_int_set_timer_res(struct ecore_hwfn *p_hwfn, #endif enum _ecore_status_t ecore_pglueb_rbc_attn_handler(struct ecore_hwfn *p_hwfn, - struct ecore_ptt *p_ptt); + struct ecore_ptt *p_ptt, + bool is_hw_init); #endif /* __ECORE_INT_H__ */ -- 1.7.10.3