From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0081.outbound.protection.outlook.com [104.47.40.81]) by dpdk.org (Postfix) with ESMTP id 66FA58DA4; Sun, 20 May 2018 02:16:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OW/XqYTOivbuFXB4yAaEYZJ3aeOYfu5xaqZz9ZJrUJo=; b=ipvEHh/vD1CKPXfh7uyynuXQeXZ8oIpfJL85CwFjPRyDEu4FRI5u0oKQFZL9+gJULuQcjg32M9eF/caN8YIxtGrLzqDPmDB4+fA+/0/NPsfEiA6XoB2DEummRJazO5vsBJgtQWa+JqM6Ilc6EZX9bxmaAn+zEmdrtagpeq8KRIk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by CY4PR0701MB3668.namprd07.prod.outlook.com (2603:10b6:910:93::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.16; Sun, 20 May 2018 00:16:23 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Sat, 19 May 2018 17:15:46 -0700 Message-Id: <1526775346-10643-4-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1526775346-10643-1-git-send-email-rasesh.mody@cavium.com> References: <1526775346-10643-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: CO2PR04CA0149.namprd04.prod.outlook.com (2603:10b6:104::27) To CY4PR0701MB3668.namprd07.prod.outlook.com (2603:10b6:910:93::19) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3668; X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 3:39T4c6UYSjXs2RtO4zCdnf2jjxMAVW9vHb8rryjASvcBFOday/jPqvC3tBapLT2ytSwe73T7bjhFa6YT4YzXnzagH/r5cNYLa9T1b5jKqa9616UVc6Z+9A/lmiAcG4Me2WRV6RRXHqh7jriDi5SSCOjBRWSE9Tx9q/vqVP0BPqclTpQYEPQOPdeuIQTR8AoM6i9wFvLc0cblTAO3ph88/+whFUHm1spCWu98ec+e4QHtiq38VMGSwEgnEgcO9Ch6; 25:6t4vnMvPDNABd4bwkrWnN8ARC2fzox+JHuRPC61Gzo+Z+rtc1vrdp9A3OwKu4rkFqKygdCweWq/25tesZB+pYSWsk3eTtBSgnShNM/hDJbeA0rbwjfwzrz2nzihm7B4m/r5mQIzNtgQxh3Mf2B9wEG+maWgaaQMkhBL6F7M2HXE89XfZr3x8jCoj+0EZYJ3Dt4FC7VH1q6i7KyerIEzDPrncLTnekf/P2Nzgbbnh0dGxEyLi8RXAgHp0VaMGZrhOa/l+dHwCrrJArmDVxof8V37HxqNDgQP1wEoHPTWJcmuWkOajW5HN3EIjdehg0voYG3NvrxK9dVJX2swmk/XlXg==; 31:BgQ/zyK1xu2pMZ0G7F8Ve6mqlqO6A/sPLxaQyUGDQBYPoowsJwXl/+DmpK90U0C9zz+M4vVg7ZnSdWAGu6TXsA+IveASgW5murJjLa9DQEXtuUO+rKse+xnI2Xdkm+AvdZ1zIb1jef/R5rAoNUSH+X2qN+BOZUTpoIjtqHWik15T5rrylHQgf1T4he6cQnkAt4TVOCTFLHW3K4vcQP5fhsU4yIm5CCq03X3VXMYwEEI= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3668: X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 20:K6qzWfEg95wKVjsjyj15BV0CuALz6L4okvfi2ohzE94zdSvCe4cCEFWDZE14jYRyE70AcIyAPPMLrWbEN5O/vvhSymREVOQD6C239iYjn4gxPw2KBPCq/ooj2XX5HYXdMd7fTjDi+W29ju7UUlMJdzrTa/K2j2pGu1tF5e6ROCsIBJE7Axxgwwr2f7Hls9pgmaDrH1k4lBF4ZRCpOs4DqQ0ITVmzdpbRwF5gMfKjo1M6tYa7/bE7nwbvm39s+jHhQFYZjZyFOmqJiTVRWUcHFHQlYbNbWIbu5Eq7QkNDH4V+gj9FPaR/wGs2uAiQeOJ+CfcWdZDXwZWfMFCoP+jokt2QqFbhCPtNhxjgWz/vgpanr2UsdqVbFa9nJ37PoAhdnFw1ESwNbB5j5uFu4sWB+u2yaJdnk8n1oXb3oMN9xGI08buq8MjDCWUL8lcZFj2Hsd4UVMHEvwSS3RYEsskOBBt+BtKpzj0CqTYeiliQswab4lKASAk8bgvudPWXrnXG; 4:n/H3xkpsBVDJVYtp/Gotbq8ZGqmoyM/G6qe+2QjjMJ9Dv8RgSMw4e1PIuV0VEEevzpUjsGBGsuIrst+C85s7EYotgx3FLN/MBNPN6o5s4njVNkOTGd1SYbYfT6R77K/T7uJdgCulpUG1AenHSaUt1HuAIPMcWdVS5QhaKOUklBbZlphEje5oXxCGh15pc1+GA4eLMUGgPfJl6HyUPvn9YTg0liOVLwjavrQUO0cfXgKitxKMbU4fd/aRyS/on1b4nd+b5TyOvaFXX8j06Qz2wQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3668; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3668; X-Forefront-PRVS: 06780E24F8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39850400004)(39380400002)(199004)(189003)(4326008)(16526019)(186003)(6666003)(386003)(51416003)(7696005)(8936002)(26005)(6116002)(53936002)(316002)(7736002)(69596002)(5660300001)(25786009)(44832011)(16586007)(36756003)(59450400001)(81166006)(81156014)(52116002)(68736007)(8676002)(6916009)(76176011)(4720700003)(2906002)(50226002)(86362001)(2351001)(47776003)(2361001)(105586002)(478600001)(48376002)(66066001)(97736004)(3846002)(486006)(50466002)(446003)(476003)(2616005)(11346002)(305945005)(956004)(21086003)(106356001)(55016002)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3668; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR0701MB3668; 23:P9LEuO5Zh5IbnQIoAEPBvYSHcLTbqQbGpsmgF3A?= =?us-ascii?Q?3SMnpukO3YZ6VVZ6MOQfu7Jkr5j8zi+PuwSXWBrv5jKNRHnPRSt27xy8vvQL?= =?us-ascii?Q?jtHFtDCNioVGFo4vuXkBtclohSxQD7SmNTGK+5Jf3o9qbNefcJpgciRzME9X?= =?us-ascii?Q?2NAsRQhhLqfE2P4vROqMueS7kWzWdqXjaPRVrkacAKoOYWGy10N3nkH0/2zb?= =?us-ascii?Q?tYRWj30wpHSj1EGAvdb9l9DshHbOdn1CoFvdwxsNs+XN55HipQWaAKzkW5If?= =?us-ascii?Q?e9Wu5Q/Ty/3OlX+I6E7PLZmNYsvRDYp475VR1ddnQCUxOMs1cirvWBqw9O9p?= =?us-ascii?Q?FsVkFqQ0J4m001BeV3oUrk+6O7ny3QckqLAjFb3cRNF4MGuQp06hj7k1wOmW?= =?us-ascii?Q?G6nL8wB7RdJhTX8bQr4xNqYbYxvt92t4WR/XleV2cteVfqbcczuvWvmx+aDi?= =?us-ascii?Q?fOMktvYpQNXSLLF8rofsyoWnOlyJYDnotOS/H7c+zSZmrLMhf/vMUjaJMcVY?= =?us-ascii?Q?xvPsOA17IVlFwMfq0F/t3+rDxF3wEF4lUqBCdH9eI1qNmILpPwGb9GNuplMN?= =?us-ascii?Q?Qz+pCnNsqc4ebf+QgtOYdf3h5d1vvfvzJ4lzN+PgaTjp7vjO/u2nZuNyeLeP?= =?us-ascii?Q?D/R60ga6jcpTa24uY6Mzib3mU730LK+n3mYTkW2cwzyqSlFXzypixe1C+09w?= =?us-ascii?Q?TjpuZKAeBsATLpg3L9t3BFhifdt4WHgJIOOc3PTYKBZCgwxAMTgWtqPxJ5AB?= =?us-ascii?Q?cLofLyAlqsWQ7HyiMs3Xn8RJIs24DVkOpxqwv9SnNqNI6BZ5UxpIWyV+alBA?= =?us-ascii?Q?vhZa9FESjgS1SqKxoKYkD/3zAmE3D901fCrxhPku+x7CUtsnH5RaAkd2U/Dm?= =?us-ascii?Q?X6EUQ2NuPf9gqrl7DVZePz5WovbK1St0xXeFbtX1RqQOJ5Hb7Hjv4WEDMmFM?= =?us-ascii?Q?vrBls1YMzz4K8wSqU29udYVVOWLZXeciryP6jz3oSJlV3rxoYgMFei361Tbq?= =?us-ascii?Q?H2e8A2W3VBmuzY36yuloILSkiavNdIX8dZM2R6ogKUVXB0T5kA86vWAvL977?= =?us-ascii?Q?f+bVFaU3YAArzXzBMq3yttdMKAKs8bsXW45qviU0ZN3BLJV1wtZzfpq7rovv?= =?us-ascii?Q?0jHi08ruRAkG5b5l8QRHppZ6HAO2EfRHQsYiUCNestAFigqPWH6cYfJppe1Q?= =?us-ascii?Q?uHskhYUP3y5jYCh8mjV1/7iNEwZO1lhmfctxyyMDF+IFTNhWkQyT0gNauL+8?= =?us-ascii?Q?QJO5c8TCSDZSswqw/hFI2yN5oA67M/1Ngobrc7L9H6kADEVyESpC8MdhZZ5P?= =?us-ascii?Q?ea14+rRRjC67anjxZhjrW7364INiDB5Jp+dsrwABs8mw2?= X-Microsoft-Antispam-Message-Info: u1qwmpAUhQdbzjW2kc6oMG5DlZ+jOi977U4E5rs64TD4hO0q/J8MyejjbmVRxRjsigMGLycgNl8QNryaeHgvBTEL3fRXxQ0oPhFrFwdkytu/zf6xpch0geCxP0E5gyRjlpH/9jn37n6Y8LMCRWBeYVbGor3IJCi/obtANg15p1neEHTyj7k/h97dDhhhTW4p X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 6:q8NXqgQQc4M6+6auK/yxRzNnmWHs5DTp5fqpzwcUXkxjCJJ/hBg5LXyuwOaBuiJTZF33X3Eqxnr2Mq8knEJxZAYXVIiaADMZ5D2CjiZa4puige9Hk+2EAf6AuxTl2i4BlmkK6Ou8eq7WlqekSuki9L1nTLP9/cGJxcD0WIytmPnEFUR3nd+fYsrFUP7p1VfhKqoidwHoi12UIaxZqXKy92sFHkxZuHY2ovWMoe5gnj6KxBt1m3sQFRSJ4dOJb8BAJKYCFjxkRHrrYwLTfLjLx6zrEnnZEJFFcEq50BUPaOvns1h4o00igNiDsjUo9pAsTU9JbuUWuERfBWGlOqWCYhXssgFbMx87fVm2jOvFreVop0deLOXSIWIvKIF6wAp97beFQdmy2KVjopZyCVaXXDyH7To/oAEUhSEIO/uMFybF85fBLulBWpRKZ1ZAp1z+3D2QL0UMq5jbp72QrZ1eAQ==; 5:jZ5SqBXwN++ZKCxUhJLEz2+B8Pr9Rrv5C5q/PrB+LYHic4OQcQzWaS7HfB2UARqy1WX5AiysDhk8eufcD6CrNcZptYewIhzlGMZOqPAHbm3e4Hdmns1pLU9NExx8dPE4reeQ1YCQZqTyDtjKoSzwhgoqoaaN4PcddrGcBqBIZnY=; 24:GS/418mCZR3HLy98t/Dvxw+3rSw09fXIUI2+bv6b6X//jXcoEz1c58YjVTwIRCAjjSWj8XIwfFSx2vzn/J+2PX/y0m2Fayv9LCagdfi43hA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3668; 7:qU7O81Rq7qGngDPRCaVEQMy594fLqIS5nyrEEVH7cu+dWszj81lgokKATFhPlcsubMONMjLi66rjvssOmG+HRrY34+4et4jc5m6tSZvats8YNPHbdd5gcfmU7s2H0sLAOcfSj9ajE9Nw8acAccYjmx+ubEqPa+p5dZ3QRI84xZVYy91bet2Iypq/Sxug2XAkp6ULk1n1SP/9YCpQs/zwHYp7LAgGMkrG0CMMf/CJUcqbdhImqoFzE+p6CjOk36ch X-MS-Office365-Filtering-Correlation-Id: a2d28dd6-4c7c-4538-1339-08d5bde6ebe0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2018 00:16:23.6032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2d28dd6-4c7c-4538-1339-08d5bde6ebe0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3668 Subject: [dpdk-dev] [PATCH 4/4] net/qede: fix ucast filter routine return code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 00:16:25 -0000 From: Shahed Shaikh There is no need to return failure (-EEXIST) when the requested filter is already configured. Fixes: d6cb17535f88 ("net/qede: fix VLAN filters") Fixes: 77fac1b54fc9 ("net/qede: fix filtering code") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 14 +++++++------- drivers/net/qede/qede_fdir.c | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 3e1a62c..30b6519 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -857,10 +857,10 @@ static void qede_set_ucast_cmn_params(struct ecore_filter_ucast *ucast) ETHER_ADDR_LEN) == 0) && ucast->vni == tmp->vni && ucast->vlan == tmp->vlan) { - DP_ERR(edev, "Unicast MAC is already added" - " with vlan = %u, vni = %u\n", - ucast->vlan, ucast->vni); - return -EEXIST; + DP_INFO(edev, "Unicast MAC is already added" + " with vlan = %u, vni = %u\n", + ucast->vlan, ucast->vni); + return 0; } } u = rte_malloc(NULL, sizeof(struct qede_ucast_entry), @@ -1117,9 +1117,9 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev, SLIST_FOREACH(tmp, &qdev->vlan_list_head, list) { if (tmp->vid == vlan_id) { - DP_ERR(edev, "VLAN %u already configured\n", - vlan_id); - return -EEXIST; + DP_INFO(edev, "VLAN %u already configured\n", + vlan_id); + return 0; } } diff --git a/drivers/net/qede/qede_fdir.c b/drivers/net/qede/qede_fdir.c index da6364e..153ef96 100644 --- a/drivers/net/qede/qede_fdir.c +++ b/drivers/net/qede/qede_fdir.c @@ -141,8 +141,8 @@ void qede_fdir_dealloc_resc(struct rte_eth_dev *eth_dev) if (add) { SLIST_FOREACH(tmp, &qdev->fdir_info.fdir_list_head, list) { if (memcmp(tmp->mz->addr, pkt, pkt_len) == 0) { - DP_ERR(edev, "flowdir filter exist\n"); - rc = -EEXIST; + DP_INFO(edev, "flowdir filter exist\n"); + rc = 0; goto err2; } } -- 1.7.10.3