From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Cc: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
yskoh@mellanox.com
Subject: [dpdk-dev] [PATCH] net/mlx5: fix invalid count in xstats
Date: Sun, 20 May 2018 10:13:58 +0200 [thread overview]
Message-ID: <1526804038-27137-1-git-send-email-david.marchand@6wind.com> (raw)
With the commit af4f09f28294 ("net/mlx5: prefix all functions with mlx5"),
mlx5_xstats_get() is not compliant any longer with the api.
It always returns the caller max entries count while it should return how
many entries it wrote/wanted to write.
Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5")
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
drivers/net/mlx5/mlx5_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
index 8e427e7..875dd10 100644
--- a/drivers/net/mlx5/mlx5_stats.c
+++ b/drivers/net/mlx5/mlx5_stats.c
@@ -325,7 +325,7 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,
stats[i].value = (counters[i] - xstats_ctrl->base[i]);
}
}
- return n;
+ return xstats_n;
}
/**
--
2.7.4
next reply other threads:[~2018-05-20 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-20 8:13 David Marchand [this message]
2018-05-21 6:52 ` Nélio Laranjeiro
2018-05-21 10:25 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526804038-27137-1-git-send-email-david.marchand@6wind.com \
--to=david.marchand@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).