DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <rami.rosen@intel.com>
To: dev@dpdk.org
Cc: Rami Rosen <rami.rosen@intel.com>
Subject: [dpdk-dev] [PATCH] pci: remove unused function
Date: Sun, 20 May 2018 22:52:58 +0300	[thread overview]
Message-ID: <1526845978-19222-1-git-send-email-rami.rosen@intel.com> (raw)

The function rte_pci_detach() is private to PCI and is
not used anywhere in current code base. Remove dead code.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 drivers/bus/pci/pci_common.c | 36 ------------------------------------
 drivers/bus/pci/private.h    | 14 --------------
 2 files changed, 50 deletions(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 7215aae..e6d2c1c 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -292,42 +292,6 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
 	return -1;
 }
 
-/*
- * Detach device specified by its pci address.
- */
-int
-rte_pci_detach(const struct rte_pci_addr *addr)
-{
-	struct rte_pci_device *dev = NULL;
-	int ret = 0;
-
-	if (addr == NULL)
-		return -1;
-
-	FOREACH_DEVICE_ON_PCIBUS(dev) {
-		if (rte_pci_addr_cmp(&dev->addr, addr))
-			continue;
-
-		ret = rte_pci_detach_dev(dev);
-		if (ret < 0)
-			/* negative value is an error */
-			goto err_return;
-		if (ret > 0)
-			/* positive value means driver doesn't support it */
-			continue;
-
-		rte_pci_remove_device(dev);
-		free(dev);
-		return 0;
-	}
-	return -1;
-
-err_return:
-	RTE_LOG(WARNING, EAL, "Requested device " PCI_PRI_FMT
-			" cannot be used\n", dev->addr.domain, dev->addr.bus,
-			dev->addr.devid, dev->addr.function);
-	return -1;
-}
 
 /*
  * Scan the content of the PCI bus, and call the probe() function for
diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h
index 88fa587..63bd876 100644
--- a/drivers/bus/pci/private.h
+++ b/drivers/bus/pci/private.h
@@ -47,20 +47,6 @@
  */
 int rte_pci_probe_one(const struct rte_pci_addr *addr);
 
-/**
- * Close the single PCI device.
- *
- * Scan the content of the PCI bus, and find the pci device specified by pci
- * address, then call the remove() function for registered driver that has a
- * matching entry in its id_table for discovered device.
- *
- * @param addr
- *	The PCI Bus-Device-Function address to close.
- * @return
- *   - 0 on success.
- *   - Negative on error.
- */
-int rte_pci_detach(const struct rte_pci_addr *addr);
 
 /**
  * Find the name of a PCI device.
-- 
1.9.1

             reply	other threads:[~2018-05-20 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 19:52 Rami Rosen [this message]
2018-06-27 20:54 ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2018-05-17 23:44 Stephen Hemminger
2018-05-20 19:51 ` Rosen, Rami
2018-06-27 16:39 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526845978-19222-1-git-send-email-rami.rosen@intel.com \
    --to=rami.rosen@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).