From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg202.qq.com (smtpbg202.qq.com [184.105.206.29]) by dpdk.org (Postfix) with ESMTP id A8B051B05 for ; Mon, 21 May 2018 13:37:34 +0200 (CEST) X-QQ-mid: bizesmtp1t1526902648tc23g5qln Received: from air5005.lan (unknown [113.116.53.132]) by esmtp4.qq.com (ESMTP) with id ; Mon, 21 May 2018 19:37:28 +0800 (CST) X-QQ-SSF: 01100000002000F0F450000A0000000 X-QQ-FEAT: Q4mUGnBphwN4Ctmo9KGx5KjqBG45LRx0BkbHzBtyKTNv0iegUPu3zkWqhkQNP t76Kan+23DKRTN3tmhAd5DWVZB32aCUU5AWHo4vrGe7RXJ7Q7Pmta+jeX4R50QhzieddYtn Lcz5KTVGLFgX5inHmXAt526uUfGWkTOH6mzz1Eri/JnArW7LUG4kicnaDRYiKkzHU1kNq1t ERDjRxaCPCVk6mAMc8iYZOMdIFpjHL42d2+BVth5NVKVFtmBsLKXPCiugm6DUHEknsxmLkn 8AmbJ8Iy64bXIJHFv/cPPr2lqu/8a0Yy1+VHTXbDzYw4OPqIiB8EkFZDk= X-QQ-GoodBg: 0 From: yaochuhong To: shijith.thotton@cavium.com Cc: dev@dpdk.org, yaochuhong Date: Mon, 21 May 2018 19:37:26 +0800 Message-Id: <1526902646-115177-1-git-send-email-ych@panath.cn> X-Mailer: git-send-email 1.8.3.1 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:panath.cn:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 Subject: [dpdk-dev] [PATCH] net/liquidio:fix Unable to update lio_dev->linfo.link var When I was using VPP +dpdk-18.02+liqudio CN23xx, I encountered such a bug. When VPP called dpdk_device_start to initialize DPDK liqudio drive, I found that initialization failed. The reason for the failure is that VF MTU > PF MTU, but PF MTU has been modified to 9600 (> VF MTU). Finally, I am location that DPDK liqudio drive cannot get the correct PF driver to liqudio network card. It is due to the fact that when VPP calls dpdk_device_start to initialize DPDK liqudio drive, this time, lio_dev->linfo. Link var already exists in the old value, not empty. Cause lio_dev - > linfo. Link. Link_status64 != 0 statement is set up, and the link info is stopped directly to liqudio card, resulting in no get accurate pf mtu. I did a test model to reproduce the bug, which is to add rte_eth_dev_set_mtu(portid, vf_mtu) to the rte_eth_dev_start function when using dpdk-18.02+liqudio CN23xx+l2fwd. You need to make sure that 1500 < vf_mtu < pf_mtu will be available. At this time, you will have net_liovf[04:00.3]ERROR: lio_dev_mtu_set() VF MTU should be >= 68 and <= 1500. Such a mistake. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 11:37:35 -0000 Signed-off-by: yaochuhong --- drivers/net/liquidio/lio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 0e0b5d8..50743c7 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1405,6 +1405,9 @@ struct rte_lio_xstats_name_off { /* Configure RSS if device configured with multiple RX queues. */ lio_dev_mq_rx_configure(eth_dev); + /* Before update the link info, must set linfo.link.link_status64 to 0. */ + lio_dev->linfo.link.link_status64 = 0; + /* start polling for lsc */ ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, lio_sync_link_state_check, -- 1.8.3.1