DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/liquidio:Fix Unable to update lio_dev->linfo.link var
@ 2018-05-21 12:58 yaochuhong
  2018-05-22 13:49 ` Shijith Thotton
  0 siblings, 1 reply; 5+ messages in thread
From: yaochuhong @ 2018-05-21 12:58 UTC (permalink / raw)
  To: shijith.thotton; +Cc: dev, yaochuhong

When I was using VPP +dpdk-18.02+liqudio CN23xx, I encountered such a bug. \n
When VPP called dpdk_device_start to initialize DPDK liqudio drive, I found that initialization failed. \n
The reason for the failure is that VF MTU > PF MTU, but PF MTU has been modified to 9600 (> VF MTU). \n
Finally, I am location that DPDK liqudio drive cannot get the correct PF driver to liqudio network card. \n
It is due to the fact that when VPP calls dpdk_device_start to initialize DPDK liqudio drive,  \n
this time, lio_dev->linfo. Link var already exists in the old value, not empty. \n
Cause lio_dev - > linfo. Link. Link_status64 != 0 statement is set up,  \n
and the link info is stopped directly to liqudio card, resulting in no get accurate pf mtu. \n
I did a test model to reproduce the bug, which is to add rte_eth_dev_set_mtu(portid, vf_mtu)  \n
to the rte_eth_dev_start function when using dpdk-18.02+liqudio CN23xx+l2fwd. \n
You need to make sure that 1500 < vf_mtu < pf_mtu will be available.  \n
At this time, you will have net_liovf[04:00.3]ERROR: lio_dev_mtu_set() VF MTU should be >= 68 and <= 1500. Such a mistake. \n
ps:I am a novice git. Please understand the trouble caused by this.

Signed-off-by: yaochuhong <ych@panath.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 0e0b5d8..50743c7 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1405,6 +1405,9 @@ struct rte_lio_xstats_name_off {
 	/* Configure RSS if device configured with multiple RX queues. */
 	lio_dev_mq_rx_configure(eth_dev);
 
+	/* Before update the link info, must set linfo.link.link_status64 to 0. */
+	lio_dev->linfo.link.link_status64 = 0;
+
 	/* start polling for lsc */
 	ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
 				lio_sync_link_state_check,
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] net/liquidio:fix Unable to update lio_dev->linfo.link var
@ 2018-05-21 10:37 yaochuhong
  2018-05-21 11:04 ` Ferruh Yigit
  0 siblings, 1 reply; 5+ messages in thread
From: yaochuhong @ 2018-05-21 10:37 UTC (permalink / raw)
  To: shijith.thotton; +Cc: dev, yaochuhong

Signed-off-by: yaochuhong <ych@panath.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 0e0b5d8..ba39d20 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1405,6 +1405,9 @@ struct rte_lio_xstats_name_off {
 	/* Configure RSS if device configured with multiple RX queues. */
 	lio_dev_mq_rx_configure(eth_dev);
 
+	/* Before update the link info, must set linfo.link.link_status64 to 0. */
+	lio_dev->linfo.link.link_status64 = 0;
+    
 	/* start polling for lsc */
 	ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
 				lio_sync_link_state_check,
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-22 14:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 12:58 [dpdk-dev] [PATCH] net/liquidio:Fix Unable to update lio_dev->linfo.link var yaochuhong
2018-05-22 13:49 ` Shijith Thotton
2018-05-22 14:37   ` Yao chuhong
  -- strict thread matches above, loose matches on Subject: below --
2018-05-21 10:37 [dpdk-dev] [PATCH] net/liquidio:fix " yaochuhong
2018-05-21 11:04 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).