From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 52CED2E41; Tue, 22 May 2018 14:39:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Th5aDVhgGrTbwByn9tHMTEClzLuM0swhje2znu4iKs=; b=YiS4GCiE6LqF9AYBpjp8zLwrJ3yH+NGJssu443wj9EAGS5xbk5XSAj6zVs5b3w+GDpH8J3Nm8vjYfKs6ICFpazJadTpkwemfB+aZFbj1M8VIURdlzKkOBRzxd5rCRXzQl2oDf8RoRY9oQR1wEx1PpFeFXItm6SXRPIxiAtxM8ao= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0501MB2605.eurprd05.prod.outlook.com (2603:10a6:800:6a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Tue, 22 May 2018 12:39:03 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, Ophir Munk , stable@dpdk.org Date: Tue, 22 May 2018 12:38:47 +0000 Message-Id: <1526992727-10459-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.9.5 In-Reply-To: <1526992727-10459-1-git-send-email-matan@mellanox.com> References: <1526932084-1120-1-git-send-email-matan@mellanox.com> <1526992727-10459-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P189CA0030.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::43) To VI1PR0501MB2605.eurprd05.prod.outlook.com (2603:10a6:800:6a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2605; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2605; 3:WVNTgfRVyjsOoAcTz5T5mcEAiYAAbHLqh5jEb2xwRsIaBFTTmGAz9CSXiShsaD54kkAPqissuFj6OkQVXcrrYaCJQdkVsVUjKZ6S2+/k2wvAHAMMkGPxrqmhyopFf/vtDbQclSBbeI1g3kBi2KSztqHN43nPlag/idvK3yfn+afzGFfIUXXyv8nbC22iUBPjdJtQB5mkO0pqpXs6rtaLj6yL46lFHNyoWqJEbhAeQlkvM+96SpujxyBt4R03GRaU; 25:hg0GZw7AxpnozSltt03m2r+U/CguPgSu8gTTsG6EKVzhAJmGdYiCMK5dKreQ1mfqCnoW2jieHth7d25/CUtYGIHhqzqVsvc3jOzfHGANGUXjjz0xVoIJF5WUcydLXAIjxzNStWvbAulFoXJQlK+RSA2P3a/kGMUu8JQNWcqlEJHMGOKmdtYXLhE44ZyZzGyAD40t6/mZbgSQv8EdeOj2rKGsA1A+GIbZwDBVACYqaxK92J5IEOXF2/s88vh0Ac0N5lTtQy7QjCIo5fzx1V6Cz9DGkdx8aK22SQXxCMVzMK8bd9/mgBmFl/3BaidG2sxwya/P3tAr/YqSby/vQmCurQ==; 31:dW2TKfw3kbRbV681lq/8grzVjvhCmfpmHoKlJTn4GfRNRW+vO5awpvTWVI909id4NrtFJYLgfz69yYUxVtV3MagDY027KCedOaqOBFT3Iggj9I4L0NSaPlnOCojDi68i1FLba+j+vmiRfbIDORpX06RuLUp0WWjNZO/IL6005odYQ+C14xio8pOi1oOiaX+kZWGIAcY/tREU1VJUsujotGSbk8VWwZCKB/YTgG71iD4= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2605: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2605; 20:2TgG8z3DCSSo/4bdm40LZ1ta5Dw9QRgg+Bs43bB1hAQKp43iduJ0UpkznD+PAiovN2a1H5RPS7+1YSrq5GtISUBv/mFO14tE3CdtfMYhBSExYB3Y83X9bAxSF93ncV9zwqwU4VcEsGzH+Mi0yWYd+Ta4ezZ2YrRUI3fJNaoVetSKhAAow/I7hAEHnwU9UEO5zNfm8hynA/NQKUpSBQgHApFWxm6MloDmeyiUJ7le+rTDcxLn8WnVLPwVrFiT5Kp07EQuzYi3JXqWssquwaO2iYHS5uO77KszNEuuZ7OGaxUrbZUeei/KaNkkAQ7axv4QaXCnfZkIx4Dt+vJnkySd7lFZ5H4tOUaRoKIm/uc+ny6I0uFcOsML2qrdAQLPRsN/Hw2G+ct2FmgsIT3XwGGs2gj2cu2Kd3Q1o+zRTPsJOEyrmbS2BZeCqt+Q+G56DO/i48ehdcXKIli1RjOGgmbP/zNNbxz1iLyVU/mPrB00JaxmJi004WquIlBL5Upz1M8T; 4:EceoLzVvpuWyXye0apWHjhCsMeDIZ4NMbqrihfajAfmtXu7z0yXziZwbgPgFku0MibgAMrW8VP6d1lgGcgqa5XY8+wYy2Q9CVwdlt4NycAARdGkBPU+p99tZvNBnI7Hxc0Enp2u/ho9mxHyohDLiHQXTFG/CvF3Bfq1FBq5HugZLqF1UldXmkURNAhUFOdEKfl3sC5xlh3CitBP7QONx77xPiuW812wEQfhzJ/CDkpJRi4dCRJD3CNxTSHLu3fwHriUe1I1566a5X+Tcg7dqmw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2605; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2605; X-Forefront-PRVS: 0680FADD48 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(396003)(366004)(39860400002)(346002)(199004)(189003)(2616005)(33026002)(316002)(68736007)(69596002)(50466002)(106356001)(48376002)(6916009)(105586002)(2906002)(16586007)(36756003)(956004)(476003)(76176011)(6666003)(5660300001)(52116002)(7696005)(486006)(51416003)(478600001)(66066001)(81166006)(97736004)(55016002)(81156014)(186003)(4326008)(6116002)(3846002)(25786009)(386003)(7736002)(8936002)(53936002)(47776003)(50226002)(16526019)(305945005)(11346002)(86362001)(446003)(21086003)(8676002)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2605; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2605; 23:7M1g1r39exwDfLc4CqL0Bol70detaa+xXivEx6A?= =?us-ascii?Q?lu0MwDwOaAeepkILJ2ngi4ofpbpABOdLe2o8mhqa8li3vigmLk780tJKbO1s?= =?us-ascii?Q?we6G3EVj4JKJnNdXCN4xtCdAG5wxK5OwYeDtO/EfHyBo+RrksEWdE+ZkelVk?= =?us-ascii?Q?xJ2i5DoT2TuaFlIaTII3+exSz0WejcX6j/EuHEDWFvpP5Supl3jrDcqND2Ba?= =?us-ascii?Q?MWzV5nvr+aID5dzWr/OR2qJFfU2Oi+ZdRSw/3c9ZmkxeQ6t1uHxQ6Q4zNHLk?= =?us-ascii?Q?BmZGuJRqxSehRx9G9S6PEj12TcQp25QV1Oc4p/XEGHMo60uZC0oQkJqh87nL?= =?us-ascii?Q?7HcQXfHnA9iBb7JNlLklfFFsNbf+jAY9qPhZIuvXLbkbVOuENKD+2tXlB8Bl?= =?us-ascii?Q?VVlO+iP1Ra6rRhqpL347Bs1xAi+dzXhMzOIfOez/7Bdw/Hf2DyOSvd9m1eBQ?= =?us-ascii?Q?mVIySGn5raO31mbGIF62UyKFVrRpMTEEx3dZUML3FLZ59R6euPGkmouXaP22?= =?us-ascii?Q?p+Le2y79XK9Bfv4HHdvJNdn615HxvbR0FxhturAxtdSHzBgHvWEZCPpJZLet?= =?us-ascii?Q?y2dSjEoPw3HHG9QUh1OUnlqu2dqikuidSl0diAwr15vVLm5x6lxUR5eBHdM6?= =?us-ascii?Q?v5Q5jZsmiQghpNO7RZ9SDYOuIF0MBH3MTC0reIli0FeoWNDbX14bZ5WYk8x/?= =?us-ascii?Q?N1yx8oHvvhxLNI3IEc2mIBxv8ArrGzuvJpT/nZYb1tZJxHer/8DJfYw5/+5R?= =?us-ascii?Q?k/cTsNWRMwsCCbGbXAdapjdnQbBofbbZLL3QZmE+byg4+GzzLYpOASEG3hwW?= =?us-ascii?Q?fYU7A3g4bHQDPZ32Z7DODQL0xqwyMjij9XN3Exb7qYt3dBRrlvwHYhqs9I6p?= =?us-ascii?Q?92Iqf94TPShYOIxdhN9rHSAlA8jm70v3kstpw6lfg2GukrlJVIf3nLsdDfu3?= =?us-ascii?Q?RtdAAobDduGR8hApgGYdA5DbE4mX468bs/f3vxMRNU8Iidl84Ky+4iv2jL44?= =?us-ascii?Q?KOMsAJKGZAxS3bLZKjzzfESFH3hkvn0LNhSXc9yQ/WGJW7RbAu+NjdFdolTZ?= =?us-ascii?Q?R6/j/sR5WtAagTFi8AYXgTNMcXoItomvvOJ1Yh/EIEBEtJmS4OO3BTj/2hg8?= =?us-ascii?Q?2J8irFH/zKfu7SweeZXeKhW461+dmzZGwzF+sH0goZ6fm9q94fjGgn5zJ/7D?= =?us-ascii?Q?k0LW5k+QkzmYRP148thWN1v7sR2KNGWIUq9YNvAEN5N10hQQ2hGUOD20FJg?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: de98bgt7aXLDF3ATd8rDh5hHZrQZwQvm4Dvs8Fi4FfYTs/1KA7XqUU3q6Z4S+g7Q7m2h/mILAAmGfRl4Poa7GQkJMLYR9zKqU8MT7EbFA51MJCDBOANG8d42OIKgTlSdkHiM8F4bqnP8HR41+AEQeS9o6YfBF8rTd5w9/SRyKPjWTdsfG9MqkgRo6/5bjbrG X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2605; 6:2xGfcLjetEGAy3Ip5NP5uQhLr5S6sUQhAudGR8GEMOCxE061GoyVDhqMUdUYbFx9ExijqrfLuqZjwvEGhNzbI6DrHQhem6PdCGqyo15ibFmZ0sEYb0/6X3WULPxYDi0Me9P0ksQJa3blvU7GIi4QZHjUPFCJoWrJxNkSGqQYbMqPtHIiQokqtRdRjjPJH2KrHNjE6eX+cfw2xmPFEe+WfSdI0Ogxi8RRa3nUunAxD7KB9gVo04q8VDQDyCt7HvMScm8lc3lvW6l/zhW+JagSuWegGRYHXwZv4GUbBaOp8lV8XPovASiGGFBWHbtYM+TRC4Yws0DuRsnwHXgRq+BDjJ7wfrOF4Bbgj1Qm0xetRSIE8EYeetGeX4XWDAUS+NIZDvsobCjeRigl+H4uHJTpHObJUM4IZ8TEhMXIvDUmaeD8iAdApkQCDUL3jYdq6ZUetc27n5PPN/cZdUNDbcNm/A==; 5:rSjWG8G3SxJ/tCTFAdJUN3NinC+UykJOFAcx/LN4d3p5M0bybknx7g53Zk2kCsF3r4yG4gcdtxysWzHsSlIddm4j5uP1wi4L+f4j4WZ5UKdEpT/a9firXFGyYXJ5awY5WZBZaL6kewE2JR5I7H4CIHa3MiNKDGhTr8m6gZjWVT4=; 24:n3LIHg96knwag6554qIgTknxfGwf1Q/vKgqSh9q46ZpvgibL04Qbdnzqz3NBMahPbkY0OYkXML9S1qqbMJkiN/RrRbm0RIGemrIi2+9828Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2605; 7:dmhOE+waM/9eDvqaEQJpqAn9sESmN+939lIK7iKugZ6OtUfrQqf60ayfK2XDyFCzEya+XJta6qUali1Cv3eVqjuqSu293i/rcl8/WRxlHQAxqVePxxRsbYbLPahcNI3QbDpY0rwBP1AcsHSFwCRWh6zrbHliAccoPbgP7zJlYKqKYiYgsr+NC7cQbzDchY2iORc2jilw8EY6ZMvN++W2mkFHgh9DiXkM28yjH4OX1JfPrsxsLbUaOY9/XdsykBoc X-MS-Office365-Filtering-Correlation-Id: 8c01df60-6a6e-4e44-4246-08d5bfe100a9 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2018 12:39:03.6182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c01df60-6a6e-4e44-4246-08d5bfe100a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2605 Subject: [dpdk-dev] [PATCH v3 2/2] net/failsafe: fix duplicate event registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 12:39:05 -0000 When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index e0570b6..24e91c9 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -138,7 +138,7 @@ fs_unlock(dev, 0); return ret; } - if (rmv_interrupt) { + if (rmv_interrupt && sdev->rmv_callback == 0) { ret = rte_eth_dev_callback_register(PORT_ID(sdev), RTE_ETH_EVENT_INTR_RMV, failsafe_eth_rmv_event_callback, @@ -150,7 +150,7 @@ sdev->rmv_callback = 1; } dev->data->dev_conf.intr_conf.rmv = 0; - if (lsc_interrupt) { + if (lsc_interrupt && sdev->lsc_callback == 0) { ret = rte_eth_dev_callback_register(PORT_ID(sdev), RTE_ETH_EVENT_INTR_LSC, failsafe_eth_lsc_event_callback, -- 1.9.5