From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by dpdk.org (Postfix) with ESMTP id A60FE2BBD for ; Tue, 22 May 2018 16:33:37 +0200 (CEST) X-QQ-mid: bizesmtp12t1526999612tdgnoura Received: from air5005.lan (unknown [113.116.53.132]) by esmtp6.qq.com (ESMTP) with id ; Tue, 22 May 2018 22:33:31 +0800 (CST) X-QQ-SSF: 01100000002000F0F550B00A0000000 X-QQ-FEAT: M1J1ppP5VJsEza1thFIgvAVtoJkhpreLDBpqaoblEtfPaDIG2x2I2J3EX7r8V t/c7nbEYVpGyUItOUxj8dXQGqslOzIcv6JMSNS+6/ljx86pSi6Z6jU9N+0XZQrHUT4spFxi iG5ibl9e1kWl1C32OIb6ARXzF7NtyNzSXwdy3MjQ0oJpjtN2tjt4uUydT6b2sRoif1/wwk6 PrtH4k3cuy2qaS05RjO2QrUchzc6e7BzKUGBX4vR9BAeXelEJu5Gu5jK2FjJLSHyFy9L2dt Cf8K1w9j1fFe0W8oIASGp0K3rmv07MIamcQk4upN+/D9vM7EGWoovSkmo= X-QQ-GoodBg: 0 From: chuhong yao To: shijith.thotton@cavium.com Cc: dev@dpdk.org, chuhong yao Date: Tue, 22 May 2018 22:33:29 +0800 Message-Id: <1526999609-116071-1-git-send-email-ych@panath.cn> X-Mailer: git-send-email 1.8.3.1 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:panath.cn:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 Subject: [dpdk-dev] [PATCH v2] net/liquidio fixes unable to update linfo var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 14:33:42 -0000 When I was using VPP +dpdk-18.02+liqudio CN23xx, I encountered such a bug. When VPP called dpdk_device_start to initialize DPDK liqudio drive, I found that initialization failed. The reason for the failure is that VF MTU > PF MTU, but PF MTU has been modified to 9600 (> VF MTU). Finally, I am location that DPDK liqudio drive cannot get the correct PF driver to liqudio network card. It is due to the fact that when VPP calls dpdk_device_start to initialize DPDK liqudio drive,this time, lio_dev->linfo.Link var already exists in the old value, not empty. Cause lio_dev->linfo.Link. Link_status64 != 0 statement is set up, and the link info is stopped directly to liqudio card, resulting in no get accurate pf mtu. I did a test model to reproduce the bug, which is to add rte_eth_dev_set_mtu(portid, vf_mtu) to the rte_eth_dev_start function when using dpdk-18.02+liqudio CN23xx+l2fwd. You need to make sure that 1500 < vf_mtu < pf_mtu will be available. At this time, you will have net_liovf[04:00.3]ERROR: lio_dev_mtu_set() VF MTU should be >= 68 and <= 1500. Such a mistake. Signed-off-by: chuhong yao --- drivers/net/liquidio/lio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 0e0b5d8..50743c7 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1405,6 +1405,9 @@ struct rte_lio_xstats_name_off { /* Configure RSS if device configured with multiple RX queues. */ lio_dev_mq_rx_configure(eth_dev); + /* Before update the link info, must set linfo.link.link_status64 to 0. */ + lio_dev->linfo.link.link_status64 = 0; + /* start polling for lsc */ ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, lio_sync_link_state_check, -- 1.8.3.1