From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0052.outbound.protection.outlook.com [104.47.41.52]) by dpdk.org (Postfix) with ESMTP id EBAB12C8; Wed, 23 May 2018 20:49:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Va19HjYnFWOtw5/iIAkghN4+KzqTMlWYrtiMvKsyWIc=; b=Vcr6IVYnD3RLE8SIoYPZvHOhtB3tBYuDDAXr0VDyzVF6Wu5bEwrJFztpBb8A+mvvGwSyYDzQXWFc4fEZavScW0BYUtaIaGuggxlRVAkCYLVUIKG6gxccjOW188p9u+cmRvROctYPfukIphe+43B3FJoaKa4I7DmkFd1BGRWRZZg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by SN4PR0701MB3679.namprd07.prod.outlook.com (2603:10b6:803:4d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Wed, 23 May 2018 18:49:00 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Wed, 23 May 2018 11:48:53 -0700 Message-Id: <1527101333-16888-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR01CA0024.prod.exchangelabs.com (2603:10b6:a02:80::37) To SN4PR0701MB3679.namprd07.prod.outlook.com (2603:10b6:803:4d::21) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN4PR0701MB3679; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3679; 3:qovICd10tbyHE7ZEVLzedqGLBy2kilBDkuCYsz+nEb/n3AJIurhQjdhLD3GUcVMkRX7PCQOm0uAYTxTpGedJVcl71v75vJo565pbYmxrJkELOCS5sj6gI5Z9oyctdl67YanSDrDHnZjkjZnmf3I8uXQJ5aRs/FZAZYGscEYgceWswd4RlH0qQC+kDSP/0tzf+Lb2Hc/u8ixazFmkudcBbFWktpqmxf/UGCZoo25TmG5qQNdHInUR0Ht66Hx+AHI/; 25:z9kq2IR2tm5clqDYHNgtcRSXKQTPBZoiWVTevjl6NZKYqRdcT6dMQpHK3Jl9Di15TdxhZdZJ00U2++wmwjm7Z3Vj4kpSlrrImIC7Uf8zafDTNhwGXa/jFpkLo60AdDFHyy2GIncvfEHZhaP0tMWAadlsfx7YDKE5Jlqjow4KzOI0LyKCfzXRMz/ZVy0uEaH1xhEsD6LCyoLrYgTK9QoSxm9bFCLM+Are7NaoqxDyHb/cZGu0S5zPVoxOSFVLQBkNGerhGAvyutdn3Z7Vz9apvyS8L++P4zIAP8yObpD9ZEt4Bs3AvyvhJAC6Z2lHvs1NBVAUAdhVPFlYHsAKH3hgJQ==; 31:BBSxAZ7jTfLC7Yhv5sOYtyI53QSOuXzTJr0Z97lLY9yhGBtJyNXTy/ScUt4VRUfWxQXUY4hQh4PpcLtbEDk52yUkI0iGsu1e35jsd4gUTw+ZOtqfkSjfHyxfi5n2T/uVxzXOUM6r4BD22ESrK1TrOLqTJXoSN0IrEmXXxfQTvcXIJWr74R86EF/L5gIAzOCTshkmMnVBa5sGSE/cZPrKzPtzs0MIuIBIj9fJpCSl8UA= X-MS-TrafficTypeDiagnostic: SN4PR0701MB3679: X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3679; 20:wxg/gMBcnwCvTBw8aW35AjGfutm82iyIIMLehFi0vRLRwscHTgYOzosiQBbzlTKfUfnx+qz4hN5mVdddtOEhk7o4d5IYqVOqJbnA1Q1ShoozII/X0JkaE4q/EAbwr/jqzhPaFLGZBRokYSAIk5AmA1TTghpRaKR+vw/uQJYyWMRliqsA408/3psc9h0fRo1Pvr+igRCTqQNYVEKF7nD8XDod69d4vw812zxOKAlMSgLEnxqkx2pE7hTiPWk1N4gSL8rKwikRTcF/4hW/d0KEa9uipC+6oABkiQiBtQjuZiCPvJlaY6PO3UCefgpw19nPhnon05V9xvaH+xBN7yj+HJ7A8nAGJucWWCRRJ3mYppyM5v1GgSRFP65XcKq0TpVcaghqUYzD73FTSXd+G9QQfaswHmGzSi9TEORc9/51zvQwGq6KDjY1nid1/jSeBHjfAn6ZxqwslEHHPn9tbpRep801F49OC/Z/db9Aeu0aiVy5uPOmUDMfsq1GpzjadeNA; 4:pngizeE/nkqUGQrWPNE4j8H9GUxaRqfnSC6lAg9jvL53LiT0c1rrdUq1qxbIpDKkCWZzOEF5OxCvZHLm+Fc/z/cqwSGuQrGY7Y4drAPA9qM82ZdjMoh64Y7DlCp7FrvNr9ilkplQuuFaZ4oEMu6qeWwBfKGKJqNm6TT0FBMzZL6e/ptY69NtrDIAAitusmtg7ycZCw5Y76LknsiYgMgLoxekW1/e7a1ueoA1Tx/4QGdQDB0vANkTAbIVm7j5lKhiccq0u65avw5iisT9bpLfeA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SN4PR0701MB3679; BCL:0; PCL:0; RULEID:; SRVR:SN4PR0701MB3679; X-Forefront-PRVS: 06818431B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39860400002)(366004)(39380400002)(346002)(199004)(189003)(68736007)(16586007)(5660300001)(86362001)(575784001)(105586002)(97736004)(36756003)(106356001)(478600001)(52116002)(7696005)(51416003)(47776003)(16526019)(21086003)(2906002)(186003)(44832011)(26005)(66066001)(55016002)(8936002)(6916009)(53936002)(6666003)(8676002)(4720700003)(386003)(486006)(59450400001)(316002)(2616005)(956004)(50466002)(69596002)(4326008)(48376002)(476003)(7736002)(72206003)(25786009)(81166006)(6116002)(3846002)(2361001)(81156014)(1857600001)(2351001)(305945005)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3679; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN4PR0701MB3679; 23:Ue7O8Iqa0+/iJZieHpVLZBmwNbkv1miLFWVbaLh?= =?us-ascii?Q?9D3/BgcAzpzjjI63TRr7Z9z8NkIvqR+fx+Qjw9k/RfB35QgaXWSnI/P/o6lv?= =?us-ascii?Q?iuWm1iNehYAKa7nIs7JyOkOq2g2fm0F9U9lPSgN/gs5MY4kJ8BG7mydpDg7g?= =?us-ascii?Q?H+ZR0qx4P1wZeKEVEJyVi8z2v64ePa2WkvSECDk5KJR1Wm3Gq2JxT66P4IEf?= =?us-ascii?Q?VxQ0frWAyXsBDBYGIumjzJBRsAssqRXWZ2w9VnT6b/R75GLWFDBWAEJlxFt2?= =?us-ascii?Q?Ao27zWAEryBEcS4sPcNCLQPhIrj8gyd6PdP/s+cdl562aTz4I4FbrgL/olKI?= =?us-ascii?Q?/nYsd1d6c93Jzl2sgFhh/H8jtoKNBTkufgM6P0TOebpXIc7Yfp6hLQX44RyF?= =?us-ascii?Q?Ztt9fSBRVALQAwxcn98qf/jBaIyOP0YuI/jKYTD7XbLumN+gvDUOmVhX+J75?= =?us-ascii?Q?Y5Fr7iYxHexKN5qdk0gda1z83hPhFgY8r4M1u8OvXmTyR/dtoXa3IJPbeEOw?= =?us-ascii?Q?bpA7AnBdMhlUNQILSEaCCyk6cdQjgWNJOZ5NZh5HCtqCyF317juChd1ljhrJ?= =?us-ascii?Q?SMybrYAgxM/2PWaxAv+35wagECB6bfFNd7jdpM975RK5JA7OpKSUbTjhFFJW?= =?us-ascii?Q?unZR7r1irT5NkX71v2e58kS4l7fbxtwD2HpfHfsnimrAjkPVR6hw+dzUz3lR?= =?us-ascii?Q?qoysShjIdeMWtTi4Gky+/P2Q2ZlqlZ3UFYrjI8YoSpNKP7VigrkXwf7TJYPw?= =?us-ascii?Q?zU3lw4jtTjJIhWFemkJNjYZ+B1EO91TvxQhMlxzOWYcIFTI/bUJvav4nUQqo?= =?us-ascii?Q?aM5fsKBwINwMzk3qM0b7kh+H2kTe1bc/i0/s/PaWjDpm3kJ8dep/fksSgZId?= =?us-ascii?Q?VxL3QGQ4DlMMxf+JRIBJANfGHu2Ne1EPtEOg4FXLhQWidHalkNqVDi8ipObM?= =?us-ascii?Q?5O3uF6qnF6enRoLUeA0O+UqCucXJIUSKpxtGEsp5vMzAbouG2Oj8Uc1c4i1q?= =?us-ascii?Q?SHUtdbPk9aGUsDkbD5DcRlAj0hp6qA4dmOWJJaPmGX0Qfgh9lZPVOeM9REFY?= =?us-ascii?Q?Pbt7Zbx/58bbf5NJ92359CbvMm4hhGT1tFSsVxtDflfw3Lo7YzrJo/i+Dpmn?= =?us-ascii?Q?tftcP87WlKasLV1bWmwTkh3kzP3GHv75nX6/XkEBqWKdHp8u6iscXuatUYen?= =?us-ascii?Q?RThA8eznZMWq9F9qL40olXkZzAVRYprPCC5oBV8F3J92qaItJsZLDeDoWjii?= =?us-ascii?Q?1u8sgP61KrwaTUxko8h8vxFcGnoLcoqR/sNHXtVyOny++SdkSQy7iYx6Ynbk?= =?us-ascii?Q?Kit4IqZB3Ohsq6tAsD7E19SlO3wACPDsxMqC/Pl7BNyMe?= X-Microsoft-Antispam-Message-Info: ak7qBUCWxXakU1qyNqC/fCcSc9EyMHFdGyrxqcV87ykUJUwFNEZMCU0LOjKXag06cYJ23MrGJL2FUW6bc0necyvb84gpjaUDkJpCwABbreowDo15hXfYRFvSjd/R2pevLpHWfEh88GWArl4IUVgLZvxiO+pHO845NXf2jD0jfEfqy/anvspdXX/CnzCDSxKV X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3679; 6:3W+QNN/IozyTJ8SiUjshAjDQIg+ezhcv/HMLGlOj5HB0nHNJw1jyT4n3ooTBByzo8FjhA43otBng2Ml03kfCyn0ylm0gC+AUE238aRxRYwwscDHaHHU5czHjEDIj1+cz189drGQPB2gtp6kfAFfL/WVLDd5iUIML2YWg89Vd2jOk9o696w6tBmJtZNjfVKGA2oT+wX628i/J1y87LEYpgIQ//4udRDQ1LQuPLq1yQr/mCSXOiykWPjVVZkatQdE6P/zsg6VggBJw771SH0fgwKH5SMW/BMDBCpP4I5dkiKLCTSN4qRwRKkgpquMY00Brib+uu0ZyFxTkDDcvXFrpZ1TaW3KpPWGeNbFqWD07YuPd6Pcj5YgV+IfjSvfVBT/xC979W7yQJPh3pSLRaFcdf9wr+/s6x6k9hkc4lR+ELWhz0xdv92V/Pi7ZUYHszP46VeWDZ8x4PRhzwOrsBtKY5g==; 5:Ay1YyVkMO08rGT0X9gz5KUcfO3+0DChIHFwBot5mTSbQ9FSELWHiUvXsfnVuC78X9QW8r4fU1W7UErSrYYHbiUiJyx4uEFO/f4Zd884ynHoCn1h6f4N0Ood+/lOc4cdRvpEPDWXcDkU0KYYk45RozQZq8sfuS4xEpM40TIPFs30=; 24:FYZeqUzXBz8X0Ga8nBXuTQq8Ib8M36R7AK2qn90Rwuebyce1DNkrrJsp3hkCHTf2A6rJb2E7xWpXHhK92IvaRmVHw7nBIFeSvSMsfJNTc2g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3679; 7:M638RqwxLXcEheWz8Lcv9+K2+dkkRRy8Bs0ypDbV4sK84Wj4l7XrI/Li/+HPwMu9J/jbHIvT7lcjvYGv6OsGODcNfQPdFSAbaWto1oStjAEMO91mszTi2ZMtRy5fh73Rg1rGRFCmuWjG6gj7T0kQUPOpvEdyAAsDzpjWaOlAIUA5mfpAJNkLPH9qqgjGr5EbBf4+zDI4jsfjw48++JqMl2Uj7zr2KKM9er2U6dwzcQRZo1QTsROgO6xlYgKMPtB+ X-MS-Office365-Filtering-Correlation-Id: f0e9013a-b27d-434e-63a5-08d5c0ddd983 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2018 18:49:00.8927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0e9013a-b27d-434e-63a5-08d5c0ddd983 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0701MB3679 Subject: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 18:49:03 -0000 From: Shahed Shaikh In 100G mode, we poll firmware slow path completion for every 1 second, which is not enough and may result in completion timeout if driver misses that window. Patch "eal: set affinity for control threads" exposed this issue since alarm callback runs in control thread context. Fix this issue by update polling period to 100ms. Fixes: d651ee4919cd ("eal: set affinity for control threads") Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 30b6519..338ddc1 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -16,7 +16,7 @@ int qede_logtype_driver; static const struct qed_eth_ops *qed_ops; -static int64_t timer_period = 1; +#define QEDE_SP_TIMER_PERIOD 10000 /* 100ms */ /* VXLAN tunnel classification mapping */ const struct _qede_udp_tunn_types { @@ -1698,7 +1698,7 @@ static void qede_poll_sp_sb_cb(void *param) qede_interrupt_action(ECORE_LEADING_HWFN(edev)); qede_interrupt_action(&edev->hwfns[1]); - rc = rte_eal_alarm_set(timer_period * US_PER_S, + rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD, qede_poll_sp_sb_cb, (void *)eth_dev); if (rc != 0) { @@ -3093,7 +3093,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) * interrupt vector but we need one for each engine. */ if (ECORE_IS_CMT(edev) && IS_PF(edev)) { - rc = rte_eal_alarm_set(timer_period * US_PER_S, + rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD, qede_poll_sp_sb_cb, (void *)eth_dev); if (rc != 0) { -- 1.7.10.3