[dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

[dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

[David Marchand]

Rather than copy the log message, we can use a precision in the format
string given to syslog.

Fixes: af75078fece3 ("first public release")
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_eal/linuxapp/eal/eal_log.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_log.c b/lib/librte_eal/linuxapp/eal/eal_log.c
index ff14588..9d02ddd 100644
--- a/lib/librte_eal/linuxapp/eal/eal_log.c
+++ b/lib/librte_eal/linuxapp/eal/eal_log.c
@@ -25,25 +25,14 @@
 static ssize_t
 console_log_write(__attribute__((unused)) void *c, const char *buf, size_t size)
 {
-	char copybuf[BUFSIZ + 1];
 	ssize_t ret;
-	uint32_t loglevel;
 
 	/* write on stdout */
 	ret = fwrite(buf, 1, size, stdout);
 	fflush(stdout);
 
-	/* truncate message if too big (should not happen) */
-	if (size > BUFSIZ)
-		size = BUFSIZ;
-
 	/* Syslog error levels are from 0 to 7, so subtract 1 to convert */
-	loglevel = rte_log_cur_msg_loglevel() - 1;
-	memcpy(copybuf, buf, size);
-	copybuf[size] = '\0';
-
-	/* write on syslog too */
-	syslog(loglevel, "%s", copybuf);
+	syslog(rte_log_cur_msg_loglevel() - 1, "%.*s", (int)size, buf);
 
 	return ret;
 }
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] cmdline: remove useless intermediate buffer

[David Marchand]

Rather than copy the string, we can use a precision in the format string
given to printf.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_cmdline/cmdline_parse.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c
index 961f9be..9666e90 100644
--- a/lib/librte_cmdline/cmdline_parse.c
+++ b/lib/librte_cmdline/cmdline_parse.c
@@ -208,9 +208,6 @@ cmdline_parse(struct cmdline *cl, const char * buf)
 	int err = CMDLINE_PARSE_NOMATCH;
 	int tok;
 	cmdline_parse_ctx_t *ctx;
-#ifdef RTE_LIBRTE_CMDLINE_DEBUG
-	char debug_buf[BUFSIZ];
-#endif
 	char *result_buf = result.buf;
 
 	if (!cl || !buf)
@@ -250,10 +247,8 @@ cmdline_parse(struct cmdline *cl, const char * buf)
 		return linelen;
 	}
 
-#ifdef RTE_LIBRTE_CMDLINE_DEBUG
-	strlcpy(debug_buf, buf, (linelen > 64 ? 64 : linelen));
-	debug_printf("Parse line : len=%d, <%s>\n", linelen, debug_buf);
-#endif
+	debug_printf("Parse line : len=%d, <%.*s>\n",
+		     linelen, linelen > 64 ? 64 : linelen, buf);
 
 	/* parse it !! */
 	inst = ctx[inst_num];
-- 
2.7.4

Re: [dpdk-dev] [PATCH 2/2] cmdline: remove useless intermediate buffer

[Olivier Matz]

On Thu, May 31, 2018 at 10:03:28AM +0200, David Marchand wrote:
> Rather than copy the string, we can use a precision in the format string
> given to printf.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

[Olivier Matz]

On Thu, May 31, 2018 at 10:03:27AM +0200, David Marchand wrote:
> Rather than copy the log message, we can use a precision in the format
> string given to syslog.
> 
> Fixes: af75078fece3 ("first public release")
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

[Thomas Monjalon]

25/06/2018 16:42, Olivier Matz:
> On Thu, May 31, 2018 at 10:03:27AM +0200, David Marchand wrote:
> > Rather than copy the log message, we can use a precision in the format
> > string given to syslog.
> > 
> > Fixes: af75078fece3 ("first public release")

I remove the Fixes: line because we don't need to backport
this patch. I consider it is not a fix.

> > Signed-off-by: David Marchand <david.marchand@6wind.com>
> 
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

[David Marchand]

On Wed, Jun 27, 2018 at 6:19 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 25/06/2018 16:42, Olivier Matz:
>> On Thu, May 31, 2018 at 10:03:27AM +0200, David Marchand wrote:
>> > Rather than copy the log message, we can use a precision in the format
>> > string given to syslog.
>> >
>> > Fixes: af75078fece3 ("first public release")
>
> I remove the Fixes: line because we don't need to backport
> this patch. I consider it is not a fix.

Yes, clearly, no need for backport.
Thanks.

-- 
David Marchand