DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Christensen <drc@linux.vnet.ibm.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats
Date: Mon, 5 Oct 2020 10:43:53 -0700
Message-ID: <1528760c-72ad-829b-ac43-7182ac848da4@linux.vnet.ibm.com> (raw)
In-Reply-To: <6f325c96-beca-fe9c-0622-90a8a6522e0c@redhat.com>



On 9/23/20 1:07 AM, Maxime Coquelin wrote:
> Hi David,
> 
> Could you please post a v2 with Chenbo's comments taken into account?

Sorry, been out of the office for a bit but now working through my 
backlog. I did make the change but discovered there were additional 
dependencies between stats and xstats that weren't addressed in the v1 
patch, specifically per queue packet/byte counters:

$ diff before.txt after.txt:
< tx_good_packets: 24769339
---
 > tx_good_packets: 0
6c6
< tx_good_bytes: 1501282012967
---
 > tx_good_bytes: 0
14,15c14,15
< tx_q0packets: 24769339
< tx_q0bytes: 1501282012967
---
 > tx_q0packets: 0
 > tx_q0bytes: 0
51c51
< tx_good_packets: 2653125
---
 > tx_good_packets: 0
53c53
< tx_good_bytes: 167404266
---
 > tx_good_bytes: 0
61,62c61,62
< tx_q0packets: 2653125
< tx_q0bytes: 167404266
---
 > tx_q0packets: 0
 > tx_q0bytes: 0

I'm looking at how to address these as well for a v2 patch soon.

Dave

  reply	other threads:[~2020-10-05 17:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 17:03 David Christensen
2020-09-11  7:44 ` Xia, Chenbo
2020-09-23  8:07   ` Maxime Coquelin
2020-10-05 17:43     ` David Christensen [this message]
2020-10-06  7:32       ` Maxime Coquelin
2020-10-06 21:23 ` [dpdk-dev] [PATCH v2] " David Christensen
2020-10-09  3:13   ` Xia, Chenbo
2020-10-15 17:49   ` [dpdk-dev] [PATCH v3] " David Christensen
2020-10-16  1:38     ` Xia, Chenbo
2020-10-23 10:54     ` Maxime Coquelin
2020-10-23 11:22     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528760c-72ad-829b-ac43-7182ac848da4@linux.vnet.ibm.com \
    --to=drc@linux.vnet.ibm.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git