From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, stable@dpdk.org, Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel id format error for FDIR
Date: Wed, 13 Jun 2018 16:11:22 +0800 [thread overview]
Message-ID: <1528877482-5029-1-git-send-email-wei.zhao1@intel.com> (raw)
In-Reply-To: <1528189935-34943-4-git-send-email-wei.zhao1@intel.com>
In cloud mode for FDIR, tunnel id should be set as protocol
request, the lower 8 bits should be set as reserved.
Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550")
Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-fix tni bit format error in v1.
---
drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
drivers/net/ixgbe/ixgbe_flow.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index d5e5179..67ab627 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -774,7 +774,7 @@ ixgbe_fdir_filter_to_atr_input(const struct rte_eth_fdir_filter *fdir_filter,
input->formatted.tunnel_type =
fdir_filter->input.flow.tunnel_flow.tunnel_type;
input->formatted.tni_vni =
- fdir_filter->input.flow.tunnel_flow.tunnel_id;
+ fdir_filter->input.flow.tunnel_flow.tunnel_id >> 8;
}
return 0;
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index eb0644c..f47f125 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2487,10 +2487,8 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
rule->b_spec = TRUE;
vxlan_spec = item->spec;
rte_memcpy(((uint8_t *)
- &rule->ixgbe_fdir.formatted.tni_vni + 1),
+ &rule->ixgbe_fdir.formatted.tni_vni),
vxlan_spec->vni, RTE_DIM(vxlan_spec->vni));
- rule->ixgbe_fdir.formatted.tni_vni = rte_be_to_cpu_32(
- rule->ixgbe_fdir.formatted.tni_vni);
}
}
@@ -2587,7 +2585,6 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
/* tni is a 24-bits bit field */
rte_memcpy(&rule->ixgbe_fdir.formatted.tni_vni,
nvgre_spec->tni, RTE_DIM(nvgre_spec->tni));
- rule->ixgbe_fdir.formatted.tni_vni <<= 8;
}
}
--
2.7.5
next prev parent reply other threads:[~2018-06-13 8:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:12 [dpdk-dev] [PATCH] app/testpmd: fix VLAN tci mask set " Wei Zhao
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: add query rule stats support " Wei Zhao
2018-06-13 8:07 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-13 8:08 ` Wei Zhao
2018-06-14 0:36 ` Lu, Wenzhuo
2018-06-21 14:08 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR Wei Zhao
2018-06-12 2:25 ` Lu, Wenzhuo
2018-06-12 2:30 ` Zhao1, Wei
2018-06-12 2:41 ` Lu, Wenzhuo
2018-06-12 2:49 ` Zhao1, Wei
2018-06-12 3:18 ` Zhao1, Wei
2018-06-13 8:09 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-14 0:37 ` Lu, Wenzhuo
2018-06-21 14:09 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: fix tunnel id format error for FDIR Wei Zhao
2018-06-12 5:10 ` Lu, Wenzhuo
2018-06-12 7:49 ` Zhao1, Wei
2018-06-12 8:39 ` Lu, Wenzhuo
2018-06-12 8:43 ` Zhao1, Wei
2018-06-13 8:11 ` Wei Zhao [this message]
2018-06-14 0:38 ` [dpdk-dev] [PATCH v2] " Lu, Wenzhuo
2018-06-21 14:10 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: fix tunnel type set " Wei Zhao
2018-06-13 8:11 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-14 0:41 ` Lu, Wenzhuo
2018-06-14 1:51 ` Zhao1, Wei
2018-06-14 8:17 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-06-15 0:50 ` Lu, Wenzhuo
2018-06-21 14:11 ` Zhang, Qi Z
2018-06-12 1:12 ` [dpdk-dev] [PATCH] app/testpmd: fix VLAN tci mask " Lu, Wenzhuo
2018-06-21 14:27 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528877482-5029-1-git-send-email-wei.zhao1@intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).