DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>, Xuan Ding <xuan.ding@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
Date: Tue, 19 May 2020 14:43:58 +0100	[thread overview]
Message-ID: <15292f1b-fb14-b2b2-670d-906885967460@intel.com> (raw)
In-Reply-To: <20200519071304.GE38911@intel.com>

On 5/19/2020 8:13 AM, Ye Xiaolong wrote:
> Hi, Maxime & Ferruh
> 
> This patch is used to fix the regression caused by commit 
> 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") which
> was introduced in RC2, I think we should get it in this release.

+1, v4 of the patch applied to next-net for -rc3

> 
> Thanks,
> Xiaolong
> 
> On 05/19, Ye Xiaolong wrote:
>> On 05/13, Xuan Ding wrote:
>>> This patch fixes the situation where vhost-user cannot start as server with
>>> dequeue_zero_copy enabled.
>>>
>>> Using flag instead of vsocket->is_server to determine whether vhost-user is
>>> in client mode. Because vsocket->is_server is not ready at this time.
>>>
>>> Cc: stable@dpdk.org
>>
>> Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")
>>
>> And no need to cc stable since above commit is introduced in this release.
>>
>>>
>>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>>> ---
>>>
>>> v2:
>>> * Added the description of problem solved in commit log.
>>> ---
>>> lib/librte_vhost/socket.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>>> index bb8d0d780..0a66ef976 100644
>>> --- a/lib/librte_vhost/socket.c
>>> +++ b/lib/librte_vhost/socket.c
>>> @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>>> 			ret = -1;
>>> 			goto out_mutex;
>>> 		}
>>> -		if (!vsocket->is_server) {
>>> +		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>>> 			VHOST_LOG_CONFIG(ERR,
>>> 			"error: zero copy is incompatible with vhost client mode\n");
>>> 			ret = -1;
>>> -- 
>>> 2.17.1
>>>
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>


  reply	other threads:[~2020-05-19 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  9:51 [dpdk-dev] [PATCH] vhost: fix dequeue_zero_zopy " Xuan Ding
2020-05-13  2:14 ` [dpdk-dev] [PATCH v2] vhost: fix zero-copy " Xuan Ding
2020-05-19  6:28   ` Ye Xiaolong
2020-05-19  7:13     ` Ye Xiaolong
2020-05-19 13:43       ` Ferruh Yigit [this message]
2020-05-19  7:03   ` Wang, Yinan
2020-05-19 10:15 ` [dpdk-dev] [PATCH v4] " Xuan Ding
2020-05-19 13:43   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15292f1b-fb14-b2b2-670d-906885967460@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    --cc=xuan.ding@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).