From: Raslan Darawsheh <rasland@mellanox.com>
To: shahafs@mellanox.com
Cc: dev@dpdk.org, matan@mellanox.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation
Date: Tue, 19 Jun 2018 16:08:58 +0300 [thread overview]
Message-ID: <1529413738-28378-1-git-send-email-rasland@mellanox.com> (raw)
When setting the level in rss action it's checking for the value
stored in the parser which is set to 0 by default.
this change the check to be for the requested action insted.
Fixes: d4a40518 ("net/mlx5: support tunnel RSS level")
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 994be05..40df633 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
return -rte_errno;
}
#ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
- if (parser->rss_conf.level > 1) {
+ if (rss->level > 1) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions,
@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
return -rte_errno;
}
#endif
- if (parser->rss_conf.level > 2) {
+ if (rss->level > 2) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions,
--
2.7.4
next reply other threads:[~2018-06-19 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:08 Raslan Darawsheh [this message]
2018-06-20 5:34 ` Shahaf Shuler
2018-06-20 7:10 ` Nélio Laranjeiro
2018-06-21 7:30 ` [dpdk-dev] [PATCH v2] net/mlx5: fix RSS " Raslan Darawsheh
-- strict thread matches above, loose matches on Subject: below --
2018-06-19 13:07 [dpdk-dev] [PATCH] net/mlx5: fix Rss " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529413738-28378-1-git-send-email-rasland@mellanox.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).