From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700081.outbound.protection.outlook.com [40.107.70.81]) by dpdk.org (Postfix) with ESMTP id 52B2B1BB3E; Sat, 23 Jun 2018 23:20:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hQsWb/82ISFPvodOfaQds1YC81UijClEcfK5nkImbn4=; b=XIs7aBw+kaEAqOSA73nGeujm+qEwTci6oZ7k84qXnzNI6/SKRz7MsK2xNQjX3MXtKuuirdVe1PP6zRLYCvUhH280/ST9MOGGrNVDsSphGup+jVXEQV7lyGV5Gf6X62oTD1rnGscZTXLUWQaNIfm5Fzf8I8Lxlocc8eme4YnYXmY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Sat, 23 Jun 2018 21:20:44 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Sat, 23 Jun 2018 14:20:31 -0700 Message-Id: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:IGDaY7ESzpMuxJXfov4hnbyUioVu0C1BneT/163xKNVqTqoEKZL1QHyu3EhTBqFJrUVWmAUHy7VoRgQjY4mcf46I5kpgYL7QzjVW8FEfxueA0VQ61q4wB7UGWIb8GoE25RKqbpaH7LamHAeezlkqx6smHGjwCvs1WC8i+FdkVUdN1x0SU0jMCrwbhTYGqJBo+bpGIkxS2QdpVwhBltwNBuvw3VpuztHbW15FVrLeJX96lx1X6MgSK0F6MilY7/IK; 25:B4hfK463JZdh6p7l0rJr/M5klqc6w+1r5D9Ps0hmfZa9WkVzrXEoTRMle5hwz6bfSeo0corTOOCvTKSXvPCjZo2WYa+kTmhMyoAEMgmi4rF2opIzIvN/A6yqNHH5w4KY7GVO0kJHasDUzYeI8Zy4oYPvplUDv+HpLcRh2Op1mCaSnwkTQl8+FgI/OOko+3PSQW+UISUnBw9ocypBhLDqggtsNn6pkQ/oeQOZ/csBc65hkb1qSyzjGd8Z6pvj0nym+q1sMueBMeJuHU+YkJ1tn/5scDaejVUHFxCLpwa4qdcj5AToU5EZuZuFZvnmusav7DTGck79w8Rc9zSkL+MxTA==; 31:cevopkxk4uG9YYmhDMPrCz1f1WkAg8U0DeyzyTHLrYY9OdVe5NCP4J+Bx1/9S7GvknNqtxnuaS7zfwdb8gbSIFBQ7QWo+LsmTaNUHVPz1JqcWcj6uSMwYzUiCSFKRdqad+eX6I9jMqx/jcU29dsgSefOWubTBiSlSGpZXfpiZBAar3N4mr/YClmePXIcfpIsrXSZ+/ZdzrR2YUJMIeZqVxS5WidRSK7ZZrM6SeIgT/4= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:MMxF1ObX4J0pnNWa8ADWLNH/UDvsStOcCxtSG8EBZqlg/NfMrqwJgz0MUYh2EAqzdeohp7c3nFGwZX1mJKs92KQ8PLjhYOpzdDZiObBdiRCPk15Rw7pJ5YEfsitPxAbt9NfWIqlhPkKJKydfkskZjq6qoAG14FBpheXLwvfOaMhE5lYiicehAJeEhIiohrV7NFjahoNXbK49ANkwNYRLSdvHbAwNuEiYl+TRoZqgDX4mhrwKailVz9Hs1FnN0LldC1ZRv6Ndk2YKQ6HWLjE/mI/qoxU/Pr3jRQSCSr1xN9pbO1xb9YFKaxEgdb6KgH8ZexmpL2Apsio//oiF2z20FgxDRXiETqQDrji+HIMpPt/MHsvS93Q4jlJjxJhfhV54XPb8ohIRhH/Qpm8ueMABXJYfktVO0CtNwuNpP8XLG6H/raxZqSaGjqdsa17FMumphrV3YKayo2Od2FapcvXjxcev9mpOo34oXzmYxsUD10MxAc0da3oDs3jrCDRcFem2; 4:S5RNhQf2mmjK7Bigto3MfD79EbUJVjxacxVLLDnLGPa/K5qaXNKrFTWvnKxPr+UwmECDDn9SIidbprt7fOIemZmO0K1OxpoBoN3fVdVkOqpUatC10vR+WZWahSmKrAOQNuP5GTzb+z8BQGSTNmkj35HXUB81YCmbQihYT3TrFa4LdWrZRYrKCStSyO36yOnlWMJVCif1VgqPrsrtZbQxM7coYMhGAVb8W0Q4aQtztBDeiPwWzpOHFvNNKFVDKTq5zz6x9dydFr1dGwr620uJEg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 07126E493C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(4720700003)(476003)(68736007)(6666003)(6916009)(5660300001)(51416003)(4326008)(7696005)(47776003)(52116002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:smh5Ig5NN+6B5cKxdSf3UzPncs1VN1TBp5MUh+wm+?= =?us-ascii?Q?s+xMaRY46BfMLqBnRxRKikl8v8wOCnpCCZw7U2ap45M2dh1ntA2L3iCDsBPk?= =?us-ascii?Q?RIh/g+MBOvaP0vdwqq3oI5nK7Ba450ij1pLZZIs7HlJsdMIqVJwwkL8uxBDX?= =?us-ascii?Q?Jd2ev720UOlhfpNqne7EgyeO6IoxBq3lHNNJgw2b/SsmemveVInvcNB0J7KZ?= =?us-ascii?Q?068JerSttenh3g0Tn9yTV7NNIIEjw8cREgAw6QiHFl5rbCufPhk4fGlHzlCr?= =?us-ascii?Q?IfP4RkWl5J2IaAddcbzs+Rj8ok0AoHmLNnohD+LjN0zYj7n0fHecaBGPOWZb?= =?us-ascii?Q?hCmK18IQMem8xGRtu7aT43HNOAobFfk9yVbLUw/I3TkZpWTVnLC3GM7IpU55?= =?us-ascii?Q?Dhhgzpc9Zm5xX5nrGQOm8kIiu5eO4hV9HKg0XNU+ZgkA7WDh/GFBzfZ4KnBS?= =?us-ascii?Q?gt3sxSG/0cszASmeFzua9mQKnCosfTX9AeUb5RCGVb3Wcn/XyRN2dHY7TEwo?= =?us-ascii?Q?g0iG18JD2eOL8Zh+9vLM8S+cyIpK/Kfv1xdkvWa62YXcB3zuTH+MH+Jr780i?= =?us-ascii?Q?OiizDqugwIzBB8Db5TtoTyz20rp0TdywWypc8yS2of///N795cIjAVN91ctO?= =?us-ascii?Q?eYkfwGpnHqrf4qTWJJIT+Q6jVYY+YPqCxm6nN+Y/XjIX+hJoYmO//iUev9gR?= =?us-ascii?Q?FLg0sgPTpwFBxJ+1hG3JGB78p1XCOAq8xa92pe0DvVxyX9gwtZmMn1impxPW?= =?us-ascii?Q?amd+HUs3SfE4t2tYQFD7s/ftR+dqhm+cQVarverkp7zShZEgeTaeGBIbGVSR?= =?us-ascii?Q?x/yiXVyLfbMTZZcsIKT3+UIm/EFK7NUZMPaxhE0UOax67ZIuj51ud/KgR9ws?= =?us-ascii?Q?9m9wzDeTaxUjmusL7oRqLD02On6WJOeEs3F3V8spLdsZ4nWE5WhiGxPuezgs?= =?us-ascii?Q?uR5CZaVAwwaLv7CZgoLZAZlEDoQXnv/IPqnQ3hnwuoEnJnLRgc80E+v8g68x?= =?us-ascii?Q?y0IPmpIVJnCFrwfTg9rNlfaTOOUiemtl/CbP3f9uClQB6cU3gfCDfOMQnAAC?= =?us-ascii?Q?S523ReJPjblkB5hoz6AkduzJfu1Gw1nd3yD4N8Q37tJInOsSQjNmOocpIPVs?= =?us-ascii?Q?+Fzi+TN6RlYseakBvdZlGcvdHUgf5L2D1IKTaHwn0LApE7xlB00NPNI8GYBc?= =?us-ascii?Q?93T9IRhwRD4OTy+7boG8YL0qTzlO6EU4orlJ3V7kf+K+1HuX+GPOXCq9786q?= =?us-ascii?Q?kXYmuR8unDOppl8sLAxxIUTsTrjLhFOpqSS36Ky4uBo+BAED8Ifz9ihvNfE+?= =?us-ascii?Q?1Jkna8k3VD2UJFMIUwMkTp2F8PRplKDus5Yqxy82zcxp7gRHBX2PKG414xyG?= =?us-ascii?Q?e44olmDCEj/4XqYh8nccrAH/iY=3D?= X-Microsoft-Antispam-Message-Info: wnrSddvQqjSJTuE1Sr9npTK2yf8KaNMzcAzQm5W4LbDHc1vei56e3bVO5FWogeehoqE3c858XTtaAo5KgXPNAG1UIq8ckmOB/PTlYEVpleghN7lXJdutLvRhM2cLpy1waXSs/drag//Oc1Qwu3/Mu/Qc5l7OWTRUW3arv9GVy1BmWl7TEGOPEmDnTwTU8zd7dnoEAp1aR92RwQk+yO3zJtVQkC4q63DE+w/ob0aeVxwDzxq0QCJEzJHn9nzxeeoWiJ1yoLAOfMH/+1E/cbynrYfZTWbhArmoxyF90JHaOGtQt89MrQbv6K1xPCh8l2ig++25Spg5PCwktl4/XGLsuA0i70YID5jrki1eXGcfpcg= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:EhlvRwd4lraUHBjF4DjaH6pOwTEDhyDLn3Uic1J+Vk4Hf/fEKvjJOJPnw245FyALObXl8D+riAc5a9v0DA+2Q2duMEMBYnoBNjB29YFZIx9i6TUBhmQpqcmq2cKUnJc6rgnfaEnvVDY0Ps0bZJ7WMFfUV/EGk1AtDhOl70HLVMvKua+REwS8WyTi7DHJXcVqGGBkxv5axYGnPyWoyqy4wqbtHosugz3Ef9VWV9A+Kv7rmd2JU0VudJMS+P9dtx0zVFpjNox+kNLFLYXNy8egxNoTdAP/OTBTvGT9zsGWtcEDCsYat66+zwvtEaGWMLj2C8FdYrOnF01hH045azcLeMf0x4cci1ysM1PIRyR8tATAJUwAX+k+m6pdWtbzLXjcqss3DOGxRuSvIJgd7tVM8P+r7uyq+s/80eYErjNDD9IsMs1/st6yGSiLVpbZ125LJjmqbs1UKvXxFKhhJcgphg==; 5:syd6x0ubiXBhitLmFVK/l7fxSxsp/UgNqEWigRRJkHpLc3VCxJduS6NEEnbOVFPot9LXgq7l7+2Bddq5/oAVpUakXtEOi7lbeZQAD6NpfZ6jp2QyhY61yRwxhuHEX0I8y058X35XLPPaUB7ANUdl23Q9eg5QCDenxYG4RS9ITQw=; 24:v82cl5hxwCTgSBDSm5ehbYFRMTXyeNLhQjWR+az+L+Zda1M/VxlQ/sPwHs+zfren/TFN57sjclf/5I2s2FrVpYmxLoXZAYNLje7nB2zV5Ks= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 7:Se5AgDoeSe0FztcdVxZ2u1M4AOlNZ6IdISGFVSO3LyNOyHsZilTHEvJ+ciM/CLC64juoC1qCW4xtGtxwyyirqjacPzc7ABtzLNwTHj+Soy/va2q2RsOmffg3vANGlpbD4TfipZBmqknQBVJxCDw9BQBXP82Ih4xFZpn/zdQBwJv0cPum3cR1cDUM4EJFuQ4Vx+lQlPDKJMvIqc03jYwRLUOOLYtSrpeP6ZI8Rxs0oji8PHHNpzQYEoLxBrPDBloi X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2018 21:20:44.6651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 1/3] net/qede: fix unicast MAC address handling in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 21:20:49 -0000 From: Shahed Shaikh We did not register unicast mac configuration handlers for VF causing failure in bonding of VFs. Also, mac_addr_set operation requires mac_remove followed by mad_add. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 7a63d05..1cae474 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -957,7 +957,11 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) struct ecore_filter_ucast ucast; int re; + if (!is_valid_assigned_ether_addr(mac_addr)) + return -EINVAL; + qede_set_ucast_cmn_params(&ucast); + ucast.opcode = ECORE_FILTER_ADD; ucast.type = ECORE_FILTER_MAC; ether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac); re = (int)qede_mac_int_ops(eth_dev, &ucast, 1); @@ -979,6 +983,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return; } + if (!is_valid_assigned_ether_addr(ð_dev->data->mac_addrs[index])) + return; + qede_set_ucast_cmn_params(&ucast); ucast.opcode = ECORE_FILTER_REMOVE; ucast.type = ECORE_FILTER_MAC; @@ -1002,8 +1009,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return -EPERM; } - qede_mac_addr_add(eth_dev, mac_addr, 0, 0); - return 0; + qede_mac_addr_remove(eth_dev, 0); + + return qede_mac_addr_add(eth_dev, mac_addr, 0, 0); } static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool flg) @@ -3024,6 +3032,9 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev, .mtu_set = qede_set_mtu, .udp_tunnel_port_add = qede_udp_dst_port_add, .udp_tunnel_port_del = qede_udp_dst_port_del, + .mac_addr_add = qede_mac_addr_add, + .mac_addr_remove = qede_mac_addr_remove, + .mac_addr_set = qede_mac_addr_set, }; static void qede_update_pf_params(struct ecore_dev *edev) @@ -3188,7 +3199,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) ECORE_LEADING_HWFN(edev), vf_mac, &is_mac_forced); - if (is_mac_exist && is_mac_forced) { + if (is_mac_exist) { DP_INFO(edev, "VF macaddr received from PF\n"); ether_addr_copy((struct ether_addr *)&vf_mac, ð_dev->data->mac_addrs[0]); -- 1.7.10.3