From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0044.outbound.protection.outlook.com [104.47.34.44]) by dpdk.org (Postfix) with ESMTP id 1F8161BB4E for ; Sat, 23 Jun 2018 23:21:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kb1FlmMiaDa3NB1tFJGVkiUkg9PxSUfi0nzOdmglVg4=; b=HIuwHZOLkJhvuL32b0wN8xMBUnfinBBnGlXaN/nAKPPehznALeFntqmecuE3sxhrbTTMZwnjf0P6QxQrUMmAGcqiD6XRWSWXzdlWZkDXNhSj65wd94+oPfPUcMxUjCo0eWk2NywklOu0nhyqh8kxfOxwbcxas4iJ1UM3id1f08I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Sat, 23 Jun 2018 21:20:58 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Sat, 23 Jun 2018 14:20:33 -0700 Message-Id: <1529788834-18717-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> References: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b82dbbea-4030-44b3-2808-08d5d94f3726 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:OhJndrc7nf33ZvC1LoPVBisCpI38GXnj2xlCkv6YUt52q8u9H4iaGgQcbfsGLl2KYMd/UCtOPpWYYjxEUoJNvZt7AixHw/dOf5HZS/+6n4ISwIofTxakea6dn99h6biBhaC4wOZOp+bHoipabfgXYdidRnF4HebNb/+mg76t4e3ZpjQmKeN30varnDJh7TLJACoyCu14m1dUUpCNwJS/PYn7JaRWTqerKxnlP1WIEWVtLIWanpZPtVzV667MY+rW; 25:tXu+8+V3WXJX67YHhPKQYLS+UHdJS9HPximthOwbaGiMJqYLufys6Eebyd0zAUPncDJHd12SwHFH075tzMV5dQXtmmVDRxtgdJ+Nf/goNR9kisbCZ1CtbVSyuompq4mws//5QNR+8xzv9L/4FxFror2FnQ1Jz3p/zyjrKJAozENqAKB1a+TWFSc8yIKph8sa7GeU39g5K/3Ouz7GYeh4aqfbPy+6N7HpvPfLhZ2aFCiz6HNWtGl4HuyikGiB4INgZXoLVyjCB2nU1p/hGVZOC8yoWBgdngYeqDj4XkFTN60tXmO2oC59kmKfkWP/dzYUi1kD95aoSVB4vrjObpknng==; 31:gczWD6kemI7qAjslCDDp0ogC/DrEw2C0KuzA4FSSawK+OWyu6xpOpOWZlmU189NOs6pj26cXDjONFwsvFAJWFOWm4GWQAqrsgMojyLnvnrhNHealZ3dcT5dgXZklYAmEBLREFplX4ucdHH4ppFA/82b4fUNFNlEJRWg9q7PVBUj0aWolJ6IB65T60WIUVlvdIF/Na8GAhT6HgKjskml6IrGjYsae9C4hRwT+L1LzVLM= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:YRI/zdJH2T1SidboGnMY5lCuCUteyX5OdW82Q0XhwuenVoOOeuykYOxZdKcHoQ79xwjju+lNIurj2wwN3zZpG9dij8iFs545sL3mJhuRJv9sUNJch/J6UObiHHm9ihZtDTzpKFJrvBmte0M0EtIhVZIxJ1ZWQZ0J4RSkAokjFYDVEJubCDUxlaXn+xo9b43dNr2dX8GKRO5zYjFnueeUqhhN0VhA58o0odhLRZrt/31qPONXTOU2VE0+UUK8v6U3QTNRAunfTUK6dsgxN0QwIREBnzhRCl/Zs3OCk7SFt7K9R3juaznjikOnHrUlrz3/Tc22eWfIdn3QZOVR8hNIeVhWh2ym9MUMDWgHOqsSbjXZbbYazRypNzJxr9zR1Nw0NGVrsUB49RzkwMHrBwoh/5ywKbTWM7qTpe+QOiuGOF1RmQdRut93yZciyT47nWKpt5oD+WpjoWkH/h4r8R2kOmC7VNaXuWP83OHn9pMQbAPsI39xfOwNxrUrMejOye1J; 4:JOyR85ZlXJlA+AD1Lxc4eXxcmG7Kq6hwu/tsc/g3357qAqxiplPL0WCGHTf3v2jqrelHLnXwOGxSrbe75hODbAdrWERm0Mi5EpGzUPODRF4AStiRuWC45Fjtk3+9DCxfI7hNLVm3m80j68UkvCNRIVNnRHfLmWVzIaFiSyv29EMd4oCLTyO/URuwwqS2zTtgip2fT4v/WpfLe8lCvi70fprMz7JP2zkyiYY7g3TzUUTUPUPv0M/6VX738pOmQRI/LoLzhiafLFlUaVuXcKZDDg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 07126E493C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(446003)(4720700003)(476003)(11346002)(68736007)(6666003)(6916009)(5660300001)(107886003)(76176011)(51416003)(4326008)(7696005)(47776003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:u37OrTdw5IjjzVwN7Rh7IJJhRy5Yka5u8O4w8S29t?= =?us-ascii?Q?KcmdxadS8l63k6IFWxk/sBdx7WdJ6OMTLUu9gP2Wg2xELKRs7Dlx7ps6MeOw?= =?us-ascii?Q?A+SIp4gZB1vWxjh5DYwwKLMRv+ZWrsbA2ZcffHIqX/wbxNh081H6Pup4Na/A?= =?us-ascii?Q?YHaykZ3PKzjQli6ttzbdI4QOj8RHgZk0byAuvsSLfGsURkZAAtXXymKiUXoK?= =?us-ascii?Q?7h5Q3WUw895DynUTW+24avJyVVSvCb4dT6g4LPRPT9ZcSkeKfAEUiOKzciaa?= =?us-ascii?Q?Fdwm/n2R00z536yJmh5C1ECqE3oamPqm4mZOM3bhCS8fHCnaAYjcpIK1+X7g?= =?us-ascii?Q?jAcIKODPBGzH4h14zq5ky8gZWMkUJVpqP/hdDEaAxRd+KKymZJbfC8VdG28R?= =?us-ascii?Q?Zmgz60Gy3gnR17uHfPNVi2QZNQejEOoK1GI0Dbxc3mgXOuFr+qcmjrZS9xzP?= =?us-ascii?Q?nV5GaPio+JlxD2pU3oKYWjfGB4Dc/IjZGP3inKYOvnKjeGRbuH5sq+F5bLz4?= =?us-ascii?Q?jhXb/JboX1W6JLqOq/BKhZdB/eO2IMZTyHm/1fV4fygleijgejRfml/rmfz5?= =?us-ascii?Q?btepq2kzQCToBfaJNzXHwF+UjEyAYlcdtNpSNgtS5yT1P8vEmS/19Y/UnCxY?= =?us-ascii?Q?P2jteYmg+VjHc1T82O6uQi/yn2KAxiIbm390m2N8rAdIApZ3dpMK5Et4Ks2G?= =?us-ascii?Q?7PTe8C1tIONlp6YZXr4AuwHMCtHe/Sf0mlb84lxcubJsy70pXcBFN8TDtGAc?= =?us-ascii?Q?JDYvnR85NsX9EalvwQYwaVuk88b3Ph8amGwSoXifvGOOA2McSg9QFjJb/XtY?= =?us-ascii?Q?qnaUtQQ+/ovQ26HeAXN86o7Z2TlOOHcG5riX2wdME0Osu2VRwdgq/g+ecmVP?= =?us-ascii?Q?AwypIZwlgj0s2rM3ZI1oK8ORfzZxYbrGVMMe8xlwiFyKtt1Z/lxWS2PFpVVt?= =?us-ascii?Q?sX1Qkkdd2No8C97Ce2Mri7Th8UUC/+ADZUAfa/9e5Uhp6RDaultJ6XlBstyl?= =?us-ascii?Q?IJV0+2ATTgqKTRzNEV7Sd6tSSVOe8YBC8//PfuGGvqerKmObwoiAOs80PXec?= =?us-ascii?Q?u4j1HpHP9rrsfJJO3YVkjQtAf8sJREAsghSIOO8SkZiI6HLBwPARgtBbAmmt?= =?us-ascii?Q?Z4wa6skwYun3dPiUKgudF2xlwHUzUwvKgvZQy7F7IGOLaaeIsqxIYlTTnDJv?= =?us-ascii?Q?UkFkUlIeK0ODrbX/DkPP1WKjvKIIPMP812XfGd5wCgddulPB65FB3n5WPw9B?= =?us-ascii?Q?BEI+8TFUOpClFKSw91rhIRv6CJTgNoslPQyXwNzvasfWR6kxZWBL5fyiO5jh?= =?us-ascii?Q?c4g/QYjmoZMCTDAAUMVczUAlB/MpCJZF5wdVbmsR7Zu2SBJZ44RuZJ6N7Vo0?= =?us-ascii?Q?SuIHg=3D=3D?= X-Microsoft-Antispam-Message-Info: bG9mlIDjh3E/L25k7r8Mm4Tz57xHSX/zxzqHD8x7wX1yU1PNsQ69gGE+qmjm3FASEaJDMM/y59tHCrGPQXax1EXNG/+B05JWdYknh/qy3NyqSPeInswGKS3lDTSPV38gkv/NGtMzIUEBKkZX/tDEWscuk6hKpSncPyAwAhmMZKGw4ryRfdYZRlR9c4n5/rPtpxDIa81Avu3hJMS87YSk6syhFopBHRR3W6CMogW8btqNeOBgUiZZ6VBXnK3MlkZZSTyxj6sg6qGxLoIQK+K6xyuG5zZAe6qF+C4akoZbVXXMH+wuc4Vw7q2fO7FyBfwSfv/sN42dHIGWZe4ln59CGp6HMvQ/VXPdGfFDxgB5UBg= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:wlcyHR1xoANhIM10oChFCwLmjtphy6BqMdSs7KrSA1HgznIECAguH23LbUYnf3/aXRvI3jIAG/NxhW1HYbV3EccEPp8eXqZraT0HKRrqTq+UhMwh6mQ5BzQrQYj1X7doG8yd8Ylm5F+okQ12L9cq67QRiw+PupMtYFcT51mCjhkZ1nUWRGj5KEhJrlCsp6QTszd/IBoch5sNaeJxnPocIR0Xs88skKuHolcN8mhb3H2D7ix9BaEtGknqqcwZERukSp8KDoOOuY9Y6oHapXw5ULXpnApMyeopKuqjYib0W9sDO6KOrRHZJcse+5RltjBs6gh+ksq+plb0xeCBs+zMCtVb6lGrGZERsFyjVKsIfrPJkep/ZvTQB/uiVjy4WzzJjx8OvhJOB6uE+n57bUvQ7g54EAJXDssCbgWl9bzq+RG3fThvBe0XYchFn/eHqA6uA1QYTnJlo6TTaNKN9hxrEg==; 5:6HTAwUjZT3jb+sB+yDLZsupptwvS7S1OtVm/QUjIoGqGUa8jORiZlpUwYvGcnhgQon0UL1WMS2m4Q7/s70SiGM/KctJtTwjpJsGKnNSKnxFud6Z0QP/o9E0UpwjUXSgOr53silb6aciMW5Htj0y8RX0hMOXFOtaXNSYEAht7lqo=; 24:sQtMpDBWR+Udz2BYr46XXT3uP+pqK/k1BWpwTQUicighKJaan4RAINvfPOOurCUe1HXCLzLLbPx7hzgATST0PHoEnGlkan7lHb/mks079+U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 7:jR/6wRtqi36crPwp9bojhudWxT32bfhGlBKrzSUdSJvB4WaJBxoTvdeiSzelbJeUEkZqw5IKKUk6NmxPLbxoH1OrQOFDhBScqXcfjRtlDg4kjKaSopLrMtiHHhTHSooAfohO7JL4z/Vl0I+ojY6sI5muu+8vF4l7P0oa0xUyj2DDFycDYl9aNV2DcujA1g+EBVD24NluJa5VU6rg46dxRPLl97r2HRr3ZHWo5MCawsQNAXOa7zJ1Ka57UhtND2lQ X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2018 21:20:58.8371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b82dbbea-4030-44b3-2808-08d5d94f3726 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 3/3] net/qede: remove primary MAC removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 21:21:01 -0000 This was added to dev_stop when set MTU requested vport restart. We are not requiring vport restart any more with set MTU as it just needs vport to be inactive and doesn't need the port reconfigured. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 8bbfa95..b726e89 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1355,9 +1355,6 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) /* Disable traffic */ ecore_hw_stop_fastpath(edev); /* TBD - loop */ - if (IS_PF(edev)) - qede_mac_addr_remove(eth_dev, 0); - DP_INFO(edev, "Device is stopped\n"); } @@ -2096,8 +2093,6 @@ int qede_update_mtu(struct rte_eth_dev *eth_dev, uint16_t mtu) goto err; /* Restore config lost due to vport stop */ - qede_mac_addr_set(eth_dev, &qdev->primary_mac); - if (eth_dev->data->promiscuous) qede_promiscuous_enable(eth_dev); else @@ -2526,9 +2521,6 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_started = 0; qede_dev_stop(dev); restart = true; - } else { - if (IS_PF(edev)) - qede_mac_addr_remove(dev, 0); } rte_delay_ms(1000); qdev->mtu = mtu; -- 1.7.10.3