DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, anatoly.burakov@intel.com, maxime.coquelin@redhat.com
Subject: [dpdk-dev] [PATCH 1/6] mem: add function for checking memsegs IOVAs addresses
Date: Mon,  2 Jul 2018 18:26:58 +0100	[thread overview]
Message-ID: <1530552423-32301-2-git-send-email-alejandro.lucero@netronome.com> (raw)
In-Reply-To: <1530552423-32301-1-git-send-email-alejandro.lucero@netronome.com>

A device can suffer addressing limitations. This functions checks
memsegs have iovas within the supported range based on dma mask.

PMD should use this during initialization if supported devices
suffer addressing limitations, returning an error if this function
returns memsegs out of range.

Another potential usage is for emulated IOMMU hardware with addressing
limitations.

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 lib/librte_eal/common/eal_common_memory.c  | 37 ++++++++++++++++++++++++++++++
 lib/librte_eal/common/include/rte_memory.h |  3 +++
 2 files changed, 40 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index fc6c44d..ca49e5c 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -109,6 +109,43 @@
 	}
 }
 
+/* check memseg iovas are within the required range based on dma mask */
+int
+rte_eal_check_dma_mask(uint8_t maskbits)
+{
+
+	const struct rte_mem_config *mcfg;
+	uint64_t mask;
+	int i;
+	int ret = 0;
+
+	/* create dma mask */
+	mask = 1ULL << maskbits;
+	mask -= 1;
+
+	/* get pointer to global configuration */
+	mcfg = rte_eal_get_configuration()->mem_config;
+
+	for (i = 0; i < RTE_MAX_MEMSEG; i++) {
+		if (mcfg->memseg[i].addr == NULL)
+			break;
+
+		if (mcfg->memseg[i].iova & ~mask) {
+			ret = -1;
+			break;
+		}
+	}
+
+	if (!ret)
+		return ret;
+
+	RTE_LOG(INFO, EAL, "memseg[%d] iova %"PRIx64" out of range:\n",
+			   i, mcfg->memseg[i].iova);
+	RTE_LOG(INFO, EAL, "\tusing dma mask %"PRIx64"\n", mask);
+
+	return -1;
+}
+
 /* return the number of memory channels */
 unsigned rte_memory_get_nchannel(void)
 {
diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h
index 80a8fc0..b2a0168 100644
--- a/lib/librte_eal/common/include/rte_memory.h
+++ b/lib/librte_eal/common/include/rte_memory.h
@@ -209,6 +209,9 @@ struct rte_memseg {
  */
 unsigned rte_memory_get_nrank(void);
 
+/* check memsegs iovas are within a range based on dma mask */
+int rte_eal_check_dma_mask(uint8_t maskbits);
+
 /**
  * Drivers based on uio will not load unless physical
  * addresses are obtainable. It is only possible to get
-- 
1.9.1

  reply	other threads:[~2018-07-02 17:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 17:26 [dpdk-dev] [PATH 0/6] Use IOVAs check based on DMA mask Alejandro Lucero
2018-07-02 17:26 ` Alejandro Lucero [this message]
2018-07-03  9:07   ` [dpdk-dev] [PATCH 1/6] mem: add function for checking memsegs IOVAs addresses Burakov, Anatoly
2018-07-03 10:01     ` Alejandro Lucero
2018-07-02 17:26 ` [dpdk-dev] [PATCH 2/6] ethdev: add function for checking IOVAs by a device Alejandro Lucero
2018-07-02 17:27 ` [dpdk-dev] [PATCH 3/6] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-07-03  9:10   ` Burakov, Anatoly
2018-07-03 10:08     ` Alejandro Lucero
2018-07-02 17:27 ` [dpdk-dev] [PATCH 4/6] mem: use address hint for mapping hugepages Alejandro Lucero
2018-07-03  9:17   ` Burakov, Anatoly
2018-07-03 10:44     ` Alejandro Lucero
2018-07-03 10:46       ` Burakov, Anatoly
2018-07-02 17:27 ` [dpdk-dev] [PATCH 5/6] net/nfp: check hugepages IOVAs based on DMA mask Alejandro Lucero
2018-07-02 17:27 ` [dpdk-dev] [PATCH 6/6] net/nfp: support IOVA VA mode Alejandro Lucero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530552423-32301-2-git-send-email-alejandro.lucero@netronome.com \
    --to=alejandro.lucero@netronome.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).