From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id ECFE1B584 for ; Sun, 15 Feb 2015 16:58:19 +0100 (CET) Received: by mail-we0-f175.google.com with SMTP id x3so25137183wes.6 for ; Sun, 15 Feb 2015 07:58:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=MyHFe6j/rO3GIXB4UTw4FTg7FIHcWHp35NnGjQKEIsM=; b=BSvlD7MKMZGQPPKKMLsferY7inrHENF/xddf8Q4GGpMf3rQDkyuJo+prwpF5Vc2uV3 QMpiGZcHRdOHGG0eRmyn3qE7irtSyobHKj1+mJI5EwiKxgrG35OBRpcNXeWolJHdtKaW fYPub9JdMgLtF3IQ7zcrrpt49Ndkqh33OvtDYgV0yAyY2plht1MC8XiKfF3d/fPRn3VP 0F5SL9QM8wtzWFlMgNdGmY+cO9eCZOo+tFzRXcqrrCpPoJ+jmyrmdfhaIhJfqosJ5Fgn vjkFy2PAUfcA1RBs9bpCp1u+ETVFl31XVOZdEwntN/lye2PL1nrAszL7r3iX4F19E1p5 l28Q== X-Gm-Message-State: ALoCoQmyhXiz6QdLUC0DED5KI8/HluG368bTrS3ayj5t2bfCsXxz4Jqtbhnd1vUQDHQE4yKppq5S X-Received: by 10.194.173.10 with SMTP id bg10mr41587582wjc.115.1424015899881; Sun, 15 Feb 2015 07:58:19 -0800 (PST) Received: from xps13.localnet (174.17.90.92.rev.sfr.net. [92.90.17.174]) by mx.google.com with ESMTPSA id d10sm18765945wjn.45.2015.02.15.07.58.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Feb 2015 07:58:19 -0800 (PST) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Sun, 15 Feb 2015 16:57:37 +0100 Message-ID: <1530680.DEeoNRuZus@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1423579997-22014-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] testpmd: force user to stop forwarding when changing port/core list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 15:58:20 -0000 > > Testpmd has the capability of changing the forwarding cores and ports in > > runtime. > > If these are changed when forwarding, two issues may be encountered: > > > > - If "show config fwd" is used, changes made in the core list are applied. > > Therefore, trying to stop forwarding may hang testpmd, > > since it could be waiting for cores to stop that are not actually running > > anything > > > > - If the port list is changed, when stopping forwarding, > > it may miss the stats of some of the ports that were actually being used. > > > > Signed-off-by: Pablo de Lara > Acked-by: Helin Zhang Applied, thanks