From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00064.outbound.protection.outlook.com [40.107.0.64]) by dpdk.org (Postfix) with ESMTP id D34AC1C47E for ; Fri, 6 Jul 2018 10:12:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OWmMKkNfGsjK80X0TOUgvNEyqeh/yf6yNW4+8JZCEhU=; b=cPyPxsgwrhTQ+28So2AL9LN0BRNJGEfEw6PDL/WvqMZSx9A869289EBEXoFGq+oDCZt+BbDhbyh4RIePSaiwi6KWgavUclvRI6Ov4Fjjhkgc04AntFXFYO0FLjTAswbRR1ErCgFdv0N6TrNF2sTegKAu7zKjcy47tqDlpHZt7Qw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Fri, 6 Jul 2018 08:12:08 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: shreyansh.jain@nxp.com, Pavan Nikhilesh Date: Fri, 6 Jul 2018 13:40:08 +0530 Message-Id: <1530864613-11754-11-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d58c3315-fc39-4524-97e3-08d5e3182bd7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0755; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 3:0UJOy8i5hWTlQPqQT4w6Qahkzok2dFm+lQd2jWJ+oA/JtZOS1VDd9dBzZWWgtwvJuGjFjSXisOax1cBQ+2HK9DtixmpS/LS+trnjwQt/fzJDkFhgvb/p+yqbz7LiBHehvw5/YBH4UDa36MgHqkMMTehqoUvdBE0s1z9AkToyLzjOdSTf+qXWSzj2FVch7AAyYoTgLe8k4Sk9qmjBr97KLdSMPeo6cJ5yAUF8GEDcgIdXD+2iwrypxM99eUApeU5i; 25:U50RuEQawx3TEfiehJKxdCNmUJYk2kua4vY43ooCXuAgooHiLXdYEZaqDRNK0L0pF01Y7T7FbAhJfgCySfc8n2SG32ShwtX/hUYUN5XsjId1GbLtmobstAbSGVhlzj5YzxJjvzKTznncb7oT2jXk+WrH/rAdUjKrCsihFW1DpHYoj9B+Cb1IqQ0disS4Qr7HcvxJ9hhCPRUZj+bL6dCQF28qpmMsaQkrIN7ue6QYBS5M+OWWZK+3cfcJqQAsOg57JiLzjLQ2P6MuSVxUUuP7P+NK9MKFaHHOdRaui6YMquzHKTXNSck3G/yy+jtvLO4Wu9ymJK0CKIYuXuUvqfBujw==; 31:KgIejGxwje/PT/TuJGa9Itm15w7BhHpGZ2SP6R86hmTlklpWD1vMcKi4bFBv7G5KfYqqnv2GLOBcbHkguwyDX0gQNGq4EOwOqWKVtAYbMQrgsGZg3LLFW9whlISSQBz6sxE+k04053c4svh9GjeHJKZAtbN3IDmbcpNjjXwp14lx7u6d5SbY9KHbnN4wIkaxiuexI3aWauSjpNGgLhLwa2KMaZYDwL0+RHT70Qfkv90= X-MS-TrafficTypeDiagnostic: AM2PR04MB0755: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 20:/i1XO55jkwxv2xMVdkvduU8bHaTdYq/pygdV5QhaiONELxJhdCnJ7mlI0d/LxZ30+VZrFNGPEp1hQI1WQY5uVSny2X5fg10QFHBkDcxhgX0pTQvC4s3+gvMzuCOlDDnbVhNPbfvew/esuw3hqdGmMLX0WFFpguxBMlS/QluF5T48ZV1nf3d58BiRzIZ/b7pOoOqKEjvmKSsipupZS4SEKGKIkA7IpP495T8GtmwmJevww7szMjjPfce2oJBn5ehqet7y+moh9mS3pcYH+665Ke+VR9ESOyu8L6fXuDQjpkVYhpJf0vk0W4Kt1BNHn8Xr1qtceyTbm8G5ZVAoGpI10udT4jLtCGGM5RmfQxKNLmcxlLsHhqQR1nGnBkKaOeKvG57qyfuc7LyuuWTD0JUqz3Hp8FHr/okYJI3cMIdSfASdHtKmz3Lb97Qbz/uayqpqnusAlMiq9K6jIgPiutKgOjJc/3eRycc6ZhTCNCNQek1n04OiJNEDsoh6HGJ9b65b; 4:bSLwFvw/hnLz/Bva7LOoR0hnXa2sQt7tlHtJtb1kGUIG74HieKAAip3ZOE/4NyMAdasGaju8wVKrURYegy/kdjmHWeTz3Vqk6/T9h1UHTUyYKl8z0zlW7bM6npW0ghNHQYI+ELumg8ach1fGUMi84qZQAmLA5mduacLemjTePj5ma6GRNjYcYv632FnhTgGEQD8vmUk2wjC6B9Tkz/d+GEmQY1L+W3iQ3eQptKUA2Y7hx2DgEi1cmhsr8cK2IkpZGK5wNw83iu328PUJMZAQuSAmemJpIUqBkBKCQ0k4AtjBxxSQOIXPvmx8p0svYjfwlUmulnVo14HeE43YqxIbBGdhhu73XZxMuNKWr/Ewiwg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0755; 23:rrB8BwuH5YBFsbKemkMIyMM1IDo+NTQxOP+XRrk10?= =?us-ascii?Q?k7qwVX5SXW8TXV9Hd4C2feVTEIAVeLhAa48VmgKV1Uq9jqZds/tPMCJX3Wbi?= =?us-ascii?Q?rtiFKJnAf3ZfI7/kVDqZJ0pchZy7zGcFG0sZvKHKUu8RtOvzu/WActuhL0Ub?= =?us-ascii?Q?/L+bMRisOEze5slImH7VjJOS7G9Fz169qBLloitj9/E5Rz0qs+1krnUALQ3Z?= =?us-ascii?Q?8G6bOsLDS71eiJIvxYb/DcC8ZHQUNO7SYckJmdF7O8ZzEGmid5kmdqwR32kg?= =?us-ascii?Q?HYOwc6vOc4sSHXsEAIlRHZOHeoM/IDCLhO3MWldx6ZcPCtCgddqLTOSpY7Tj?= =?us-ascii?Q?9hTZ0pjI6r74d8jhhuNsD1O+OMvXxJ2rLMhaXyC3jatGXznodpsstugekiXg?= =?us-ascii?Q?xd3RfkKP1w2IxxkXpd6dfY6dIc3M2IZqsUvIYcvtuHKS+hsFrNezpGCBe8oP?= =?us-ascii?Q?Oc0MDYyvMznphIfrCXJBifLa5/Rm4m3V64VgAFIRFeg4/jQ1XyuHQ5rqzNr2?= =?us-ascii?Q?Z/sSB7LZs9NPa8n5zIXoCNgONfp1J2IuG5AAA2hKgmS/ZXD2L2YDa9D0hwX+?= =?us-ascii?Q?SmlK4xiYYQA3Mh5kD1tsdPikMMKpDMBHpkY6ks359Ej1GWNWgmd2rmK42uZa?= =?us-ascii?Q?KLJnpdsVRHIhXuDSfhem9Om1SwRaFmIv8TKxypuMd90wsQzpfKW4c7nf7wg4?= =?us-ascii?Q?RJ1inoeuQYBjuRuNxCK4xwIjmPHoxTjrdbLrgZiRch//u9vCD6g5N5/JICLS?= =?us-ascii?Q?datQmgTCDcAz6euPdE/A2OGGYKC0JZkHOch/g1QSatSMk9WP/zpx34MT440z?= =?us-ascii?Q?yXLaYZ9QbbAYH553FArP/XuQ9A8KAFP5xMU+0XQVXJZCNxvQq1SXMhAuG2DD?= =?us-ascii?Q?WWXQgKpeaza1tJ8Q9mkNC02PESSot1j6tkhZPQ+tSDoCzSX574OuYFS0UatL?= =?us-ascii?Q?NQFORpgdjI772yGraZFSR66j1d+3oKmNCM3q/DEJqp8+HmxKkj+iTJwvaEkD?= =?us-ascii?Q?HuPSX+dfjVvo9UcWqMnucZKxF7Oc/Fk8APd+oQaJYavOK1vppZ/qpRIB5Msq?= =?us-ascii?Q?DgfJjhXHtJAAeliWGYqomkzmN9emV0/QERUTXasBv6hUGg2roQixZT8GG9XU?= =?us-ascii?Q?PG/2tNbrjta+q0D6TlqdV+Y0+f2k2lWDpejUip/QqCWdgv/5QChaJpz0i+l/?= =?us-ascii?Q?o4otqUDtJGu+vgs7vqWwJTl3SnaSJHHOs+226cGHUnSHLgWr+4mF4IspAO5q?= =?us-ascii?Q?/cJycJGhjIDi8j8DbYsG6jKaKf6M4KUBQhHWuaHitUreNFkbrFaVMA+zmjAn?= =?us-ascii?Q?3biOWf9zNtQq8anlHGVPtw=3D?= X-Microsoft-Antispam-Message-Info: VTv2Ic4hRZSOVEFve5paxbhs7qxlPUsIpexSM0E8heJHeXdyJfz6X3Sh3OD3Ou0XCWsMY2VxiEfUALgU2C+YSwRXwIDqzYOWs3kFsIK+xc/tAiFKchixkvb7XliTLNFjYAqhgY2wOBHCDy11V+Z5IytTwcF0ZAJ89fkBuPRsiIGLkndjMwLSdZ+iQHaGA+V3XJNO/jAeWIs86HRtVVH4e9Kuua4cKZWBz5Qd7vCJOb6j3jyiKPOb3GdhCXJv04XNfWhh2xKDjcPyFX0CJmOxt4BSraQ3EJsrjM7FJ5AH3CD7CIUdpjsWU63+MgqCaHBWgB7fLWyknfTPhCrV95gqAev/wHK2YGBcta9yOD3rtTU= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 6:DVLVx4pU0RnK7ytRUXuVh4XyrUfOQ16N4Bq82SjZfihLV/SaaPc1VlNaRKsa0nS8EV0ZKIxYfuJD7/ETiWkKoIZ3hAYAQHu0GyWeKBJSYbEOVKu/o+k6HDQpvqQbu2TWhn4yMXZ8zDEUpNd/kpje1xTLBDiaqRitwDx4Rc93WJ3wuoKDI36foXQgGNOIdDlgzFQLK/y+ItK//6RcZ60RurXI8I1ofZPZDCjt2EJ3xjAbs4rPaUHW0ZNItlk/fYH5O0eHcclGPayhooHfn0KN6goClofVoHBbd5QCQVc+d+fpznOj1ZrEiuo8oG1jbq02lGc39Guj7jX0Enyff+YygmVycoR6OxQ+yuGLaSsI0dGO2Pp2d0YP/yw4CQ1b8VftKCF6sh6LM28k86ZnCEBIEBk/R66W/w9c2dVBOyZ4F4kps44777CheRp/WKhLoA0Tjfz4JH+dBlJEDfRwbqNh3A==; 5:15CxtndxLRVtfoDz7H6IlUNu7vXRQrdo96SSqCLvg+tyuEcoGiZcfsbzUNBBxh5woHRypAEgho+4RsOp5NydZpV3KCp5Vz2KezxaZeUgp3OT2YhL8nYP8BppvFT0gnt1FD8xeuXGUzwMFPYsK0tHJHK7Tj9t+tA+D82B09lizAM=; 24:zB1jDyBvfuRlLoyGpuLpuc9ORn3ItZ5Knoeq+zZO34KJC2ftmKHaD49qQhBYh9B9vvjVAee/+6w4d1u3iChWUH+/Q8OzFAbO62DKUtpLEV4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0755; 7:LYegnuMJuWEh7lG+EPnTV1ogkqqG4G6Smakulv2sinJYMAZddPdy1ieUAoA/QPOo54qBf3Rp548Yzopgj6sXCKND39njENX7G2InGqORL2Nhmv84yg3QDUg851ahvwx2OBVC7/6bq7xISVk7kA/pMVwNNIsbk8JbVlfscAeGd1JGQkzxbhtwNRDaHDo+pYOjIVveqVKW9Jdne3rB++gtJzrPXyfaq2bZdbEEuklAKtNleSTTQSceicTxMxY0tmKv X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 08:12:08.7725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d58c3315-fc39-4524-97e3-08d5e3182bd7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0755 Subject: [dpdk-dev] [PATCH v3 11/16] bus/dpaa: cleanup unnecessary global variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 08:12:12 -0000 Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 ----- drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c | 2 +- drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman_priv.h | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 +- 6 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c b/drivers/bus/dpaa/base/fman/netcfg_layer.c index 3e956ce..031c6f1 100644 --- a/drivers/bus/dpaa/base/fman/netcfg_layer.c +++ b/drivers/bus/dpaa/base/fman/netcfg_layer.c @@ -18,11 +18,6 @@ #include #include -/* Structure contains information about all the interfaces given by user - * on command line. - */ -struct netcfg_interface *netcfg_interface; - /* This data structure contaings all configurations information * related to usages of DPA devices. */ diff --git a/drivers/bus/dpaa/base/qbman/bman_driver.c b/drivers/bus/dpaa/base/qbman/bman_driver.c index 1381da3..b14b590 100644 --- a/drivers/bus/dpaa/base/qbman/bman_driver.c +++ b/drivers/bus/dpaa/base/qbman/bman_driver.c @@ -15,9 +15,9 @@ /* * Global variables of the max portal/pool number this bman version supported */ -u16 bman_ip_rev; +static u16 bman_ip_rev; u16 bman_pool_max; -void *bman_ccsr_map; +static void *bman_ccsr_map; /*****************/ /* Portal driver */ diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index f5fe5ef..7c17027 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -625,7 +625,7 @@ struct qman_portal *qman_create_portal( #define MAX_GLOBAL_PORTALS 8 static struct qman_portal global_portals[MAX_GLOBAL_PORTALS]; -rte_atomic16_t global_portals_used[MAX_GLOBAL_PORTALS]; +static rte_atomic16_t global_portals_used[MAX_GLOBAL_PORTALS]; static struct qman_portal * qman_alloc_global_portal(void) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index 07b29d5..f6ecd6b 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -20,9 +20,9 @@ u16 qm_channel_caam = QMAN_CHANNEL_CAAM; u16 qm_channel_pme = QMAN_CHANNEL_PME; /* Ccsr map address to access ccsrbased register */ -void *qman_ccsr_map; +static void *qman_ccsr_map; /* The qman clock frequency */ -u32 qman_clk; +static u32 qman_clk; static __thread int qmfd = -1; static __thread struct qm_portal_config qpcfg; diff --git a/drivers/bus/dpaa/base/qbman/qman_priv.h b/drivers/bus/dpaa/base/qbman/qman_priv.h index 9e4471e..02f6301 100644 --- a/drivers/bus/dpaa/base/qbman/qman_priv.h +++ b/drivers/bus/dpaa/base/qbman/qman_priv.h @@ -139,7 +139,6 @@ struct qm_portal_config { #define QMAN_REV31 0x0301 #define QMAN_REV32 0x0302 extern u16 qman_ip_rev; /* 0 if uninitialised, otherwise QMAN_REVx */ -extern u32 qman_clk; int qm_set_wpm(int wpm); int qm_get_wpm(int *wpm); diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 7956bd0..5ba3d28 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -50,7 +50,7 @@ struct rte_dpaa_bus rte_dpaa_bus; struct netcfg_info *dpaa_netcfg; /* define a variable to hold the portal_key, once created.*/ -pthread_key_t dpaa_portal_key; +static pthread_key_t dpaa_portal_key; unsigned int dpaa_svr_family; -- 2.7.4