From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 98B7C569A
 for <dev@dpdk.org>; Mon, 13 Jul 2015 10:49:50 +0200 (CEST)
Received: by widjy10 with SMTP id jy10so62634272wid.1
 for <dev@dpdk.org>; Mon, 13 Jul 2015 01:49:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=I1bqE5BAOSgnOVAR5XNqwD+5uXqmWIF3yd6TYNnIlXw=;
 b=L+MXPyRD/tQ+sMkRi8XFmPkZDkM+oDqK4KNFQDKLFkWayjuadMveWedn6LiIXJ1zl5
 HLKQL3QbCetsEWRczQWQ3KORWyDLbln2QaTGPli4N+ACc+hH2ga++QfSeh0udaOput9A
 i7ALQ0kFuB4NugSfo0jOoAc3nDGR3r4VQRQbD8SMYqKyqSH6J1FpKhdjG+d+H7stjRM1
 ZeFIvps0g7iiS6y+g+EAnDbHIgeTaGBnWA0hIYQg39U/RD5RW9HYGs/4VBANybJo4iak
 2rEYqcraa8B69uH68F7DNa/BUfwO/phOVdBqzF+BKfQRPczI92i/foTHnr2Ivm/nLhC3
 7Lkw==
X-Gm-Message-State: ALoCoQlXhHpQp80lX61yA79r/GE4mNQ0jcJCW1V+DcBIx0nPvC0501Z/udDStYnUKhdyuVuwq1qn
X-Received: by 10.194.87.102 with SMTP id w6mr7562564wjz.111.1436777390462;
 Mon, 13 Jul 2015 01:49:50 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id lu5sm27908267wjb.9.2015.07.13.01.49.48
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 13 Jul 2015 01:49:49 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Date: Mon, 13 Jul 2015 10:48:36 +0200
Message-ID: <1531097.HZDUsMDq83@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F6B1A0@IRSMSX103.ger.corp.intel.com>
References: <1436367323-19968-3-git-send-email-thomas.monjalon@6wind.com>
 <1436373856-29468-1-git-send-email-thomas.monjalon@6wind.com>
 <B27915DBBA3421428155699D51E4CFE2F6B1A0@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mk: enable next abi preview
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 08:49:50 -0000

2015-07-13 07:32, Mcnamara, John:
> This change to enable CONFIG_RTE_NEXT_ABI=n breaks validate-abi.sh
> because master won't compile with CONFIG_RTE_BUILD_SHARED_LIB=y and
> CONFIG_RTE_NEXT_ABI=n:

My bad. I thought I was testing both cases (next ABI and stable one) but
it appears only the "next one" was tested.

The error is trivial:
-       $(Q)ln -s -f $< $(RTE_OUTPUT)/lib/$(LIBSONAME)
+       $(Q)ln -s -f $< $(basename $(basename $@))

The double basename should apply to NEXT_ABI case only.