From: Kiran Kumar <kkokkilagadda@caviumnetworks.com>
To: dev@dpdk.org
Cc: jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com,
Kiran Kumar <kkokkilagadda@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH] net/thunderx: Block sq door writes on zero pkts
Date: Wed, 11 Jul 2018 12:52:03 +0530 [thread overview]
Message-ID: <1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com> (raw)
With current code, we are performing sq door writes even with 0 pkts.
this will create pressure on register bus. This patch will block these
writes.
Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx")
Signed-off-by: Kiran Kumar <kkokkilagadda@caviumnetworks.com>
---
drivers/net/thunderx/nicvf_rxtx.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c
index 72305d9..8075a8e 100644
--- a/drivers/net/thunderx/nicvf_rxtx.c
+++ b/drivers/net/thunderx/nicvf_rxtx.c
@@ -162,12 +162,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
free_desc -= TX_DESC_PER_PKT;
}
- sq->tail = tail;
- sq->xmit_bufs += i;
- rte_wmb();
+ if (likely(i)) {
+ sq->tail = tail;
+ sq->xmit_bufs += i;
+ rte_wmb();
- /* Inform HW to xmit the packets */
- nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT);
+ /* Inform HW to xmit the packets */
+ nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT);
+ }
return i;
}
--
2.7.4
next reply other threads:[~2018-07-11 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 7:22 Kiran Kumar [this message]
2018-07-11 7:37 ` Jerin Jacob
2018-07-11 8:24 ` [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets Kiran Kumar
2018-07-11 9:05 ` Jerin Jacob
2018-07-18 9:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com \
--to=kkokkilagadda@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=maciej.czekaj@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).