From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: [dpdk-dev] [PATCH 3/3] eal: deprecate device attach and detach functions
Date: Wed, 11 Jul 2018 15:14:10 +0100 [thread overview]
Message-ID: <1531318450-3942-4-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1531318450-3942-1-git-send-email-arybchenko@solarflare.com>
Hotplug functions should be used directly to add and remove devices.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
lib/librte_eal/common/include/rte_dev.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fc3bf1a0b..2d8f03472 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -79,6 +79,11 @@ Deprecation Notices
Function ``rte_eth_dev_get_port_by_name()`` may be used to find
identifier of the added port.
+* eal: In v18.11 ``rte_eal_dev_attach()`` and ``rte_eal_dev_detach()``
+ will be removed.
+ Hotplug functions ``rte_eal_hotplug_add()`` and ``rte_eal_hotplug_remove()``
+ should be used directly.
+
* pdump: As we changed to use generic IPC, some changes in APIs and structure
are expected in subsequent release.
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index ba6e445fc..a51f296e6 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -175,6 +175,7 @@ struct rte_device {
* @return
* 0 on success, negative on error.
*/
+__rte_deprecated
int rte_eal_dev_attach(const char *name, const char *devargs);
/**
@@ -185,6 +186,7 @@ int rte_eal_dev_attach(const char *name, const char *devargs);
* @return
* 0 on success, negative on error.
*/
+__rte_deprecated
int rte_eal_dev_detach(struct rte_device *dev);
/**
--
2.17.1
next prev parent reply other threads:[~2018-07-11 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 14:14 [dpdk-dev] [PATCH 0/3] deprecate " Andrew Rybchenko
2018-07-11 14:14 ` [dpdk-dev] [PATCH 1/3] app/pdump: use hotplug add instead of attach Andrew Rybchenko
2018-07-11 14:14 ` [dpdk-dev] [PATCH 2/3] ethdev: deprecate attach and detach functions Andrew Rybchenko
2018-07-11 14:14 ` Andrew Rybchenko [this message]
2018-07-26 21:32 ` [dpdk-dev] [PATCH 0/3] " Thomas Monjalon
2018-08-01 16:26 ` Stephen Hemminger
2018-08-05 23:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531318450-3942-4-git-send-email-arybchenko@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).