From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680062.outbound.protection.outlook.com [40.107.68.62]) by dpdk.org (Postfix) with ESMTP id A17B098 for ; Wed, 25 Jul 2018 00:18:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yEnK9SLXWjUcHM7qE+usDQY09BTdZBqvIjrC+40keQo=; b=kwgT2PLzbODKJ4VMQ9YISxT0lPZ7dTtHLttrIgQ65+ZUHD7wYmdsmTu93NL68nYLYaVz8ue6+vRzd+J4OFncv0u1rfUdY39a49LprKuA0p5S8Ww/lrl7Unuf8Xi/GYEMEKfKRGcv3Xz0sodO5ML9swXtzjUxp4KtpiPXLa1wX4w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.6) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 22:18:56 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Tue, 24 Jul 2018 15:18:41 -0700 Message-Id: <1532470724-31668-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.6] X-ClientProxiedBy: CO2PR18CA0046.namprd18.prod.outlook.com (2603:10b6:104:2::14) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3113892a-1f19-40f3-09c1-08d5f1b372f8 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600073)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:D7+dHAo+SCnHVxDY4fKIsUhnq7SXppOcIkB9CD26zkIvgSamptaO5K4f3/L6K1deNZaFvCuUCu1r3Fcd6m3EMKowr/Bgeg1zcAFaW9Jh5g2hF9WbfVJ0MQ7EnHqpYZEx0eVuxpAecZJF6k3REw28SsckbM/e4WzjESRnYBeG0wtxjc1ZYwqtURBaAatQMkuYDW2f36QFDlWHUgl5Yo8seIacI6xo1P47MnkN5TWA9TWbrtw22nRA7P6+DhclETli; 25:EvUK7RdZJ0A7UMs0+FUrbVwtYrYXiZsUiO89EMwa2mxL4bSemM+lGi64et/z90V2FO7e88D8P3LbvCG5dCsLxA2Y4GaZjeU293BUuJ44kcBsDRfL+0VqcIVnr1KCrw/Y4ExWYibvTKKwtbYKRiHfmLpyDBeOf75tDiSSZkNOCo5q/RnleH29nEndbYy1wnaBugjGgBLo9YWBFzKMNEnAkqGnPwsOP7pZj3Oj5Q9wH5MbbC4gtW9zh8oz26bL9t31hyYfXDWtbaqBgks5e+Ok/IDHoim0TGZWMWFCkZvIS449z600y3/7LW3UeDgwPXZVEVBK5Df3+tRwXlev374IEA==; 31:eneQwGN3Hs9lgzt2pppthA4gO+SfPnRfv2JYrg4MFwyrj6vrSbSgAFd8x3bhy8oO7snKdOEIwQ4DN6WD+8BZWZ18WX0OZ5d3xk33nM7yPyV640WdJJy0OAlOaIMRhUYNMHZc31srIuWb3rNlFubrUbOdEGriRl9ay2uwFNrDZs/qillqsuSBcpaE6APNMhUlpFqsgT2WIOzZAQd+wXf/YKLQe9PRbeuhfMHbVTTIavk= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:AklNc6v7+VDrr/CHZ1FAbx90HexYfgSZelvzWqA6589LcuySU6sOvgykK+v1lIBSPSdLcBevGVvT8lRn0I/G1grMii8WgEYnfnIRi18BqwCxok/lUv3SMXPsD+4stM4TG+TIgiTtBXXdWOVL7aa653Tac4QPHMd+P4Zqymlrg8oG06mBdvihGsTwFJlyjH1MG6UrJQli2/DZ0st7lt5Vs9wG4W8t2onEljr7l28sHMySmvSe+vQxqCj3x/LNonSO5W3SSbl8rawpwPFWgjPdmQFuP1GM1VCMc+KZXfEbnOMK+UEy9Y75OiHZDjGaotjQUGqR2dyR5W8QRbm+2VAdGTxasnj34eDAXheab9SBwRRl3Zc5h8sdg0RC/ecJo+xvDBvacG2lVUr54YlU2toiqkx2GdmWH4FJ8Rs2QryD0oOTd03Q6HfPX2Swn0T5fDtuf5BJiYKVNay+W43QisqixatLbBTHUmcH9wpUz0/kAC7HKAo+uTtJuFeP61wro//P; 4:b3xO/pjyOE/xCYi7C/wEUMmrlGUHc+T9kZVGBDNYGAiYzaVj+BfeC92CqUxTiudljQ1CXThU4LN1qYIWByRRshNWAR9Ls/00skg52YE0RNdMGV/MUFq2HOCg2KBXDt7hnV1ZHO9B5OSwMRcpzZ/qJBmCBbXG8L1QL2/8+jXmZ4zDVArt6tX6HVbWJmyhPvbGb1xfUCisw64WVphrII9x7EPn4KmaNZNvNZcGxgTHrt7L/1TAKE7xfACMvJ6S8QcPb8vmVZ/jS+7cNToVF+AuBg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(199004)(189003)(44832011)(478600001)(25786009)(486006)(72206003)(2361001)(55016002)(53936002)(97736004)(4326008)(47776003)(956004)(107886003)(2616005)(8936002)(186003)(51416003)(52116002)(386003)(7696005)(16526019)(26005)(106356001)(66066001)(5660300001)(36756003)(105586002)(2906002)(50226002)(7736002)(476003)(68736007)(14444005)(4720700003)(21086003)(69596002)(6116002)(316002)(6916009)(6666003)(81156014)(81166006)(16586007)(86362001)(50466002)(305945005)(2351001)(3846002)(48376002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:i2sDYO3Gq7bypzMJSc1IbciQS6opW9hPbdr18HnhH?= =?us-ascii?Q?KUhovcpJzKGR04HncqnAfYdAoDyUj6d5L9+Oq8feLhsu8NyCQHCZZp/ifvWi?= =?us-ascii?Q?gP3p2BSSFjkt465HDXYZ8+YcJOMoTJtOXLLhEvY0iYZYY/RboWaTIgSr809h?= =?us-ascii?Q?G5ByKQ+G7w8ENOrwkIfKZ34/w5ZM9lMDXMmeJJmqLjrt/M7oOXwS/32Xr++n?= =?us-ascii?Q?GYWTpRNCQiphVdKNMOOqYNFkGhBpJObVBiyVCSrufLiTLMGJNhZMP89IRlY6?= =?us-ascii?Q?ZkaZrOOvDapFdr4LyA62vLTOUlExucQ1ZJJ89w5I7Ow3qpP3kSD9WJ4h5lx+?= =?us-ascii?Q?xn8tbsNKRjy2klXz+5Jf2dFpM7KAf/Ng7iUFjBj2oh3j2iHqQqzWDT4yU7Qz?= =?us-ascii?Q?QxBLMRYNXelbCJTpKokXw+kfQHy3qMh1TqWiraJvUIktEtgH8lGqYymr0SuY?= =?us-ascii?Q?PiFdp/lki8QugK7ro3eQ/Yu5nXV1HbOeZpUIHbRmYK/Ryp8bauWjOgU+hCUw?= =?us-ascii?Q?gNIEpwdQq0Vvmhormi3NbnARdMdhLyP+UCjxa/qn/gBMdmJoj0N+KMsDMvcN?= =?us-ascii?Q?vR/0ZM7U9Sh8tHfro34RBdn9ksoZTzgzk4W7DFUzsgNlc5z5ofNnyhNDCqwm?= =?us-ascii?Q?vDMo8xToPaZOnwzS4QFzDivgvKbsFGPoTUzD4j8WQRiSSFFM9FZ6MYUIXnHL?= =?us-ascii?Q?+nyQ+Aoo6KfnwJQxl5xPIAS1+eC2cm85AKcthpCw9IX7r9PcPgJggbk2gdwJ?= =?us-ascii?Q?cbdZdyNFApbg1nBXXnwr5j9XxI3LnO3ldyQmENm6uSlHn36ntIXmCTulsBct?= =?us-ascii?Q?hXfwR5Jgq6Lp4UsGo3ANiwjIk7eYH6cSC0o2g4UaTSDTs7OVyDPvTcqPBjfu?= =?us-ascii?Q?hj7b3D0pttuacUJ2prZ9qE4Lx+n3oysGTKLMRzh82SD3iXlbN+ALadZVo+xM?= =?us-ascii?Q?5uHsBodtSR5sWu/H2UPI6F7MoqlBxdxMnXXR0SnKlNbyJ76CrrpixyG+NTAJ?= =?us-ascii?Q?45jkTSIdd7b0mPSpFagDK0efWMYrR0/jINlq+BMMK8sAYXSJJGJTK04dVI4L?= =?us-ascii?Q?+hMWZ1hXWdGQZHX0GCpxZENhVL3xXRBFgwK9gRmbNdLkyIqD9OJza1oXM/Ng?= =?us-ascii?Q?/qjGvfghkXNEMKGyqMt4ratuoM5Tc5GRRodsI7JKTbQBVSGw1FFpFgCBZeXn?= =?us-ascii?Q?ApIas3C/QyS29zoElb/O+HkGEMLqQrfnRgZnN2dg3RgyrcU8L3OnwSZEDaMT?= =?us-ascii?Q?R8IvBmv1ZnEvjTMjBkdquGmpqkEnEIRUHzC3e9X5kLWka9eGwH96c8rihdk/?= =?us-ascii?B?Zz09?= X-Microsoft-Antispam-Message-Info: iDIJkecySdx0HbnaxCyP5jyGDD5ylXltP2Yjp+h5c+XucvafETuemxBUvqwzvEgo2Z6oUQw4nbH53/ga1FLaxkQzGDLalzZer1B5WVCklu+m73uRvEF3TXGgNktk9kuXIHX0PAmDN9fTEWTy6QOCeo/Y+yRrQ8yr+CyEKwzXMOj6nenL5LCP6FiYXPd3tZZ1KuVuRMNAOBwCg+4oh7cd0nwotaHMQccFhe+K4HY36t/XbID8/djrzztw7LUlYVxyiWBdVFCZ24HdlMAmCnIo8LvtbYQw3XCon4tI63Etye+BdP7gkhw3FSWIaPUkADViBwiT0mEy0xx+k018Q4eVdvF7J4tCDvIUxatkxm2/8nU= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:tUOylOyiupYWrrpvdyWdirATVhVtjlW24mBueqOD4UDzHg+VhtaPBuHqTc74MjVVZkMaBBYwDg02bpLnlwBI/KDe2uor/1xso9zAjpP384vE9OAJFkTdKxSORv2DJRLK5/GFh3yUwAie9YQuu8o4bkHdpeRvHn0seCzpLiQIp8XMR2whSPl5ike71kUUUNqCjaLE4eIbrqCB9vd3KNX4aY/LkvayRZ/qsElXCmzqNuZjWUBVVy2VrLm8hTTNuMgliG/JV/p9MhN2ZBihuAs7S2qph9SRoEG1IzIExWQ2QSDzUv6jsPV961OKntYN7mfjOdJQhIl+J4IRrjqtjKxwD9cuwapunxSZfAtnfvHBxZ1Xm5XWE80Pe5WItmJYLmn5qMzwA02ZCBI2Tt1Y4W78Btxpu0ZFSlkb/4DL+NdtcWn5JGtzRsPTw7LIAhmNdXCZjs3VYwbYFdtVjnPCo1I46g==; 5:ORPpBZYQ4ixhFrff8jEOALoF/Uen0Mq8bfHOir3q7OomDSe4igqYxqS617xH6EfCtGZCaZhok+YWElqpg0anybc8e5DLLtdEsZBs81zSV1nWRrk3tcMQz+5QRKsgzQofxhQ7I91aPSqjeeABJPo5bb4jju5533j2rYPTYRnid50=; 7:sU1zfUxfh2BeEyQIXK/dOPJdG0LWbYjcE2MXm5xz/GXa7fDb0Tsa+X/cnFctnT4cPqiUqubnYYOdUhPjcxSqNN94vsj1zaBn8S27A7woW0O982l+fyzZtb0RpPS4twzGp/qX3q9GIR2waKB8MZMaI1OqBzVB0z/cu1LzCqAyQdNVXXlh8e8Bm5oJMJPrwZESf8sKFIuqYJinnnGnI5u0BAzcSeYYvzescfanVBHN64iIVX5XM7XmYRKC8hnrlP6d SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 22:18:56.6841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3113892a-1f19-40f3-09c1-08d5f1b372f8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 1/4] net/qede: fix handler in interrupt callback unregister X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 22:18:59 -0000 From: Shahed Shaikh Commit 023d7a0449f11 ("net/qede: fix legacy interrupt mode") added a handler for legacy interrupt mode but forgot to unregister same handler in rte_intr_callback_unregister() Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 3a57a42..88c805c 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1729,8 +1729,20 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) qdev->ops->common->slowpath_stop(edev); qdev->ops->common->remove(edev); rte_intr_disable(&pci_dev->intr_handle); - rte_intr_callback_unregister(&pci_dev->intr_handle, - qede_interrupt_handler, (void *)eth_dev); + + switch (pci_dev->intr_handle.type) { + case RTE_INTR_HANDLE_UIO_INTX: + case RTE_INTR_HANDLE_VFIO_LEGACY: + rte_intr_callback_unregister(&pci_dev->intr_handle, + qede_interrupt_handler_intx, + (void *)eth_dev); + break; + default: + rte_intr_callback_unregister(&pci_dev->intr_handle, + qede_interrupt_handler, + (void *)eth_dev); + } + if (ECORE_IS_CMT(edev)) rte_eal_alarm_cancel(qede_poll_sp_sb_cb, (void *)eth_dev); } -- 1.7.10.3