From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680083.outbound.protection.outlook.com [40.107.68.83]) by dpdk.org (Postfix) with ESMTP id DD23C2BF1; Wed, 25 Jul 2018 00:19:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjQPl/Yto7vC8CDPDc9ewHOKUxkFxOYNaX2T58xq7/o=; b=oC7r2BNm11LyTNztc6d2rhDYjcQm4DHrRVmsjENr2QIJT5ZnKM8iDu7kNvbLXJ1g3LT+9sjG8/UVzw4v6Cp6+a1a1cQM8qbgjeFq2yxQGZK+egN8SjZZsnccHjqJKiDiSQLjnSj8UgfbcYQBkqCWzmp5QlN+uF4S1rwpHFC5HSw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.6) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 22:18:59 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Tue, 24 Jul 2018 15:18:42 -0700 Message-Id: <1532470724-31668-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1532470724-31668-1-git-send-email-rasesh.mody@cavium.com> References: <1532470724-31668-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.6] X-ClientProxiedBy: CO2PR18CA0046.namprd18.prod.outlook.com (2603:10b6:104:2::14) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23bbe3dd-0d24-44d1-95f5-08d5f1b37488 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600073)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:5TXdo27ZSMf8uieX4KJpxrDQ42B99ZjJlGLXioXKY0aMzEX3n1pguFWkp1DwfXjX+S302L5X6oRikw7qyZv4Uk5FmYp/EyvEYc3SinVaRls5uilMGwW8qDloZD6yDTMmGI3TfCBksSlDQG4RyNcXNrkWHJ6uyzqP7b13EZoVGJpIsvSoARVDv/uZshAEskSzYhDcaEjEKe4QoJ88wS6wuVjGnkBVcq0emgh/GcKzHHoBSOMBZk/QHvGJQlkxPuin; 25:VGawULaOpbb2lRatr14T/dYBDpF1NWzL0f9Ktp6vHUhHayF8039yP8VQPR8Mu46DPJTIy7UswsHzSTb5bqBkSRDJ644VtarGdfJrqrBa2/Mjx+MGpqZm736OeICdyJjiI7cN8A9wCf8+w9dNwQZT+mzMuX7vA/rngP+zMBd6+gL6X43FUZ1qcbL6ufipHhRDZWV0Ki0OIny37MvD23XB9rT+Z+UbETtKInVh+Gg38aYX+EZ5wFmCQsu4P4NsH6nD84CDHH6IvpwO3NEGVL++yZ/zEDVP9nli3Nq5E1MECj0/frEma6z409q+fWgVfjkWcGJs6biCvtfBIUIn89NoSQ==; 31:v+TZByNw3BUiTCsyxs3G0jG84/ejh0nucIK6Y/AM2+Azu9FXFdz71X5CMVNGqNb+UAYa74x7XNCmfMkxRvbKhMlqW7fsllNaxEmbxCAGaRVD0Sp9Y+lJoHrDNObo8zqzf0Ywh2HE6XFjRiUm4Ckd82uoigOpkyom7hqJt7CSu8iH/7ozIydmWYf1bwzpTJfLgV7L7oZyW5e4XmxP0gT4eW2Xq7gEWs18Me9VL8uSfSA= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:MaRnOsdrabbktBJRbAuavnP7p67zCvtOWCF6dRnAn4Kf3J9q+gYx/l7xTUG40HwqMQ1JJVQxeCctiRwXWx5ZcF8terGWUaEWvdsiCbf68n7eel1ffJp58XUX+kN1MN+jgy/XC7gWc2Czc0RyaH59x5QAo8MKLrKkKPtsj7M4f58X0hs2+EfT08kC0Y2RYPmR0oHu6MFcJHbZbM2igwP84EhQA0y1SF3VSOV1iTUMocILzva3btDWDX/axHH7XH4VM1UzdA2JWnBm7cnYRrnPx1Zeo6B6tNx2RvSJ+q22UDxZlLcdhyACRwKnlgGYUmCsWDFN3ynE74Y5xzlpUugHRrQ3PYX81rJmLgN6VR8vK/yWsBqpP2oi+GZnWamX+Psk6lEPc3VQzwOwM6q8B0rNEswDODPch1F/NbJsxWig8iOMIBN1A4xBZlxFmxWulyVbEA1mfT3cm0LDZofQqtGqfiwLIpByfSu2xOh3ctOlzC8tiF/Zs1mp9Rl/Cp3ABmUc; 4:6tS2axVQJxlIbd7sunn+cJNE9FMCCUtrVvHTxD+MG23zgDdVnJGxVPQOBuBXy+vTs5qWjJ88uzJ3oFAd+MI9387QGe3R4JOjiQG1SpZ7lIb8Weh9sVIIMJGn+3XPU++5NLsnff3He4nGC0RjOsYC8hbkyLFoFPNB4hBigeejwS3JO9/bOPdgkQY33mbJBR7PXnaoolppM662USimQvi5RSnbE7niGG+NWjO/CR66OhH+MM6M7bQ91qbWyzpC/xu5K9Fmw6XAh2pFVdShAp/bhg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(199004)(189003)(76176011)(44832011)(478600001)(25786009)(486006)(72206003)(2361001)(55016002)(53936002)(97736004)(4326008)(47776003)(956004)(2616005)(8936002)(186003)(51416003)(52116002)(386003)(7696005)(16526019)(26005)(106356001)(66066001)(5660300001)(36756003)(105586002)(2906002)(50226002)(7736002)(476003)(68736007)(4720700003)(21086003)(69596002)(6116002)(316002)(6916009)(6666003)(446003)(81156014)(81166006)(16586007)(86362001)(50466002)(305945005)(2351001)(3846002)(48376002)(8676002)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:RouukYfro5DgBttanApXzIq4ml4nDl79vBa1vIqtQ?= =?us-ascii?Q?KkfuiR4FA6da01tgKrRuzZ6CXuOipB1tIlFBYAHvAq8yasvlq23DU3ERKnOU?= =?us-ascii?Q?F5S5Msp1XBORnNq7lAzSgaHet4k0nMMeVn0bCFql+M+xiLsl/fw27InAN1Kr?= =?us-ascii?Q?WRfQ/fQ8tWas2b1u0/BIo1Hm2D/l4Pog9t/XrkeQosu9k+08oNvRarmFwiNT?= =?us-ascii?Q?o9x1Qk+dbFOAzW9Vg6XYBcNGn/+kvDXOvWyDNgWghItGDBHj1EZ6XTtxVvfT?= =?us-ascii?Q?RVyYQwSBdVbfAV01gj1TXZdNadWx2EDgCfs29p4e+XR2wFmvOQAmq7xDkthe?= =?us-ascii?Q?97/+VmoP7W5NTyBR4g8FpGnTQk33rAerW9WZkYbhmbmvuUYCUCx3RkQToD+w?= =?us-ascii?Q?LXvMvdwSSK0rS2ENfA9icQDFuCrsrH19pVYvUajqcIRti2zGKydP0HM0ICC/?= =?us-ascii?Q?kDOIlF17Zs6Az/pbtuSv579w44lZsMJpMVC5dZK2BVynZ5Qk2I1o1qel9YVU?= =?us-ascii?Q?C1ND2ywZUAEnoS8wfaN1Z6+YQl943XDlYuF/JhUG1qpxsdZ/cK6u4gh3EYQy?= =?us-ascii?Q?UIrN4Fl+/sm4caqBdDNbfQvXm1BYcJsx9InEAfIC50PPN1e5WraYpcTWECVR?= =?us-ascii?Q?s1XJg48AjXsO9sk5J9+fQ1al34VCNl7dAUSphf60qwrWQOJ142Hfn1SHc0WM?= =?us-ascii?Q?TfVIc+PYB1WWEcaZYzYIMMS9HHEbhmXNymj0wRqEFgd393FjQ9d5CfkzjrqB?= =?us-ascii?Q?EqUqD0jnHd6O1g9bbZTGexYM1f5RTD61neb8HmgFNISu68v/pfku7KfzGl5v?= =?us-ascii?Q?HtL5m/m2e+wbr1Hb0M4wRG8nxmNO1BSvA7Juiw+i/nTiBf0xmBxOnvgH3pzE?= =?us-ascii?Q?DtpKOMCAeHTi9iblq+5llp1kw3WVr84MJyDizJyNWholK4+pKaRvciUobxGk?= =?us-ascii?Q?Y9s/lKDeKzGhU5BJpracrwJ31ewDCGA53kDBKA2fi2gRgXgbuasP8O7fEN9Z?= =?us-ascii?Q?7F4pEYMi6PkT399KHUlDzlaYenyLJ+XEhBbU8n8/+vAqh6lvJ2ZmkybCwcjZ?= =?us-ascii?Q?NcuK6XCSkYMxwopBSJpbSqne/SktepJN0mtkUPCwal6kdXkNn76vIy02Dnzl?= =?us-ascii?Q?P9ARsc3hhmtFfUg5/+bQ+WsDBiLVFuXrysAckrebDiTGUcevLLjK9lOVu4eu?= =?us-ascii?Q?c7xm5P7k8hFFpPp1Yihe69HsQXTP4/UmYm2hI35cGuj2nfv0KIPs6R8oOFql?= =?us-ascii?Q?KmNVwBfrauqUJqSc4DfvydmLeNZzNXem9GJzQl67OKn7LeDMnNHhpRLp3gSc?= =?us-ascii?B?QT09?= X-Microsoft-Antispam-Message-Info: IUFD/ORYDc0/ubJ7uEMeJ9T/SXBiBilwO7598qHmlYU2HfESksLMnNfXCHSWRuEjeMH7J8Ncn514OltM1erLZ5Pf3u5lzsXUomOQMM5r4joEIMaP2YhE/HaXIapM+oqhIFVZyYwN/tOyowW9SLP3ehQvuiauSRyZplZygtOzSI+YjY9FUjI+0mA80ZZvMlrvwMfjAQJhrsTDCLBN69zEz4I2H2PAC1n+72iHfATwmSyy7KsLE2PaWqJg4T89OCUvHcwOWsTV3H51hXCko8kQFHHwKpHF7tEKUr8kkYTgq+ZwnTLUolsImmJSFXrDrXJ+m0wQV1QZYeRl6I3JcecC5Y80fvB9LTXdnW7vm32fxIw= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:K1GJUsTddOI2YE7Ifu9EOZgMAkHXWc1pJY146jym1PNJn0P3IgNvJi77fIIswaNl4ZliVnGSwcyvc4de82KASafE9e7bg+7fk6+8ranVxy+VcKpLY1MYB72pQwleHN1Yt+BfYMmFBixcFaiCaF39T+ozMXuRORnivDOCBnhoQxraSCg5zWANf22s7XmDHFr5fPaKhTjpSEL7O1Pn9sCFo5P4vcfBp9aU2eamNHEX0znzhUy5Dc/4hBGqCjVdIIG9Hvk/vu2bugM1s67yoczKZVnifR3LZOilho+qB11aXzH7HvLkKr3zGp1OPArLO/9/KVaO76A7WKiDo4THfFJvFqsbHxe/LBxzthwlEN+slsR8YscEb/+Ha18AP6sauXVKfYm7cuHY28oyIERNTvuafntzR4tH7+hAkz3qlBuANPzJX3o72dniENxE/mgyOZQkqSf6tNzA06s8s7h2wDTU2A==; 5:ooWa3WafVs6gzzP/9uLAjSQmsm0PWbFnXl6x4znUHGtmQxvr5XtOXadJeIEjUAgXOTolNLPlstYxyC9Ge22b6jzSen41mANWoQzevbeRyURjeIs6axJuTJvyD2OWyudR+rRY2Y2IeOrlY6Gf1ApQXwkFvMtL+kBb7xBz5aBOgOg=; 7:0ByM9StoeciT03ieXiiVNADsb11NNk0G3tInyMrWDXO/sU+y5OZEe0P5UkZeBcPIHB32tYHDXLUlaiq0+/alakjF5IIGZtuKKeoTsRGqI5r8ZCr1Z7kuIpRxgGT/7scPFrkMRLnG5fNeF1kJs+XCZ8WsXggug96KwigrOubG4rp72UMRtUqqX2q/7+BV7BdIDvgdGDgXpTWRTho+rdPhkN7c1i6bbjelxFglYMU/FDZIw3xRdUnmu6izevoS4cso SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 22:18:59.2153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23bbe3dd-0d24-44d1-95f5-08d5f1b37488 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 2/4] net/qede/base: fix to clear HW indication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 22:19:01 -0000 VDMs may cause the was_error indication to be set after the driver clears it. Clear the indication after the internal FID_enable for the PF is set. Fixes: 60c78a5e258a ("net/qede/base: fix recovery from previous ungraceful exit") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index cfe73c6..31f1f3e 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2511,9 +2511,8 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, } } - /* Log and clean previous pglue_b errors if such exist */ + /* Log and clear previous pglue_b errors if such exist */ ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_main_ptt, true); - ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt); /* Enable the PF's internal FID_enable in the PXP */ rc = ecore_pglueb_set_pfid_enable(p_hwfn, p_hwfn->p_main_ptt, @@ -2521,6 +2520,13 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, if (rc != ECORE_SUCCESS) goto load_err; + /* Clear the pglue_b was_error indication. + * In E4 it must be done after the BME and the internal + * FID_enable for the PF are set, since VDMs may cause the + * indication to be set again. + */ + ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt); + switch (load_code) { case FW_MSG_CODE_DRV_LOAD_ENGINE: rc = ecore_hw_init_common(p_hwfn, p_hwfn->p_main_ptt, -- 1.7.10.3