DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rosen Xu <rosen.xu@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, rosen.xu@intel.com, ferruh.yigit@intel.com,
	orika@mellanox.com, walter.e.gilmore@intel.com,
	qi.z.zhang@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v4] examples/flow_filtering: add rte_fdir_conf initialization
Date: Tue, 31 Jul 2018 20:52:40 +0800	[thread overview]
Message-ID: <1533041560-164321-1-git-send-email-rosen.xu@intel.com> (raw)
In-Reply-To: <1531361387-116027-1-git-send-email-rosen.xu@intel.com>

Rte_fdir_conf of rte_eth_conf should be initialized before
port initialization. It is a workaround solution when working
with Intel I40e.

Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Acked-by: Ori Kam <orika@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

v4 updates:
===========
 - Fix typo and lack of punctuation.
 - Add why it is needed, and what are we waiting to remove the workaround.

v3 updates:
===========
 - Fix small comment of commit log and code comment

v2 updates:
===========
 - Take more test on I40e
 - Add comments
---
 examples/flow_filtering/main.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index f595034..ce91e8a 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -132,6 +132,22 @@
 				DEV_TX_OFFLOAD_SCTP_CKSUM  |
 				DEV_TX_OFFLOAD_TCP_TSO,
 		},
+		/*
+		 * Initialize fdir_conf of rte_eth_conf.
+		 * Fdir is used in flow filtering for I40e,
+		 * so rte_flow rules involve some fdir
+		 * configurations. In long term it's better
+		 * that drivers don't require any fdir
+		 * configuration for rte_flow, but we need to
+		 * get this workaround so that sample app can
+		 * run on I40e.
+		 */
+		.fdir_conf = {
+			.mode = RTE_FDIR_MODE_PERFECT,
+			.pballoc = RTE_FDIR_PBALLOC_64K,
+			.status = RTE_FDIR_REPORT_STATUS,
+			.drop_queue = 127,
+		},
 	};
 	struct rte_eth_txconf txq_conf;
 	struct rte_eth_rxconf rxq_conf;
-- 
1.8.3.1

  parent reply	other threads:[~2018-07-31 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  2:09 [dpdk-dev] [PATCH] " Rosen Xu
2018-07-12  5:17 ` Ori Kam
2018-07-12  5:26   ` Xu, Rosen
2018-07-12  5:58     ` Ori Kam
2018-07-12  6:22       ` Xu, Rosen
2018-07-17  5:15         ` Ori Kam
2018-07-17  9:57           ` Ferruh Yigit
2018-07-17 13:04             ` Ori Kam
2018-07-17 15:49               ` Ferruh Yigit
2018-07-21  7:50 ` [dpdk-dev] [PATCH v2] " Rosen Xu
2018-07-22  6:33   ` Ori Kam
2018-07-22 10:37     ` Xu, Rosen
2018-07-22 10:39 ` [dpdk-dev] [PATCH v3] " Rosen Xu
2018-07-23 20:32   ` Ferruh Yigit
2018-07-26 17:42   ` Thomas Monjalon
2018-07-31 12:55     ` Xu, Rosen
2018-07-31 12:52 ` Rosen Xu [this message]
2018-08-05 20:13   ` [dpdk-dev] [PATCH v4] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533041560-164321-1-git-send-email-rosen.xu@intel.com \
    --to=rosen.xu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@mellanox.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=walter.e.gilmore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).