From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9D5E12C5; Tue, 31 Jul 2018 14:54:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 05:54:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,427,1526367600"; d="scan'208";a="250467524" Received: from dpdkx8602.sh.intel.com ([10.67.110.200]) by fmsmga006.fm.intel.com with ESMTP; 31 Jul 2018 05:54:39 -0700 From: Rosen Xu To: dev@dpdk.org Cc: thomas@monjalon.net, rosen.xu@intel.com, ferruh.yigit@intel.com, orika@mellanox.com, walter.e.gilmore@intel.com, qi.z.zhang@intel.com, stable@dpdk.org Date: Tue, 31 Jul 2018 20:52:40 +0800 Message-Id: <1533041560-164321-1-git-send-email-rosen.xu@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> Subject: [dpdk-dev] [PATCH v4] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 12:54:47 -0000 Rte_fdir_conf of rte_eth_conf should be initialized before port initialization. It is a workaround solution when working with Intel I40e. Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") Cc: stable@dpdk.org Signed-off-by: Rosen Xu Acked-by: Ori Kam Reviewed-by: Ferruh Yigit v4 updates: =========== - Fix typo and lack of punctuation. - Add why it is needed, and what are we waiting to remove the workaround. v3 updates: =========== - Fix small comment of commit log and code comment v2 updates: =========== - Take more test on I40e - Add comments --- examples/flow_filtering/main.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c index f595034..ce91e8a 100644 --- a/examples/flow_filtering/main.c +++ b/examples/flow_filtering/main.c @@ -132,6 +132,22 @@ DEV_TX_OFFLOAD_SCTP_CKSUM | DEV_TX_OFFLOAD_TCP_TSO, }, + /* + * Initialize fdir_conf of rte_eth_conf. + * Fdir is used in flow filtering for I40e, + * so rte_flow rules involve some fdir + * configurations. In long term it's better + * that drivers don't require any fdir + * configuration for rte_flow, but we need to + * get this workaround so that sample app can + * run on I40e. + */ + .fdir_conf = { + .mode = RTE_FDIR_MODE_PERFECT, + .pballoc = RTE_FDIR_PBALLOC_64K, + .status = RTE_FDIR_REPORT_STATUS, + .drop_queue = 127, + }, }; struct rte_eth_txconf txq_conf; struct rte_eth_rxconf rxq_conf; -- 1.8.3.1