From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 0C399F72 for ; Tue, 31 Jul 2018 15:30:45 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id f21-v6so3085830wmc.5 for ; Tue, 31 Jul 2018 06:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=PJKgt4F1x5uROvrZtkc415pchVDniLGi57exc6G+41M=; b=hmD5ctjnV8Gjwf2QZ5bBps9gZFGwWYQWWwWb919/Mf8QT8J8+bnoxUiHf4qMhQM016 w0n9BlpB9Jd7KASt7PbsdTTDPRU/3UhttD8N2+mSzNtY9+LeF3RyikkwraSY1BR+9uNe AAcrcFDYmoTaSIWrlpXukhkVdInD1a8VXcxo9FXLqBa/MepoLxOY8crg5xU5G3+FnsYT nAh7mquMTsNZ1dU6v44JzJ4B4srTFcJ7glnt1bfzlTS9dcvIXxBHUAIUYiCTkEF8eYzG VrTIrvrTgEHuFJNbR+0Aov+eBt7PJTsKxWGrAQJX6IWgQRd4NaKMugoTCGsLYA8cwNFS IUWA== X-Gm-Message-State: AOUpUlGV/unVB5nSMyBsR68U/MJh99idG6OSqMwh7Pew2OqAOKHry3zD DroVx2kBQL0bRjUZaNHkYp8= X-Google-Smtp-Source: AAOMgpdQ9X52fmu6PB0XKuLf2g44wIM2x1YU9sGijy8igmoex/t5QP5XbKkPqtDEhUu8SCtyRbp95A== X-Received: by 2002:a1c:cc01:: with SMTP id h1-v6mr2220810wmb.82.1533043844677; Tue, 31 Jul 2018 06:30:44 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:dc12:297:5785:c4fa]) by smtp.gmail.com with ESMTPSA id q77-v6sm4270617wmb.38.2018.07.31.06.30.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 06:30:43 -0700 (PDT) Message-ID: <1533043842.20916.48.camel@debian.org> From: Luca Boccassi To: Timothy Redaelli , Matan Azrad , Shahaf Shuler Cc: dev@dpdk.org, Adrien Mazarguil Date: Tue, 31 Jul 2018 14:30:42 +0100 In-Reply-To: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com> References: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 13:30:45 -0000 On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote: > Stripping binaries at build time is usually a bad thing since it > makes > impossible to generate (split) debug symbols and this can lead to a > more > difficult debugging. >=20 > CC: Adrien Mazarguil > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") >=20 > Signed-off-by: Timothy Redaelli > --- > =C2=A0drivers/net/mlx4/Makefile | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile > index 63bc00337..92e932250 100644 > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -115,7 +115,7 @@ endif > =C2=A0$(LIB_GLUE): mlx4_glue.o > =C2=A0 $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ > =C2=A0 -Wl,-h,$(LIB_GLUE) \ > - -s -shared -o $@ $< -libverbs -lmlx4 > + -shared -o $@ $< -libverbs -lmlx4 > =C2=A0 > =C2=A0mlx4_glue.o: mlx4_autoconf.h Acked-by: Luca Boccassi Automated tools to generate separate packages with debug symbols (the standard at least in Debian and derivatives distros) break if a library is stripped, and it's very hard to notice as well as it's not an error per se. --=20 Kind regards, Luca Boccassi